From patchwork Wed Apr 10 10:04:38 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bastian Hecht X-Patchwork-Id: 2420251 Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 58D40DF2E5 for ; Wed, 10 Apr 2013 10:04:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752065Ab3DJKEq (ORCPT ); Wed, 10 Apr 2013 06:04:46 -0400 Received: from mail-bk0-f47.google.com ([209.85.214.47]:58888 "EHLO mail-bk0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752019Ab3DJKEp (ORCPT ); Wed, 10 Apr 2013 06:04:45 -0400 Received: by mail-bk0-f47.google.com with SMTP id ik5so128353bkc.6 for ; Wed, 10 Apr 2013 03:04:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer; bh=+HSSu5E1ZeJH0jPjsXZidR+30M+WcYr333hMkb4c2Mk=; b=o4sv4yTpLpPILElBGhBXbzUHsjU3oXo1QIcezSMt3W5YaT/6KQ+IViXx2hU/4yAk0R PKTuqNGOwvx26Mj90Sa7rFqGeqyVj4mB9zWU3vSPgrnnafFzFqpNtFzy9QEix2XSoyiU 8247VVmg6voR+KYDlWIT89rLe03exhMZMs0IF8Zsro7p5vWAnqzMEueWBmtEGB2Wj69L 847QJrPCrfSmg+PM29ekWacgxa3rr+aZxcFTwCOzrGTZNYDeko5vJjnvvTFHOrkG5Fx5 Fw/qcErMTt+LEYhEKV5TdSdHbxE6QbJ00aE0uqfkvk+c6N8v0LLgDLtK8WrgeGb4E9Tf M2mA== X-Received: by 10.204.231.6 with SMTP id jo6mr479049bkb.30.1365588284399; Wed, 10 Apr 2013 03:04:44 -0700 (PDT) Received: from localhost.localdomain (g229017229.adsl.alicedsl.de. [92.229.17.229]) by mx.google.com with ESMTPS id ej2sm4144637bkb.14.2013.04.10.03.04.43 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 10 Apr 2013 03:04:43 -0700 (PDT) From: Bastian Hecht To: linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org Cc: Dietmar Eggemann , Will Deacon , Magnus Damm , Simon Horman Subject: [PATCH] ARM: hw_breakpoint: Do not use __cpuinitdata for dbg_cpu_pm_nb Date: Wed, 10 Apr 2013 12:04:38 +0200 Message-Id: <1365588278-5185-1-git-send-email-hechtb+renesas@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org We must not declare dbg_cpu_pm_nb as __cpuinitdata as we need it after system initialization for Suspend and CPUIdle. This was done in commit 9a6eb310eaa5336b89a27a0bbb78da4bba35f6f1 ARM: hw_breakpoint: Debug powerdown support for self-hosted debug Signed-off-by: Bastian Hecht --- Hi, I've experienced a kernel oops while working on Suspend-To-Ram and CPUIdle on the Armadillo800EVA from Renesas. After echo mem >/sys/power/state I get: Unable to handle kernel paging request at virtual address e7fddef0 PC is at 0xe7fddef0 LR is at notifier_call_chain+0x40/0x70 I've bisected the kernel to the commit 9a6eb310eaa5336b89a27a0bbb78da4bba35f6f1 ARM: hw_breakpoint: Debug powerdown support for self-hosted debug and succeeded to fix it by removing the __cpuinitdata tag. Cheers, Bastian arch/arm/kernel/hw_breakpoint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/kernel/hw_breakpoint.c b/arch/arm/kernel/hw_breakpoint.c index 96093b7..8eb67bc 100644 --- a/arch/arm/kernel/hw_breakpoint.c +++ b/arch/arm/kernel/hw_breakpoint.c @@ -1043,7 +1043,7 @@ static int dbg_cpu_pm_notify(struct notifier_block *self, unsigned long action, return NOTIFY_OK; } -static struct notifier_block __cpuinitdata dbg_cpu_pm_nb = { +static struct notifier_block dbg_cpu_pm_nb = { .notifier_call = dbg_cpu_pm_notify, };