| Message ID | 1369057541.11578.1.camel@phoenix (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Commit | a987506daf4eac51c2df9b0e12575a0a2125c681 |
| Headers | show |
Hi Axel, Thank you for the patch. On Monday 20 May 2013 21:45:41 Axel Lin wrote: > Signed-off-by: Axel Lin <axel.lin@ingics.com> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/pwm/pwm-renesas-tpu.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/pwm/pwm-renesas-tpu.c b/drivers/pwm/pwm-renesas-tpu.c > index 8e6d8d7..319a6fe 100644 > --- a/drivers/pwm/pwm-renesas-tpu.c > +++ b/drivers/pwm/pwm-renesas-tpu.c > @@ -432,6 +432,11 @@ static int tpu_remove(struct platform_device *pdev) > { > struct tpu_device *tpu = platform_get_drvdata(pdev); > unsigned int i; > + int ret; > + > + ret = pwmchip_remove(&tpu->chip); > + if (ret) > + return ret; > > for (i = 0; i < ARRAY_SIZE(tpu->pwms); ++i) { > struct tpu_pwm_device *pwm = &tpu->pwms[i];
On Mon, May 20, 2013 at 03:46:59PM +0200, Laurent Pinchart wrote: > Hi Axel, > > Thank you for the patch. > > On Monday 20 May 2013 21:45:41 Axel Lin wrote: > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Thanks. I have queued this up for v3.11 in the pinmux branch of my renesas tree on kernel.org. > > > --- > > drivers/pwm/pwm-renesas-tpu.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/pwm/pwm-renesas-tpu.c b/drivers/pwm/pwm-renesas-tpu.c > > index 8e6d8d7..319a6fe 100644 > > --- a/drivers/pwm/pwm-renesas-tpu.c > > +++ b/drivers/pwm/pwm-renesas-tpu.c > > @@ -432,6 +432,11 @@ static int tpu_remove(struct platform_device *pdev) > > { > > struct tpu_device *tpu = platform_get_drvdata(pdev); > > unsigned int i; > > + int ret; > > + > > + ret = pwmchip_remove(&tpu->chip); > > + if (ret) > > + return ret; > > > > for (i = 0; i < ARRAY_SIZE(tpu->pwms); ++i) { > > struct tpu_pwm_device *pwm = &tpu->pwms[i]; > -- > Regards, > > Laurent Pinchart > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, May 23, 2013 at 10:39:34AM +0900, Simon Horman wrote: > On Mon, May 20, 2013 at 03:46:59PM +0200, Laurent Pinchart wrote: > > Hi Axel, > > > > Thank you for the patch. > > > > On Monday 20 May 2013 21:45:41 Axel Lin wrote: > > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > > > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Thanks. I have queued this up for v3.11 in the pinmux branch > of my renesas tree on kernel.org. I'd rather take this through the PWM tree along with the original driver patch. Thierry
On Thu, May 23, 2013 at 09:12:17PM +0200, Thierry Reding wrote: > On Thu, May 23, 2013 at 10:39:34AM +0900, Simon Horman wrote: > > On Mon, May 20, 2013 at 03:46:59PM +0200, Laurent Pinchart wrote: > > > Hi Axel, > > > > > > Thank you for the patch. > > > > > > On Monday 20 May 2013 21:45:41 Axel Lin wrote: > > > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > > > > > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > Thanks. I have queued this up for v3.11 in the pinmux branch > > of my renesas tree on kernel.org. > > I'd rather take this through the PWM tree along with the original driver > patch. Sure that is fine. I had them queued up in my tree but I have dropped them now. That should propogate to linux-next in the not too distant future. I have also dropped the following changes from my tree as they appear to ether depend on the TPU PWD driver or one of the other patches in the list below. Laurent, I think it would be best if you resubmitted these patches once there is a stable branch available with the TPU PWD driver merged which I can use as a base. ARM: mach-shmobile: armadillo800eva: Add backlight support ARM: mach-shmobile: kota2: Use leds-pwm + pwm-rmob leds: Remove leds-renesas-tpu driver sh-pfc: sh73a0: Remove function GPIOs -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Thierry, On Thursday 23 May 2013 21:12:17 Thierry Reding wrote: > On Thu, May 23, 2013 at 10:39:34AM +0900, Simon Horman wrote: > > On Mon, May 20, 2013 at 03:46:59PM +0200, Laurent Pinchart wrote: > > > Hi Axel, > > > > > > Thank you for the patch. > > > > > > On Monday 20 May 2013 21:45:41 Axel Lin wrote: > > > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > > > > > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > Thanks. I have queued this up for v3.11 in the pinmux branch > > of my renesas tree on kernel.org. > > I'd rather take this through the PWM tree along with the original driver > patch. As I will need to submit a new version of the renesas-tpu patches should I fold this patch in ?
2013/5/25 Laurent Pinchart <laurent.pinchart@ideasonboard.com>: > Hi Thierry, > > On Thursday 23 May 2013 21:12:17 Thierry Reding wrote: >> On Thu, May 23, 2013 at 10:39:34AM +0900, Simon Horman wrote: >> > On Mon, May 20, 2013 at 03:46:59PM +0200, Laurent Pinchart wrote: >> > > Hi Axel, >> > > >> > > Thank you for the patch. >> > > >> > > On Monday 20 May 2013 21:45:41 Axel Lin wrote: >> > > > Signed-off-by: Axel Lin <axel.lin@ingics.com> >> > > >> > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >> > >> > Thanks. I have queued this up for v3.11 in the pinmux branch >> > of my renesas tree on kernel.org. >> >> I'd rather take this through the PWM tree along with the original driver >> patch. > > As I will need to submit a new version of the renesas-tpu patches should I > fold this patch in ? Hi Laurent, I think you can fold this patch in if you are going to submit a new version of the renesas-tpu patches. Regards, Axel -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, May 25, 2013 at 03:42:42PM +0200, Laurent Pinchart wrote: > Hi Thierry, > > On Thursday 23 May 2013 21:12:17 Thierry Reding wrote: > > On Thu, May 23, 2013 at 10:39:34AM +0900, Simon Horman wrote: > > > On Mon, May 20, 2013 at 03:46:59PM +0200, Laurent Pinchart wrote: > > > > Hi Axel, > > > > > > > > Thank you for the patch. > > > > > > > > On Monday 20 May 2013 21:45:41 Axel Lin wrote: > > > > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > > > > > > > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > > > Thanks. I have queued this up for v3.11 in the pinmux branch > > > of my renesas tree on kernel.org. > > > > I'd rather take this through the PWM tree along with the original driver > > patch. > > As I will need to submit a new version of the renesas-tpu patches should I > fold this patch in ? Yes, that's fine with me. It'd be nice to credit Axel, though. Thierry
Hi Thierry, On Sunday 26 May 2013 11:18:24 Thierry Reding wrote: > On Sat, May 25, 2013 at 03:42:42PM +0200, Laurent Pinchart wrote: > > On Thursday 23 May 2013 21:12:17 Thierry Reding wrote: > > > On Thu, May 23, 2013 at 10:39:34AM +0900, Simon Horman wrote: > > > > On Mon, May 20, 2013 at 03:46:59PM +0200, Laurent Pinchart wrote: > > > > > On Monday 20 May 2013 21:45:41 Axel Lin wrote: > > > > > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > > > > > > > > > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > > > > > Thanks. I have queued this up for v3.11 in the pinmux branch > > > > of my renesas tree on kernel.org. > > > > > > I'd rather take this through the PWM tree along with the original driver > > > patch. > > > > As I will need to submit a new version of the renesas-tpu patches should I > > fold this patch in ? > > Yes, that's fine with me. It'd be nice to credit Axel, though. Sure. I'll add Axel's SoB line to the patch.
diff --git a/drivers/pwm/pwm-renesas-tpu.c b/drivers/pwm/pwm-renesas-tpu.c index 8e6d8d7..319a6fe 100644 --- a/drivers/pwm/pwm-renesas-tpu.c +++ b/drivers/pwm/pwm-renesas-tpu.c @@ -432,6 +432,11 @@ static int tpu_remove(struct platform_device *pdev) { struct tpu_device *tpu = platform_get_drvdata(pdev); unsigned int i; + int ret; + + ret = pwmchip_remove(&tpu->chip); + if (ret) + return ret; for (i = 0; i < ARRAY_SIZE(tpu->pwms); ++i) { struct tpu_pwm_device *pwm = &tpu->pwms[i];
Signed-off-by: Axel Lin <axel.lin@ingics.com> --- drivers/pwm/pwm-renesas-tpu.c | 5 +++++ 1 file changed, 5 insertions(+)