From patchwork Mon Sep 9 15:55:20 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guennadi Liakhovetski X-Patchwork-Id: 2862231 Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 997FFBF43F for ; Mon, 9 Sep 2013 15:55:41 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7B8F3202F6 for ; Mon, 9 Sep 2013 15:55:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A9AF420324 for ; Mon, 9 Sep 2013 15:55:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755298Ab3IIPzd (ORCPT ); Mon, 9 Sep 2013 11:55:33 -0400 Received: from moutng.kundenserver.de ([212.227.126.187]:57985 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755286Ab3IIPz0 (ORCPT ); Mon, 9 Sep 2013 11:55:26 -0400 Received: from axis700.grange (dslb-178-006-084-108.pools.arcor-ip.net [178.6.84.108]) by mrelayeu.kundenserver.de (node=mrbap1) with ESMTP (Nemesis) id 0LcVQE-1VijNP1BAM-00jMgW; Mon, 09 Sep 2013 17:55:21 +0200 Received: from 6a.grange (6a.grange [192.168.1.11]) by axis700.grange (Postfix) with ESMTPS id CBA7340BB7; Mon, 9 Sep 2013 17:55:20 +0200 (CEST) Received: from lyakh by 6a.grange with local (Exim 4.72) (envelope-from ) id 1VJ3o8-0002uL-JS; Mon, 09 Sep 2013 17:55:20 +0200 From: Guennadi Liakhovetski To: linux-i2c@vger.kernel.org Cc: Magnus Damm , linux-sh@vger.kernel.org, Wolfram Sang , devicetree@vger.kernel.org, Grant Likely , Rob Herring , Guennadi Liakhovetski Subject: [PATCH 5/5] i2c: rcar: use per-device clock Date: Mon, 9 Sep 2013 17:55:20 +0200 Message-Id: <1378742120-11135-6-git-send-email-g.liakhovetski@gmx.de> X-Mailer: git-send-email 1.7.2.5 In-Reply-To: <1378742120-11135-1-git-send-email-g.liakhovetski@gmx.de> References: <1378742120-11135-1-git-send-email-g.liakhovetski@gmx.de> X-Provags-ID: V02:K0:T6iLWoueI13/HZSu8ArlMqFv0idpv7wtfb92SRmYBxx Ll5SJNXqKUbybwjZldk9azsykumw2yWbQvPhXfOg74pHImkKcm MdSsW8txrOREDjtDSVHXy9RMuN4WwA7XchF5lbvB1LTuStlWtd yGZ/Lxv0EGb5U2RGVlCB7TzK7ZI0tuOO7uKirkg76Aa0FnBrfE asHllz1PqPA9GYffhvTJBnzswhfZV6x+iuLH49SmxtTX2lH1B+ BeeO/H2De4n2sM7h72IyCeJTUAxZDQ5rffBciGhm2sj7nzujmB se7QoxzArOQjDL4+wXnkF8MFAOkbHtg9z8usQlghTjSUNOiLa4 vp9pGoi+pHplGuW8wYxtfe/Zgd1XKL58fXvhX/sdrtodMS+nHh lj5RBvB/kdORQ== Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Using the same clock for all device instances is non-portable and obtaining clock references by an ID without using a device pointer is discouraged. This is also not needed, because on platforms, where this driver is used, suitable clocks are available for the I2C controllers, that are children of the peripheral clock and just pass its rate 1-to-1 to controllers. This patch switches the driver to obtain references to correct clocks. Signed-off-by: Guennadi Liakhovetski --- drivers/i2c/busses/i2c-rcar.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c index 7e71cf4..7b986cb 100644 --- a/drivers/i2c/busses/i2c-rcar.c +++ b/drivers/i2c/busses/i2c-rcar.c @@ -227,7 +227,7 @@ static int rcar_i2c_clock_calculate(struct rcar_i2c_priv *priv, u32 bus_speed, struct device *dev) { - struct clk *clkp = clk_get(NULL, "peripheral_clk"); + struct clk *clkp = clk_get(dev, NULL); u32 scgd, cdf; u32 round, ick; u32 scl;