From patchwork Thu Sep 12 12:36:48 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guennadi Liakhovetski X-Patchwork-Id: 2878231 Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id D76F6BF43F for ; Thu, 12 Sep 2013 12:36:59 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 21151201EA for ; Thu, 12 Sep 2013 12:36:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ECE7B201B8 for ; Thu, 12 Sep 2013 12:36:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754338Ab3ILMgx (ORCPT ); Thu, 12 Sep 2013 08:36:53 -0400 Received: from moutng.kundenserver.de ([212.227.17.9]:57004 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753873Ab3ILMgv (ORCPT ); Thu, 12 Sep 2013 08:36:51 -0400 Received: from axis700.grange (dslb-088-076-068-089.pools.arcor-ip.net [88.76.68.89]) by mrelayeu.kundenserver.de (node=mreu1) with ESMTP (Nemesis) id 0LwVGF-1W19ht0CNz-0186KE; Thu, 12 Sep 2013 14:36:50 +0200 Received: from 6a.grange (6a.grange [192.168.1.11]) by axis700.grange (Postfix) with ESMTPS id 1EEF240BB8; Thu, 12 Sep 2013 14:36:49 +0200 (CEST) Received: from lyakh by 6a.grange with local (Exim 4.72) (envelope-from ) id 1VK68e-0002lw-Tb; Thu, 12 Sep 2013 14:36:48 +0200 From: Guennadi Liakhovetski To: linux-i2c@vger.kernel.org Cc: Magnus Damm , linux-sh@vger.kernel.org, Wolfram Sang , devicetree@vger.kernel.org, Grant Likely , Rob Herring , Guennadi Liakhovetski Subject: [PATCH v2 5/5] i2c: rcar: use per-device clock Date: Thu, 12 Sep 2013 14:36:48 +0200 Message-Id: <1378989408-10618-6-git-send-email-g.liakhovetski@gmx.de> X-Mailer: git-send-email 1.7.2.5 In-Reply-To: <1378989408-10618-1-git-send-email-g.liakhovetski@gmx.de> References: <1378989408-10618-1-git-send-email-g.liakhovetski@gmx.de> X-Provags-ID: V02:K0:C+Q4z76H8PQu+Q3kghbsoF76SCWxLvubvwk5UNZhwTA 3k+yNRFhNqlKTugvI0lua6LRluoyffIViXctperNUYmrj1Mloh E7oq6h2EFoCcFpMNNMrfZr6aXVx2F3iKsXBPRKIPsUJAa/ZyrN fUUbPrJnPbwX4PYCc45GnRmmtodwBHelDgxo5nUHQDsv8+5fda 2nGYJJI52ZM7+mGsq6mNOTUpSiRXzmgJXKUmGl0ltVKS87x3sw WOrMc4iL4njpxgYSV5cfPLiM5EqYft0JHO4BU5EMnb+qbz7WLk yyHdE9cR4GbYoAU9VCVhmZOUrosOeo3U3SXjKZ4j+KyqV0Ltby DGXiH/8WvNk583tPZ1IXHVA9Q45Lj2qYnPAgkA5biVEVfZiFoC omvvUK7kc1Fjw== Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Using the same clock for all device instances is non-portable and obtaining clock references by an ID without using a device pointer is discouraged. This is also not needed, because on platforms, where this driver is used, suitable clocks are available for the I2C controllers, that are children of the peripheral clock and just pass its rate 1-to-1 to controllers. This patch switches the driver to obtain references to correct clocks. Signed-off-by: Guennadi Liakhovetski --- drivers/i2c/busses/i2c-rcar.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c index 98276eb..8603f5e 100644 --- a/drivers/i2c/busses/i2c-rcar.c +++ b/drivers/i2c/busses/i2c-rcar.c @@ -227,7 +227,7 @@ static int rcar_i2c_clock_calculate(struct rcar_i2c_priv *priv, u32 bus_speed, struct device *dev) { - struct clk *clkp = clk_get(NULL, "peripheral_clk"); + struct clk *clkp = clk_get(dev, NULL); u32 scgd, cdf; u32 round, ick; u32 scl;