From patchwork Sun Dec 1 18:19:17 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: takasi-y@ops.dti.ne.jp X-Patchwork-Id: 3262481 Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id D4F65BEEAD for ; Sun, 1 Dec 2013 18:38:02 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0AE08203AC for ; Sun, 1 Dec 2013 18:38:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3D7DF2034A for ; Sun, 1 Dec 2013 18:38:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751753Ab3LASiB (ORCPT ); Sun, 1 Dec 2013 13:38:01 -0500 Received: from gw.cm.dream.jp ([59.157.128.2]:53406 "EHLO vsmtp02.cm.dti.ne.jp" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751722Ab3LASiA (ORCPT ); Sun, 1 Dec 2013 13:38:00 -0500 X-Greylist: delayed 1201 seconds by postgrey-1.27 at vger.kernel.org; Sun, 01 Dec 2013 13:37:56 EST Received: from okucha.tokox1.kt.home.ne.jp (110-133-65-132.rev.home.ne.jp [110.133.65.132]) by vsmtp02.cm.dti.ne.jp (3.11v) with ESMTP AUTH id rB1IJP6q004587; Mon, 2 Dec 2013 03:19:48 +0900 (JST) From: takasi-y@ops.dti.ne.jp To: linux-sh@vger.kernel.org Cc: Simon Horman , Magnus Damm , Linus Walleij , Mark Brown , linux-spi@vger.kernel.org Subject: [PATCH 06/11] spi: spi-sh-msiof: RMDIR1[15:0] may should be zero Date: Mon, 2 Dec 2013 03:19:17 +0900 Message-Id: <1385921962-19843-6-git-send-email-takasi-y@ops.dti.ne.jp> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1385921962-19843-1-git-send-email-takasi-y@ops.dti.ne.jp> References: <20131202031557.162e78d407d82effdee627ac@ops.dti.ne.jp> <1385921962-19843-1-git-send-email-takasi-y@ops.dti.ne.jp> Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Takashi Yoshii On Ape6, Rcar-H2, and Rcar-M2, RMDR1(Receive Mode Register 1) has no FLD, CONT, RXSTP bits. HW manual says "The write value should always be 0" for RMDR1[15:0]. I guess this is a part of .rx_need_dummy_tx case, and use same flag. Signed-off-by: Takashi Yoshii --- drivers/spi/spi-sh-msiof.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-sh-msiof.c b/drivers/spi/spi-sh-msiof.c index 936d8ab..b0334b6 100644 --- a/drivers/spi/spi-sh-msiof.c +++ b/drivers/spi/spi-sh-msiof.c @@ -183,11 +183,13 @@ static void sh_msiof_spi_set_pin_regs(struct sh_msiof_spi_priv *p, */ sh_msiof_write(p, FCTR, 0); - tmp = 0; + tmp = 0x00000005; tmp |= !cs_high << 25; tmp |= lsb_first << 24; - sh_msiof_write(p, TMDR1, 0xe0000005 | tmp); - sh_msiof_write(p, RMDR1, 0x20000005 | tmp); + sh_msiof_write(p, TMDR1, 0xe0000000 | tmp); + if (p->info->rx_need_dummy_tx) + tmp &= ~0x0000ffff; + sh_msiof_write(p, RMDR1, 0x20000000 | tmp); tmp = 0xa0000000; tmp |= cpol << 30; /* TSCKIZ */