| Message ID | 1391595554-20640-3-git-send-email-ben.dooks@codethink.co.uk (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Wed, Feb 5, 2014 at 7:19 PM, Ben Dooks <ben.dooks@codethink.co.uk> wrote: > Add initial documentation for the pci-rcar-gen2 driver device tree bindings. > This is not yet complete and needs work on the sub-nodes for the PCI bus. > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > --- > Cc: linux-sh@vger.kernel.org > Cc: devicetree@vger.kernel.org > Cc: horms+renesas@verge.net.au > --- > .../devicetree/bindings/pci/renessas,pci-r8a7790.txt | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pci/renessas,pci-r8a7790.txt Hi Ben, Thanks for this. Regarding DT bindings, I agree about using the SoC as suffix in the compatible string since this is in line with what we do for other device drivers. I much prefer that over "gen2" or something else that may or may not apply to newer SoCs. As you probably know, the pci-rcar-gen2.c driver is intended to be used both on r8a7790 and r8a7791. Regarding this binding document, is it possible to make it one file for the driver instead of r8a7790 specific? That would match what we do for DT binding documentation for other device drivers. Cheers, / magnus -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/02/14 12:04, Magnus Damm wrote: > On Wed, Feb 5, 2014 at 7:19 PM, Ben Dooks <ben.dooks@codethink.co.uk> wrote: >> Add initial documentation for the pci-rcar-gen2 driver device tree bindings. >> This is not yet complete and needs work on the sub-nodes for the PCI bus. >> >> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> >> --- >> Cc: linux-sh@vger.kernel.org >> Cc: devicetree@vger.kernel.org >> Cc: horms+renesas@verge.net.au >> --- >> .../devicetree/bindings/pci/renessas,pci-r8a7790.txt | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/pci/renessas,pci-r8a7790.txt > > Hi Ben, > > Thanks for this. Regarding DT bindings, I agree about using the SoC as > suffix in the compatible string since this is in line with what we do > for other device drivers. I much prefer that over "gen2" or something > else that may or may not apply to newer SoCs. Great, let's get this lot reviewed and hopefully we can get this sorted before the 3.15-rc1. > As you probably know, the pci-rcar-gen2.c driver is intended to be > used both on r8a7790 and r8a7791. Regarding this binding document, is > it possible to make it one file for the driver instead of r8a7790 > specific? That would match what we do for DT binding documentation for > other device drivers. Thanks, should I change this to be renesas,pci-rcar-gen2.txt then?
On Wed, Feb 5, 2014 at 9:17 PM, Ben Dooks <ben.dooks@codethink.co.uk> wrote: > On 05/02/14 12:04, Magnus Damm wrote: >> >> On Wed, Feb 5, 2014 at 7:19 PM, Ben Dooks <ben.dooks@codethink.co.uk> >> wrote: >>> >>> Add initial documentation for the pci-rcar-gen2 driver device tree >>> bindings. >>> This is not yet complete and needs work on the sub-nodes for the PCI bus. >>> >>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> >>> --- >>> Cc: linux-sh@vger.kernel.org >>> Cc: devicetree@vger.kernel.org >>> Cc: horms+renesas@verge.net.au >>> --- >>> .../devicetree/bindings/pci/renessas,pci-r8a7790.txt | 12 >>> ++++++++++++ >>> 1 file changed, 12 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/pci/renessas,pci-r8a7790.txt >> >> >> Hi Ben, >> >> Thanks for this. Regarding DT bindings, I agree about using the SoC as >> suffix in the compatible string since this is in line with what we do >> for other device drivers. I much prefer that over "gen2" or something >> else that may or may not apply to newer SoCs. > > > Great, let's get this lot reviewed and hopefully we can get this sorted > before the 3.15-rc1. Sure. >> As you probably know, the pci-rcar-gen2.c driver is intended to be >> used both on r8a7790 and r8a7791. Regarding this binding document, is >> it possible to make it one file for the driver instead of r8a7790 >> specific? That would match what we do for DT binding documentation for >> other device drivers. > > > Thanks, should I change this to be renesas,pci-rcar-gen2.txt then? Sounds good to me! Thanks, / magnus -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/pci/renessas,pci-r8a7790.txt b/Documentation/devicetree/bindings/pci/renessas,pci-r8a7790.txt new file mode 100644 index 0000000..a6fd432 --- /dev/null +++ b/Documentation/devicetree/bindings/pci/renessas,pci-r8a7790.txt @@ -0,0 +1,12 @@ +Renesas internal AHB to PCI bridge + +This is the bridge used internally to connect the USB controllers to the +AHB. + +Required properties: + - compatible: "renesas,pci-r8a7790" for the R8A7790 SoC + - reg : A list of physical regions to access the device. The first is + the operational registers for the OHCI/EHCI controller and the + second region is for the bridge configuration and control registers. + - interrupts : interrupt for the device + - clocks : The reference to the device clock
Add initial documentation for the pci-rcar-gen2 driver device tree bindings. This is not yet complete and needs work on the sub-nodes for the PCI bus. Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- Cc: linux-sh@vger.kernel.org Cc: devicetree@vger.kernel.org Cc: horms+renesas@verge.net.au --- .../devicetree/bindings/pci/renessas,pci-r8a7790.txt | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 Documentation/devicetree/bindings/pci/renessas,pci-r8a7790.txt