| Message ID | 1394197299-17528-2-git-send-email-ben.dooks@codethink.co.uk (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On 07/03/14 16:45, Sergei Shtylyov wrote: > Hello. > > On 03/07/2014 04:01 PM, Ben Dooks wrote: > >> Add nodes for the four video input channels on the R8A7790. > >> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > > This patch should have been preceded by the VIN driver patch and > bindings description, don't you think? Given this is a pretty standard device and video input binding as already described in the relevant documentation, didn't really think it was necessary. >> diff --git a/arch/arm/boot/dts/r8a7790.dtsi >> b/arch/arm/boot/dts/r8a7790.dtsi >> index a1e7c39..4c3eafb 100644 >> --- a/arch/arm/boot/dts/r8a7790.dtsi >> +++ b/arch/arm/boot/dts/r8a7790.dtsi >> @@ -395,6 +395,38 @@ >> status = "disabled"; >> }; >> >> + vin0: vin@0xe6ef0000 { > > ePAPR standard [1] tells us that: > > The name of a node should be somewhat generic, reflecting the function > of the device and not its precise programming model. > > So, I would suggest something like "video". And remove "0x" from the > address part of the node name please. vin is a reasonable contraction of video-input.
Hello. On 03/07/2014 04:01 PM, Ben Dooks wrote: > Add nodes for the four video input channels on the R8A7790. > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> This patch should have been preceded by the VIN driver patch and bindings description, don't you think? > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi > index a1e7c39..4c3eafb 100644 > --- a/arch/arm/boot/dts/r8a7790.dtsi > +++ b/arch/arm/boot/dts/r8a7790.dtsi > @@ -395,6 +395,38 @@ > status = "disabled"; > }; > > + vin0: vin@0xe6ef0000 { ePAPR standard [1] tells us that: The name of a node should be somewhat generic, reflecting the function of the device and not its precise programming model. So, I would suggest something like "video". And remove "0x" from the address part of the node name please. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Mar 07, 2014 at 01:01:35PM +0000, Ben Dooks wrote: > Add nodes for the four video input channels on the R8A7790. Please update the prefix of this subject of this patch to: ARM: shmobile: r8a7790: > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > --- > arch/arm/boot/dts/r8a7790.dtsi | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi > index a1e7c39..4c3eafb 100644 > --- a/arch/arm/boot/dts/r8a7790.dtsi > +++ b/arch/arm/boot/dts/r8a7790.dtsi > @@ -395,6 +395,38 @@ > status = "disabled"; > }; > > + vin0: vin@0xe6ef0000 { > + compatible = "renesas,vin-r8a7790"; > + clocks = <&mstp8_clks R8A7790_CLK_VIN0>; > + reg = <0 0xe6ef0000 0 0x1000>; > + interrupts = <0 188 IRQ_TYPE_LEVEL_HIGH>; > + status = "disabled"; > + }; > + > + vin1: vin@0xe6ef1000 { > + compatible = "renesas,vin-r8a7790"; > + clocks = <&mstp8_clks R8A7790_CLK_VIN1>; > + reg = <0 0xe6ef1000 0 0x1000>; > + interrupts = <0 189 IRQ_TYPE_LEVEL_HIGH>; > + status = "disabled"; > + }; > + > + vin2: vin@0xe6ef2000 { > + compatible = "renesas,vin-r8a7790"; > + clocks = <&mstp8_clks R8A7790_CLK_VIN2>; > + reg = <0 0xe6ef2000 0 0x1000>; > + interrupts = <0 190 IRQ_TYPE_LEVEL_HIGH>; > + status = "disabled"; > + }; > + > + vin3: vin@0xe6ef3000 { > + compatible = "renesas,vin-r8a7790"; > + clocks = <&mstp8_clks R8A7790_CLK_VIN3>; > + reg = <0 0xe6ef3000 0 0x1000>; > + interrupts = <0 191 IRQ_TYPE_LEVEL_HIGH>; > + status = "disabled"; > + }; > + > clocks { > #address-cells = <2>; > #size-cells = <2>; > -- > 1.9.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi index a1e7c39..4c3eafb 100644 --- a/arch/arm/boot/dts/r8a7790.dtsi +++ b/arch/arm/boot/dts/r8a7790.dtsi @@ -395,6 +395,38 @@ status = "disabled"; }; + vin0: vin@0xe6ef0000 { + compatible = "renesas,vin-r8a7790"; + clocks = <&mstp8_clks R8A7790_CLK_VIN0>; + reg = <0 0xe6ef0000 0 0x1000>; + interrupts = <0 188 IRQ_TYPE_LEVEL_HIGH>; + status = "disabled"; + }; + + vin1: vin@0xe6ef1000 { + compatible = "renesas,vin-r8a7790"; + clocks = <&mstp8_clks R8A7790_CLK_VIN1>; + reg = <0 0xe6ef1000 0 0x1000>; + interrupts = <0 189 IRQ_TYPE_LEVEL_HIGH>; + status = "disabled"; + }; + + vin2: vin@0xe6ef2000 { + compatible = "renesas,vin-r8a7790"; + clocks = <&mstp8_clks R8A7790_CLK_VIN2>; + reg = <0 0xe6ef2000 0 0x1000>; + interrupts = <0 190 IRQ_TYPE_LEVEL_HIGH>; + status = "disabled"; + }; + + vin3: vin@0xe6ef3000 { + compatible = "renesas,vin-r8a7790"; + clocks = <&mstp8_clks R8A7790_CLK_VIN3>; + reg = <0 0xe6ef3000 0 0x1000>; + interrupts = <0 191 IRQ_TYPE_LEVEL_HIGH>; + status = "disabled"; + }; + clocks { #address-cells = <2>; #size-cells = <2>;
Add nodes for the four video input channels on the R8A7790. Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- arch/arm/boot/dts/r8a7790.dtsi | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+)