| Message ID | 1395257399-359545-60-git-send-email-arnd@arndb.de (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Wednesday 19 March 2014, Sergei Shtylyov wrote: > On 03/19/2014 10:29 PM, Arnd Bergmann wrote: > > > We cannot select SND_SOC_AK4642 if the I2C core layer > > is disabled. Making the select statement conditional > > ensures that we can build all configurations. > > Yes, but you also touch WM8978 selects. Is it the same as AK4642 or you > just forgot to mention that? My bad, I probably screwed up when I folded some older patches into a common one. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello. On 03/19/2014 10:29 PM, Arnd Bergmann wrote: > We cannot select SND_SOC_AK4642 if the I2C core layer > is disabled. Making the select statement conditional > ensures that we can build all configurations. Yes, but you also touch WM8978 selects. Is it the same as AK4642 or you just forgot to mention that? > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Cc: Simon Horman <horms@verge.net.au> > Cc: Magnus Damm <magnus.damm@gmail.com> > Cc: linux-sh@vger.kernel.org > --- > arch/arm/mach-shmobile/Kconfig | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig > index 5249ff0..6e3904e 100644 > --- a/arch/arm/mach-shmobile/Kconfig > +++ b/arch/arm/mach-shmobile/Kconfig > @@ -170,7 +170,7 @@ config MACH_MACKEREL > select ARCH_REQUIRE_GPIOLIB > select REGULATOR_FIXED_VOLTAGE if REGULATOR > select SMSC_PHY if SMSC911X > - select SND_SOC_AK4642 if SND_SIMPLE_CARD > + select SND_SOC_AK4642 if SND_SIMPLE_CARD && I2C=y > select USE_OF > > config MACH_ARMADILLO800EVA > @@ -179,7 +179,7 @@ config MACH_ARMADILLO800EVA > select ARCH_REQUIRE_GPIOLIB > select REGULATOR_FIXED_VOLTAGE if REGULATOR > select SMSC_PHY if SH_ETH > - select SND_SOC_WM8978 if SND_SIMPLE_CARD > + select SND_SOC_WM8978 if SND_SIMPLE_CARD && I2C=y > select USE_OF > > config MACH_ARMADILLO800EVA_REFERENCE > @@ -188,7 +188,7 @@ config MACH_ARMADILLO800EVA_REFERENCE > select ARCH_REQUIRE_GPIOLIB > select REGULATOR_FIXED_VOLTAGE if REGULATOR > select SMSC_PHY if SH_ETH > - select SND_SOC_WM8978 if SND_SIMPLE_CARD > + select SND_SOC_WM8978 if SND_SIMPLE_CARD && I2C=y > select USE_OF > ---help--- > Use reference implementation of Aramdillo800 EVA board support [...] WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig index 5249ff0..6e3904e 100644 --- a/arch/arm/mach-shmobile/Kconfig +++ b/arch/arm/mach-shmobile/Kconfig @@ -170,7 +170,7 @@ config MACH_MACKEREL select ARCH_REQUIRE_GPIOLIB select REGULATOR_FIXED_VOLTAGE if REGULATOR select SMSC_PHY if SMSC911X - select SND_SOC_AK4642 if SND_SIMPLE_CARD + select SND_SOC_AK4642 if SND_SIMPLE_CARD && I2C=y select USE_OF config MACH_ARMADILLO800EVA @@ -179,7 +179,7 @@ config MACH_ARMADILLO800EVA select ARCH_REQUIRE_GPIOLIB select REGULATOR_FIXED_VOLTAGE if REGULATOR select SMSC_PHY if SH_ETH - select SND_SOC_WM8978 if SND_SIMPLE_CARD + select SND_SOC_WM8978 if SND_SIMPLE_CARD && I2C=y select USE_OF config MACH_ARMADILLO800EVA_REFERENCE @@ -188,7 +188,7 @@ config MACH_ARMADILLO800EVA_REFERENCE select ARCH_REQUIRE_GPIOLIB select REGULATOR_FIXED_VOLTAGE if REGULATOR select SMSC_PHY if SH_ETH - select SND_SOC_WM8978 if SND_SIMPLE_CARD + select SND_SOC_WM8978 if SND_SIMPLE_CARD && I2C=y select USE_OF ---help--- Use reference implementation of Aramdillo800 EVA board support @@ -204,7 +204,7 @@ config MACH_BOCKW select REGULATOR_FIXED_VOLTAGE if REGULATOR select RENESAS_INTC_IRQPIN select SND_SOC_AK4554 if SND_SIMPLE_CARD - select SND_SOC_AK4642 if SND_SIMPLE_CARD + select SND_SOC_AK4642 if SND_SIMPLE_CARD && I2C=y select USE_OF config MACH_BOCKW_REFERENCE @@ -277,7 +277,7 @@ config MACH_KZM9G select ARCH_HAS_OPP select ARCH_REQUIRE_GPIOLIB select REGULATOR_FIXED_VOLTAGE if REGULATOR - select SND_SOC_AK4642 if SND_SIMPLE_CARD + select SND_SOC_AK4642 if SND_SIMPLE_CARD && I2C=y select USE_OF config MACH_KZM9G_REFERENCE @@ -285,7 +285,7 @@ config MACH_KZM9G_REFERENCE depends on ARCH_SH73A0 select ARCH_REQUIRE_GPIOLIB select REGULATOR_FIXED_VOLTAGE if REGULATOR - select SND_SOC_AK4642 if SND_SIMPLE_CARD + select SND_SOC_AK4642 if SND_SIMPLE_CARD && I2C=y select USE_OF ---help--- Use reference implementation of KZM-A9-GT board support
We cannot select SND_SOC_AK4642 if the I2C core layer is disabled. Making the select statement conditional ensures that we can build all configurations. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Simon Horman <horms@verge.net.au> Cc: Magnus Damm <magnus.damm@gmail.com> Cc: linux-sh@vger.kernel.org --- arch/arm/mach-shmobile/Kconfig | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)