diff mbox

ARM: shmobile: marzen: Fix address and size cells in LVDS encoder node

Message ID 1414402033-7311-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com (mailing list archive)
State Accepted
Commit 87b62a5bf00f63a33c7ecb9250d777cc70e7772d
Headers show

Commit Message

Laurent Pinchart Oct. 27, 2014, 9:27 a.m. UTC
The LVDS encoder DT node #address-cells and #size-cells properties are
misplaced. Move them to within the ports node.

Reported-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 arch/arm/boot/dts/r8a7779-marzen.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Geert Uytterhoeven Oct. 27, 2014, 11:17 a.m. UTC | #1
On Mon, Oct 27, 2014 at 10:27 AM, Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
> The LVDS encoder DT node #address-cells and #size-cells properties are
> misplaced. Move them to within the ports node.
>
> Reported-by: Simon Horman <horms@verge.net.au>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Laurent Pinchart Oct. 27, 2014, 11:28 a.m. UTC | #2
Hi Geert,

On Monday 27 October 2014 12:17:11 Geert Uytterhoeven wrote:
> On Mon, Oct 27, 2014 at 10:27 AM, Laurent Pinchart wrote:
> > The LVDS encoder DT node #address-cells and #size-cells properties are
> > misplaced. Move them to within the ports node.
> > 
> > Reported-by: Simon Horman <horms@verge.net.au>
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> 
> by: Geert Uytterhoeven <geert+renesas@glider.be>

Do you mean Acked-by ?
Geert Uytterhoeven Oct. 27, 2014, 11:30 a.m. UTC | #3
On Mon, Oct 27, 2014 at 12:28 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Monday 27 October 2014 12:17:11 Geert Uytterhoeven wrote:
>> On Mon, Oct 27, 2014 at 10:27 AM, Laurent Pinchart wrote:
>> > The LVDS encoder DT node #address-cells and #size-cells properties are
>> > misplaced. Move them to within the ports node.
>> >
>> > Reported-by: Simon Horman <horms@verge.net.au>
>> > Signed-off-by: Laurent Pinchart
>> > <laurent.pinchart+renesas@ideasonboard.com>
>>
>> by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Do you mean Acked-by ?

Yes, sorry for the bad cut-'n-paste.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman Oct. 27, 2014, 11:37 p.m. UTC | #4
On Mon, Oct 27, 2014 at 12:30:31PM +0100, Geert Uytterhoeven wrote:
> On Mon, Oct 27, 2014 at 12:28 PM, Laurent Pinchart
> <laurent.pinchart@ideasonboard.com> wrote:
> > On Monday 27 October 2014 12:17:11 Geert Uytterhoeven wrote:
> >> On Mon, Oct 27, 2014 at 10:27 AM, Laurent Pinchart wrote:
> >> > The LVDS encoder DT node #address-cells and #size-cells properties are
> >> > misplaced. Move them to within the ports node.
> >> >
> >> > Reported-by: Simon Horman <horms@verge.net.au>
> >> > Signed-off-by: Laurent Pinchart
> >> > <laurent.pinchart+renesas@ideasonboard.com>
> >>
> >> by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > Do you mean Acked-by ?
> 
> Yes, sorry for the bad cut-'n-paste.

Thanks, I have queued this up with the following changelog:

ARM: shmobile: marzen: Fix address and size cells in LVDS encoder node

The LVDS encoder DT node #address-cells and #size-cells properties are
misplaced. Move them to within the ports node.

Reported-by: Simon Horman <horms+renesas@verge.net.au>
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/r8a7779-marzen.dts b/arch/arm/boot/dts/r8a7779-marzen.dts
index 034dada2b462..e83d40e24bcd 100644
--- a/arch/arm/boot/dts/r8a7779-marzen.dts
+++ b/arch/arm/boot/dts/r8a7779-marzen.dts
@@ -105,10 +105,10 @@ 
 	lvds-encoder {
 		compatible = "thine,thc63lvdm83d";
 
-		#address-cells = <1>;
-		#size-cells = <0>;
-
 		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
 			port@0 {
 				reg = <0>;
 				lvds_enc_in: endpoint {