| Message ID | 1417538146-23350-6-git-send-email-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1f75cdac773bc9c93ad6126c01ae27bd343302b1 |
| Delegated to: | Simon Horman |
| Headers | show |
Hi Laurent, On Tue, Dec 2, 2014 at 5:35 PM, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> wrote: > There's no reason to name the only two available serial ports on the > board ttySC6 and ttySC7 (apart from confusing userspace, which we should > try to avoid). > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > arch/arm/boot/dts/r8a7791-koelsch.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts > index 990af167c551..bf58c79a6554 100644 > --- a/arch/arm/boot/dts/r8a7791-koelsch.dts > +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts > @@ -48,8 +48,8 @@ > compatible = "renesas,koelsch", "renesas,r8a7791"; > > aliases { > - serial6 = &scif0; > - serial7 = &scif1; > + serial0 = &scif0; > + serial1 = &scif1; Actually the labels on my Koelsch read "debug0" and "debug1". Do we care? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Geert, On Tuesday 02 December 2014 22:01:07 Geert Uytterhoeven wrote: > On Tue, Dec 2, 2014 at 5:35 PM, Laurent Pinchart wrote: > > There's no reason to name the only two available serial ports on the > > board ttySC6 and ttySC7 (apart from confusing userspace, which we should > > try to avoid). > > > > Signed-off-by: Laurent Pinchart > > <laurent.pinchart+renesas@ideasonboard.com> > > --- > > > > arch/arm/boot/dts/r8a7791-koelsch.dts | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts > > b/arch/arm/boot/dts/r8a7791-koelsch.dts index 990af167c551..bf58c79a6554 > > 100644 > > --- a/arch/arm/boot/dts/r8a7791-koelsch.dts > > +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts > > @@ -48,8 +48,8 @@ > > compatible = "renesas,koelsch", "renesas,r8a7791"; > > > > aliases { > > - serial6 = &scif0; > > - serial7 = &scif1; > > + serial0 = &scif0; > > + serial1 = &scif1; > > Actually the labels on my Koelsch read "debug0" and "debug1". > Do we care? I thought serial port aliases were required to be named "serial" ?
Hi Laurent, On Tue, Dec 2, 2014 at 10:06 PM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: >> > aliases { >> > - serial6 = &scif0; >> > - serial7 = &scif1; >> > + serial0 = &scif0; >> > + serial1 = &scif1; >> >> Actually the labels on my Koelsch read "debug0" and "debug1". >> Do we care? > > I thought serial port aliases were required to be named "serial" ? ePAPR v1.1 only mentions up to 31 characters out of [a-z0-9-]. Nothing about rgeneric names like with node names. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Geert, On Tuesday 02 December 2014 22:11:52 Geert Uytterhoeven wrote: > On Tue, Dec 2, 2014 at 10:06 PM, Laurent Pinchart wrote: > >> > aliases { > >> > > >> > - serial6 = &scif0; > >> > - serial7 = &scif1; > >> > + serial0 = &scif0; > >> > + serial1 = &scif1; > >> > >> Actually the labels on my Koelsch read "debug0" and "debug1". > >> Do we care? > > > > I thought serial port aliases were required to be named "serial" ? > > ePAPR v1.1 only mentions up to 31 characters out of [a-z0-9-]. > Nothing about rgeneric names like with node names. The sh-sci driver calls of_alias_get_id(np, "serial") to retrieve the port number. The alias must then start by "serial" unless I'm missing something.
Hi Laurent, On Tue, Dec 2, 2014 at 10:34 PM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > On Tuesday 02 December 2014 22:11:52 Geert Uytterhoeven wrote: >> On Tue, Dec 2, 2014 at 10:06 PM, Laurent Pinchart wrote: >> >> > aliases { >> >> > >> >> > - serial6 = &scif0; >> >> > - serial7 = &scif1; >> >> > + serial0 = &scif0; >> >> > + serial1 = &scif1; >> >> >> >> Actually the labels on my Koelsch read "debug0" and "debug1". >> >> Do we care? >> > >> > I thought serial port aliases were required to be named "serial" ? >> >> ePAPR v1.1 only mentions up to 31 characters out of [a-z0-9-]. >> Nothing about rgeneric names like with node names. > > The sh-sci driver calls of_alias_get_id(np, "serial") to retrieve the port > number. The alias must then start by "serial" unless I'm missing something. OK, then we're stuck with "serial%u" (some drivers use "uart%u" or even "ttyAS%u"!). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts index 990af167c551..bf58c79a6554 100644 --- a/arch/arm/boot/dts/r8a7791-koelsch.dts +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts @@ -48,8 +48,8 @@ compatible = "renesas,koelsch", "renesas,r8a7791"; aliases { - serial6 = &scif0; - serial7 = &scif1; + serial0 = &scif0; + serial1 = &scif1; }; chosen {
There's no reason to name the only two available serial ports on the board ttySC6 and ttySC7 (apart from confusing userspace, which we should try to avoid). Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- arch/arm/boot/dts/r8a7791-koelsch.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)