| Message ID | 1418259561-27862-1-git-send-email-horms+renesas@verge.net.au (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Simon Horman |
| Headers | show |
Hi Simon > From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com> > > Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com> > [horms: omitted device node and alias; only add clock] > Signed-off-by: Simon Horman <horms+renesas@verge.net.a, not device nodes:u> > > --- > Based on the renesas-devel-20141211-v3.18 tag of my renesas tree > > Changes by Simon Horman > * Removed portions of patch which add device node and alias > * Renamed patch from > "ARM: shmobile: r8a7794: Add QSPI clock and device to device tree" to > "ARM: shmobile: r8a7794: Add QSPI clock to device tree" > --- > arch/arm/boot/dts/r8a7794.dtsi | 8 ++++++++ > include/dt-bindings/clock/r8a7794-clock.h | 1 + > 2 files changed, 9 insertions(+) > > diff --git a/arch/arm/boot/dts/r8a7794.dtsi b/arch/arm/boot/dts/r8a7794.dtsi > index 6d95638..9f59849 100644 > --- a/arch/arm/boot/dts/r8a7794.dtsi > +++ b/arch/arm/boot/dts/r8a7794.dtsi > @@ -535,6 +535,14 @@ > clock-output-names = > "vin1", "vin0", "ether"; > }; > + mstp9_clks: mstp9_clks@e6150994 { > + compatible = "renesas,r8a7794-mstp-clocks", "renesas,cpg-mstp-clocks"; > + reg = <0 0xe6150994 0 4>, <0 0xe61509a4 0 4>; > + clocks = <&cpg_clocks R8A7794_CLK_QSPI>; > + #clock-cells = <1>; > + renesas,clock-indices = <R8A7794_CLK_QSPI_MOD>; > + clock-output-names = "qspi_mod"; > + }; We want ot use this ? - renesas,clock-indices + clock-indices -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Dec 11, 2014 at 01:26:42AM +0000, Kuninori Morimoto wrote: > > Hi Simon > > > From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com> > > > > Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com> > > [horms: omitted device node and alias; only add clock] > > Signed-off-by: Simon Horman <horms+renesas@verge.net.a, not device nodes:u> > > > > --- > > Based on the renesas-devel-20141211-v3.18 tag of my renesas tree > > > > Changes by Simon Horman > > * Removed portions of patch which add device node and alias > > * Renamed patch from > > "ARM: shmobile: r8a7794: Add QSPI clock and device to device tree" to > > "ARM: shmobile: r8a7794: Add QSPI clock to device tree" > > --- > > arch/arm/boot/dts/r8a7794.dtsi | 8 ++++++++ > > include/dt-bindings/clock/r8a7794-clock.h | 1 + > > 2 files changed, 9 insertions(+) > > > > diff --git a/arch/arm/boot/dts/r8a7794.dtsi b/arch/arm/boot/dts/r8a7794.dtsi > > index 6d95638..9f59849 100644 > > --- a/arch/arm/boot/dts/r8a7794.dtsi > > +++ b/arch/arm/boot/dts/r8a7794.dtsi > > @@ -535,6 +535,14 @@ > > clock-output-names = > > "vin1", "vin0", "ether"; > > }; > > + mstp9_clks: mstp9_clks@e6150994 { > > + compatible = "renesas,r8a7794-mstp-clocks", "renesas,cpg-mstp-clocks"; > > + reg = <0 0xe6150994 0 4>, <0 0xe61509a4 0 4>; > > + clocks = <&cpg_clocks R8A7794_CLK_QSPI>; > > + #clock-cells = <1>; > > + renesas,clock-indices = <R8A7794_CLK_QSPI_MOD>; > > + clock-output-names = "qspi_mod"; > > + }; > > We want ot use this ? > > - renesas,clock-indices > + clock-indices Thanks, and sorry for missing that. I'll fix that up. Do you have any objections to the patch if that problem is resolved? -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Simon > > > @@ -535,6 +535,14 @@ > > > clock-output-names = > > > "vin1", "vin0", "ether"; > > > }; > > > + mstp9_clks: mstp9_clks@e6150994 { > > > + compatible = "renesas,r8a7794-mstp-clocks", "renesas,cpg-mstp-clocks"; > > > + reg = <0 0xe6150994 0 4>, <0 0xe61509a4 0 4>; > > > + clocks = <&cpg_clocks R8A7794_CLK_QSPI>; > > > + #clock-cells = <1>; > > > + renesas,clock-indices = <R8A7794_CLK_QSPI_MOD>; > > > + clock-output-names = "qspi_mod"; > > > + }; > > > > We want ot use this ? > > > > - renesas,clock-indices > > + clock-indices > > Thanks, and sorry for missing that. I'll fix that up. > Do you have any objections to the patch if that problem is resolved? Thank you I have no objections. -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Dec 11, 2014 at 1:59 AM, Simon Horman <horms+renesas@verge.net.au> wrote: > From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com> > > Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com> > [horms: omitted device node and alias; only add clock] > Signed-off-by: Simon Horman <horms+renesas@verge.net.a, not device nodes:u> (After fixing renesas,clock-indices, as reported by Morimoto-san) Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Dec 11, 2014 at 09:56:20AM +0100, Geert Uytterhoeven wrote: > On Thu, Dec 11, 2014 at 1:59 AM, Simon Horman > <horms+renesas@verge.net.au> wrote: > > From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com> > > > > Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com> > > [horms: omitted device node and alias; only add clock] > > Signed-off-by: Simon Horman <horms+renesas@verge.net.a, not device nodes:u> > > (After fixing renesas,clock-indices, as reported by Morimoto-san) > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Thanks, I have queued up the revised version. -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/r8a7794.dtsi b/arch/arm/boot/dts/r8a7794.dtsi index 6d95638..9f59849 100644 --- a/arch/arm/boot/dts/r8a7794.dtsi +++ b/arch/arm/boot/dts/r8a7794.dtsi @@ -535,6 +535,14 @@ clock-output-names = "vin1", "vin0", "ether"; }; + mstp9_clks: mstp9_clks@e6150994 { + compatible = "renesas,r8a7794-mstp-clocks", "renesas,cpg-mstp-clocks"; + reg = <0 0xe6150994 0 4>, <0 0xe61509a4 0 4>; + clocks = <&cpg_clocks R8A7794_CLK_QSPI>; + #clock-cells = <1>; + renesas,clock-indices = <R8A7794_CLK_QSPI_MOD>; + clock-output-names = "qspi_mod"; + }; mstp11_clks: mstp11_clks@e615099c { compatible = "renesas,r8a7794-mstp-clocks", "renesas,cpg-mstp-clocks"; reg = <0 0xe615099c 0 4>, <0 0xe61509ac 0 4>; diff --git a/include/dt-bindings/clock/r8a7794-clock.h b/include/dt-bindings/clock/r8a7794-clock.h index c0bd14a5..fba89a4 100644 --- a/include/dt-bindings/clock/r8a7794-clock.h +++ b/include/dt-bindings/clock/r8a7794-clock.h @@ -86,6 +86,7 @@ #define R8A7794_CLK_GPIO2 10 #define R8A7794_CLK_GPIO1 11 #define R8A7794_CLK_GPIO0 12 +#define R8A7794_CLK_QSPI_MOD 17 /* MSTP11 */ #define R8A7794_CLK_SCIFA3 6