| Message ID | 1422802074-1921-3-git-send-email-wsa@the-dreams.de (mailing list archive) |
|---|---|
| State | RFC |
| Headers | show |
On Sun, Feb 1, 2015 at 3:47 PM, Wolfram Sang <wsa@the-dreams.de> wrote: > --- a/arch/arm/boot/dts/r8a7790.dtsi > +++ b/arch/arm/boot/dts/r8a7790.dtsi > @@ -123,6 +123,13 @@ > interrupts = <1 9 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>; > }; > > + wdt0: wdt@e6020000 { > + compatible = "renesas,rwdt-r8a7790", "renesas,rwdt-rcar"; > + reg = <0 0xe6020000 0 0x0c>; The RWDT hardware block also has an interrupt: interrupts = <GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&mstp4_clks R8A7790_CLK_RWDT>; > + status = "disabled"; > + }; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Feb 02, 2015 at 10:05:37AM +0100, Geert Uytterhoeven wrote: > On Sun, Feb 1, 2015 at 3:47 PM, Wolfram Sang <wsa@the-dreams.de> wrote: > > --- a/arch/arm/boot/dts/r8a7790.dtsi > > +++ b/arch/arm/boot/dts/r8a7790.dtsi > > @@ -123,6 +123,13 @@ > > interrupts = <1 9 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>; > > }; > > > > + wdt0: wdt@e6020000 { > > + compatible = "renesas,rwdt-r8a7790", "renesas,rwdt-rcar"; > > + reg = <0 0xe6020000 0 0x0c>; > > The RWDT hardware block also has an interrupt: > > interrupts = <GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>; Well, it is not used in the driver. I'd suggest to skip until it is really needed.
Hi Wolfram, On Mon, Feb 2, 2015 at 10:15 AM, Wolfram Sang <wsa@the-dreams.de> wrote: > On Mon, Feb 02, 2015 at 10:05:37AM +0100, Geert Uytterhoeven wrote: >> On Sun, Feb 1, 2015 at 3:47 PM, Wolfram Sang <wsa@the-dreams.de> wrote: >> > --- a/arch/arm/boot/dts/r8a7790.dtsi >> > +++ b/arch/arm/boot/dts/r8a7790.dtsi >> > @@ -123,6 +123,13 @@ >> > interrupts = <1 9 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>; >> > }; >> > >> > + wdt0: wdt@e6020000 { >> > + compatible = "renesas,rwdt-r8a7790", "renesas,rwdt-rcar"; >> > + reg = <0 0xe6020000 0 0x0c>; >> >> The RWDT hardware block also has an interrupt: >> >> interrupts = <GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>; > > Well, it is not used in the driver. I'd suggest to skip until it is > really needed. That doesn't matter. DT should describe the hardware.... perfectly (stable DT ABI etc.). And as it's a standard property, we don't have to think hard and invent a good way to describe the presence of the interrupt. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Feb 02, 2015 at 10:34:52AM +0100, Geert Uytterhoeven wrote: > Hi Wolfram, > > On Mon, Feb 2, 2015 at 10:15 AM, Wolfram Sang <wsa@the-dreams.de> wrote: > > On Mon, Feb 02, 2015 at 10:05:37AM +0100, Geert Uytterhoeven wrote: > >> On Sun, Feb 1, 2015 at 3:47 PM, Wolfram Sang <wsa@the-dreams.de> wrote: > >> > --- a/arch/arm/boot/dts/r8a7790.dtsi > >> > +++ b/arch/arm/boot/dts/r8a7790.dtsi > >> > @@ -123,6 +123,13 @@ > >> > interrupts = <1 9 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>; > >> > }; > >> > > >> > + wdt0: wdt@e6020000 { > >> > + compatible = "renesas,rwdt-r8a7790", "renesas,rwdt-rcar"; > >> > + reg = <0 0xe6020000 0 0x0c>; > >> > >> The RWDT hardware block also has an interrupt: > >> > >> interrupts = <GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>; > > > > Well, it is not used in the driver. I'd suggest to skip until it is > > really needed. > > That doesn't matter. DT should describe the hardware.... perfectly (stable DT > ABI etc.). And as it's a standard property, we don't have to think hard and > invent a good way to describe the presence of the interrupt. OK, will add.
Hello. On 2/1/2015 5:47 PM, Wolfram Sang wrote: > From: Wolfram Sang <wsa+renesas@sang-engineering.com> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > arch/arm/boot/dts/r8a7790.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi > index 999d437496de..1fea7cb6dcd8 100644 > --- a/arch/arm/boot/dts/r8a7790.dtsi > +++ b/arch/arm/boot/dts/r8a7790.dtsi > @@ -123,6 +123,13 @@ > interrupts = <1 9 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>; > }; > > + wdt0: wdt@e6020000 { ePAPR section 2.2.2 says to name it "watchdog@e6020000". WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> >+ wdt0: wdt@e6020000 { > > ePAPR section 2.2.2 says to name it "watchdog@e6020000". Thanks!
diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi index 999d437496de..1fea7cb6dcd8 100644 --- a/arch/arm/boot/dts/r8a7790.dtsi +++ b/arch/arm/boot/dts/r8a7790.dtsi @@ -123,6 +123,13 @@ interrupts = <1 9 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>; }; + wdt0: wdt@e6020000 { + compatible = "renesas,rwdt-r8a7790", "renesas,rwdt-rcar"; + reg = <0 0xe6020000 0 0x0c>; + clocks = <&mstp4_clks R8A7790_CLK_RWDT>; + status = "disabled"; + }; + gpio0: gpio@e6050000 { compatible = "renesas,gpio-r8a7790", "renesas,gpio-rcar"; reg = <0 0xe6050000 0 0x50>;