diff mbox

[09/11] serial: sh-sci: Add device tree bindings for r8a7793

Message ID 1425661798-10487-10-git-send-email-ulrich.hecht+renesas@gmail.com (mailing list archive)
State Deferred
Delegated to: Simon Horman
Headers show

Commit Message

Ulrich Hecht March 6, 2015, 5:09 p.m. UTC
Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
 Documentation/devicetree/bindings/serial/renesas,sci-serial.txt | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Simon Horman March 7, 2015, 12:07 a.m. UTC | #1
On Fri, Mar 06, 2015 at 06:09:56PM +0100, Ulrich Hecht wrote:
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>

Acked-by: Simon Horman <horms+renesas@verge.net.au>

> ---
>  Documentation/devicetree/bindings/serial/renesas,sci-serial.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt b/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt
> index ae73bb0..6b879b5 100644
> --- a/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt
> +++ b/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt
> @@ -19,6 +19,10 @@ Required properties:
>      - "renesas,scifa-r8a7791" for R8A7791 (R-Car M2) SCIFA compatible UART.
>      - "renesas,scifb-r8a7791" for R8A7791 (R-Car M2) SCIFB compatible UART.
>      - "renesas,hscif-r8a7791" for R8A7791 (R-Car M2) HSCIF compatible UART.

Not appropriate for this patch, but
I wonder if M2 should be updated to M2W throughout
Documentation/devicetree/bindings/

> +    - "renesas,scif-r8a7793" for R8A7793 (R-Car M2N) SCIF compatible UART.
> +    - "renesas,scifa-r8a7793" for R8A7793 (R-Car M2N) SCIFA compatible UART.
> +    - "renesas,scifb-r8a7793" for R8A7793 (R-Car M2N) SCIFB compatible UART.
> +    - "renesas,hscif-r8a7793" for R8A7793 (R-Car M2N) HSCIF compatible UART.
>      - "renesas,scif-r8a7794" for R8A7794 (R-Car E2) SCIF compatible UART.
>      - "renesas,scifa-r8a7794" for R8A7794 (R-Car E2) SCIFA compatible UART.
>      - "renesas,scifb-r8a7794" for R8A7794 (R-Car E2) SCIFB compatible UART.
> -- 
> 2.2.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Geert Uytterhoeven March 8, 2015, 10:13 a.m. UTC | #2
On Fri, Mar 6, 2015 at 6:09 PM, Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:
> --- a/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt
> +++ b/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt
> @@ -19,6 +19,10 @@ Required properties:
>      - "renesas,scifa-r8a7791" for R8A7791 (R-Car M2) SCIFA compatible UART.
>      - "renesas,scifb-r8a7791" for R8A7791 (R-Car M2) SCIFB compatible UART.
>      - "renesas,hscif-r8a7791" for R8A7791 (R-Car M2) HSCIF compatible UART.

Please rename the "M2" entries to "M2-W".

> +    - "renesas,scif-r8a7793" for R8A7793 (R-Car M2N) SCIF compatible UART.
> +    - "renesas,scifa-r8a7793" for R8A7793 (R-Car M2N) SCIFA compatible UART.
> +    - "renesas,scifb-r8a7793" for R8A7793 (R-Car M2N) SCIFB compatible UART.
> +    - "renesas,hscif-r8a7793" for R8A7793 (R-Car M2N) HSCIF compatible UART.

"M2-N"

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Geert Uytterhoeven March 8, 2015, 10:15 a.m. UTC | #3
On Sat, Mar 7, 2015 at 1:07 AM, Simon Horman <horms@verge.net.au> wrote:
>> --- a/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt
>> +++ b/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt
>> @@ -19,6 +19,10 @@ Required properties:
>>      - "renesas,scifa-r8a7791" for R8A7791 (R-Car M2) SCIFA compatible UART.
>>      - "renesas,scifb-r8a7791" for R8A7791 (R-Car M2) SCIFB compatible UART.
>>      - "renesas,hscif-r8a7791" for R8A7791 (R-Car M2) HSCIF compatible UART.
>
> Not appropriate for this patch, but
> I wonder if M2 should be updated to M2W throughout
> Documentation/devicetree/bindings/

For e.g. rspi I did it in the patch that introduced "M2-N" support
(cfr. commit 6089af775a4b4ea5 ("spi: rspi: Add support for new R-Car Gen2
SoCs").

No preference, may depend on your love for statistics
(http://www.remword.com/kps_result/ ;-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman March 8, 2015, 11:48 p.m. UTC | #4
On Sun, Mar 08, 2015 at 11:15:47AM +0100, Geert Uytterhoeven wrote:
> On Sat, Mar 7, 2015 at 1:07 AM, Simon Horman <horms@verge.net.au> wrote:
> >> --- a/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt
> >> +++ b/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt
> >> @@ -19,6 +19,10 @@ Required properties:
> >>      - "renesas,scifa-r8a7791" for R8A7791 (R-Car M2) SCIFA compatible UART.
> >>      - "renesas,scifb-r8a7791" for R8A7791 (R-Car M2) SCIFB compatible UART.
> >>      - "renesas,hscif-r8a7791" for R8A7791 (R-Car M2) HSCIF compatible UART.
> >
> > Not appropriate for this patch, but
> > I wonder if M2 should be updated to M2W throughout
> > Documentation/devicetree/bindings/
> 
> For e.g. rspi I did it in the patch that introduced "M2-N" support
> (cfr. commit 6089af775a4b4ea5 ("spi: rspi: Add support for new R-Car Gen2
> SoCs").
> 
> No preference, may depend on your love for statistics
> (http://www.remword.com/kps_result/ ;-)

I also have no preference in this case.
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt b/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt
index ae73bb0..6b879b5 100644
--- a/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt
+++ b/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt
@@ -19,6 +19,10 @@  Required properties:
     - "renesas,scifa-r8a7791" for R8A7791 (R-Car M2) SCIFA compatible UART.
     - "renesas,scifb-r8a7791" for R8A7791 (R-Car M2) SCIFB compatible UART.
     - "renesas,hscif-r8a7791" for R8A7791 (R-Car M2) HSCIF compatible UART.
+    - "renesas,scif-r8a7793" for R8A7793 (R-Car M2N) SCIF compatible UART.
+    - "renesas,scifa-r8a7793" for R8A7793 (R-Car M2N) SCIFA compatible UART.
+    - "renesas,scifb-r8a7793" for R8A7793 (R-Car M2N) SCIFB compatible UART.
+    - "renesas,hscif-r8a7793" for R8A7793 (R-Car M2N) HSCIF compatible UART.
     - "renesas,scif-r8a7794" for R8A7794 (R-Car E2) SCIF compatible UART.
     - "renesas,scifa-r8a7794" for R8A7794 (R-Car E2) SCIFA compatible UART.
     - "renesas,scifb-r8a7794" for R8A7794 (R-Car E2) SCIFB compatible UART.