| Message ID | 1425985583-26279-4-git-send-email-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Superseded |
| Commit | 17c7cbb0e7b7a877f1ce2063d7f869801b24cd6a |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
Hi Geert, Thank you for the patch. On Tuesday 10 March 2015 12:06:22 Geert Uytterhoeven wrote: > All other loops over sh_pfc_soc_info.data_regs[] use > pinmux_data_reg.regwidth as the sentinel, which is safer as zero is > never a valid regwidth value (reg could be zero if we start using it to > store an offset). > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > v2: > - New. > --- > drivers/pinctrl/sh-pfc/gpio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/sh-pfc/gpio.c b/drivers/pinctrl/sh-pfc/gpio.c > index aa2fc77a1925e839..5d3a35ce09125a45 100644 > --- a/drivers/pinctrl/sh-pfc/gpio.c > +++ b/drivers/pinctrl/sh-pfc/gpio.c > @@ -84,7 +84,7 @@ static void gpio_setup_data_reg(struct sh_pfc_chip *chip, > unsigned idx) unsigned int bit; > unsigned int i; > > - for (i = 0, dreg = pfc->info->data_regs; dreg->reg; ++i, ++dreg) { > + for (i = 0, dreg = pfc->info->data_regs; dreg->reg_width; ++i, ++dreg) { > for (bit = 0; bit < dreg->reg_width; bit++) { > if (dreg->enum_ids[bit] == pin->enum_id) { > gpio_pin->dreg = i;
diff --git a/drivers/pinctrl/sh-pfc/gpio.c b/drivers/pinctrl/sh-pfc/gpio.c index aa2fc77a1925e839..5d3a35ce09125a45 100644 --- a/drivers/pinctrl/sh-pfc/gpio.c +++ b/drivers/pinctrl/sh-pfc/gpio.c @@ -84,7 +84,7 @@ static void gpio_setup_data_reg(struct sh_pfc_chip *chip, unsigned idx) unsigned int bit; unsigned int i; - for (i = 0, dreg = pfc->info->data_regs; dreg->reg; ++i, ++dreg) { + for (i = 0, dreg = pfc->info->data_regs; dreg->reg_width; ++i, ++dreg) { for (bit = 0; bit < dreg->reg_width; bit++) { if (dreg->enum_ids[bit] == pin->enum_id) { gpio_pin->dreg = i;
All other loops over sh_pfc_soc_info.data_regs[] use pinmux_data_reg.regwidth as the sentinel, which is safer as zero is never a valid regwidth value (reg could be zero if we start using it to store an offset). Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- v2: - New. --- drivers/pinctrl/sh-pfc/gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)