From patchwork Sun Mar 15 14:33:38 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yoshihiro Kaneko X-Patchwork-Id: 6013131 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id F2D4F9F318 for ; Sun, 15 Mar 2015 14:33:53 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 25BEF2024C for ; Sun, 15 Mar 2015 14:33:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 42BC92022A for ; Sun, 15 Mar 2015 14:33:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752579AbbCOOdv (ORCPT ); Sun, 15 Mar 2015 10:33:51 -0400 Received: from mail-pd0-f178.google.com ([209.85.192.178]:34451 "EHLO mail-pd0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752232AbbCOOdv (ORCPT ); Sun, 15 Mar 2015 10:33:51 -0400 Received: by pdbni2 with SMTP id ni2so32665615pdb.1; Sun, 15 Mar 2015 07:33:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=EyaugAudmDys5K4BYo1aioz3r6IxcSiOT6akhDnPzxY=; b=yYDOBzoHEamxApBiNXpbtSFPyK5TzcNMZP++1eNSiT9vN2L2LzI6l0RAUPM5XgUe1Q fVk4PBPxMx1JgWPUWyukrIq7Szi/QL5Tok7f9JJDAAPzjTmvbMGHfzX9D/bWNlnavLnU R3EW3JUA+eHmxzjBt/hToie9tp8/VNnGSlJ8Z9/0d/tJbSkeVMUpo8gVRgr6OpPkSw6p 2gnnddD0It50FbKfq+0AD3FWFSeg3cS8xD2rZ0TztCr2E/0W5ZPsY9M/GCEGJ32ZNVTQ RNdkESGgwta+kARMSMsSt56+1KlREOJo/RVeq5129IasYiw2Q5dnxzfGcG4gxmIenbnM k+fQ== X-Received: by 10.70.54.198 with SMTP id l6mr127447537pdp.74.1426430030574; Sun, 15 Mar 2015 07:33:50 -0700 (PDT) Received: from localhost.localdomain (KD118152108246.ppp-bb.dion.ne.jp. [118.152.108.246]) by mx.google.com with ESMTPSA id 1sm12683464pdi.38.2015.03.15.07.33.48 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 15 Mar 2015 07:33:50 -0700 (PDT) From: Yoshihiro Kaneko To: linux-media@vger.kernel.org Cc: Mauro Carvalho Chehab , Laurent Pinchart , Simon Horman , Magnus Damm , linux-sh@vger.kernel.org Subject: [PATCH/RFC] v4l: vsp1: Change VSP1 LIF linebuffer FIFO Date: Sun, 15 Mar 2015 23:33:38 +0900 Message-Id: <1426430018-3172-1-git-send-email-ykaneko0929@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Yoshifumi Hosoya Change to VSPD hardware recommended value. Purpose is highest pixel clock without underruns. In the default R-Car Linux BSP config this value is wrong and therefore there are many underruns. Here are the original settings: HBTH = 1300 (VSPD stops when 1300 pixels are buffered) LBTH = 200 (VSPD resumes when buffer level has decreased below 200 pixels) The display underruns can be eliminated by applying the following settings: HBTH = 1504 LBTH = 1248 Reported-by: Peter Fiedler Signed-off-by: Yoshifumi Hosoya Signed-off-by: Yoshihiro Kaneko --- This patch is based on the master branch of linuxtv.org/media_tree.git. drivers/media/platform/vsp1/vsp1_lif.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/vsp1/vsp1_lif.c b/drivers/media/platform/vsp1/vsp1_lif.c index 17a6ca7..7d0f7eb 100644 --- a/drivers/media/platform/vsp1/vsp1_lif.c +++ b/drivers/media/platform/vsp1/vsp1_lif.c @@ -1,7 +1,7 @@ /* * vsp1_lif.c -- R-Car VSP1 LCD Controller Interface * - * Copyright (C) 2013-2014 Renesas Electronics Corporation + * Copyright (C) 2013-2015 Renesas Electronics Corporation * * Contact: Laurent Pinchart (laurent.pinchart@ideasonboard.com) * @@ -44,9 +44,9 @@ static int lif_s_stream(struct v4l2_subdev *subdev, int enable) { const struct v4l2_mbus_framefmt *format; struct vsp1_lif *lif = to_lif(subdev); - unsigned int hbth = 1300; - unsigned int obth = 400; - unsigned int lbth = 200; + unsigned int hbth = 1536; + unsigned int obth = 128; + unsigned int lbth = 1520; if (!enable) { vsp1_lif_write(lif, VI6_LIF_CTRL, 0);