diff mbox

[PATCH/RFC] ARM: shmobile: r8a7791: Remove MSIOF address from device tree

Message ID 1426430633-3867-1-git-send-email-ykaneko0929@gmail.com (mailing list archive)
State Superseded
Delegated to: Simon Horman
Headers show

Commit Message

Yoshihiro Kaneko March 15, 2015, 2:43 p.m. UTC 
From: Ryo Kataoka <ryo.kataoka.wt@renesas.com>

MSIOF Base Address H'E6xx can be accessed by CPU and DMAC.
MSIOF Base Address H'E7xx for DMAC was removed from H/W manual.

Signed-off-by: Ryo Kataoka <ryo.kataoka.wt@renesas.com>
Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
---

This patch is based on devel branch of Simon Horman's renesas tree.

 arch/arm/boot/dts/r8a7791.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Yoshihiro Kaneko March 29, 2015, 1:22 p.m. UTC | #1 
Hi Geert-san,

I'm wondering if you could find a moment to look over this patch.

Regards,
Kaneko

2015-03-15 23:43 GMT+09:00 Yoshihiro Kaneko <ykaneko0929@gmail.com>:
> From: Ryo Kataoka <ryo.kataoka.wt@renesas.com>
>
> MSIOF Base Address H'E6xx can be accessed by CPU and DMAC.
> MSIOF Base Address H'E7xx for DMAC was removed from H/W manual.
>
> Signed-off-by: Ryo Kataoka <ryo.kataoka.wt@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> ---
>
> This patch is based on devel branch of Simon Horman's renesas tree.
>
>  arch/arm/boot/dts/r8a7791.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi
> index 4696062..3e9f824 100644
> --- a/arch/arm/boot/dts/r8a7791.dtsi
> +++ b/arch/arm/boot/dts/r8a7791.dtsi
> @@ -1288,7 +1288,7 @@
>
>         msiof0: spi@e6e20000 {
>                 compatible = "renesas,msiof-r8a7791";
> -               reg = <0 0xe6e20000 0 0x0064>, <0 0xe7e20000 0 0x0064>;
> +               reg = <0 0xe6e20000 0 0x0064>;
>                 interrupts = <0 156 IRQ_TYPE_LEVEL_HIGH>;
>                 clocks = <&mstp0_clks R8A7791_CLK_MSIOF0>;
>                 dmas = <&dmac0 0x51>, <&dmac0 0x52>;
> @@ -1300,7 +1300,7 @@
>
>         msiof1: spi@e6e10000 {
>                 compatible = "renesas,msiof-r8a7791";
> -               reg = <0 0xe6e10000 0 0x0064>, <0 0xe7e10000 0 0x0064>;
> +               reg = <0 0xe6e10000 0 0x0064>;
>                 interrupts = <0 157 IRQ_TYPE_LEVEL_HIGH>;
>                 clocks = <&mstp2_clks R8A7791_CLK_MSIOF1>;
>                 dmas = <&dmac0 0x55>, <&dmac0 0x56>;
> @@ -1312,7 +1312,7 @@
>
>         msiof2: spi@e6e00000 {
>                 compatible = "renesas,msiof-r8a7791";
> -               reg = <0 0xe6e00000 0 0x0064>, <0 0xe7e00000 0 0x0064>;
> +               reg = <0 0xe6e00000 0 0x0064>;
>                 interrupts = <0 158 IRQ_TYPE_LEVEL_HIGH>;
>                 clocks = <&mstp2_clks R8A7791_CLK_MSIOF2>;
>                 dmas = <&dmac0 0x41>, <&dmac0 0x42>;
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Geert Uytterhoeven March 30, 2015, 9:23 a.m. UTC | #2 
Hi Kaneko-san,

On Sun, Mar 29, 2015 at 3:22 PM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote:
> I'm wondering if you could find a moment to look over this patch.

In light of the discussion thread w.r.t. to the driver changes (I
don't recall you
replying, did I miss that?), I think the DTS changes for r8a779[01] are fine.
However, please also update the example (for r8a7791) in
Documentation/devicetree/bindings/spi/sh-msiof.txt.

Thanks!

> 2015-03-15 23:43 GMT+09:00 Yoshihiro Kaneko <ykaneko0929@gmail.com>:
>> From: Ryo Kataoka <ryo.kataoka.wt@renesas.com>
>>
>> MSIOF Base Address H'E6xx can be accessed by CPU and DMAC.
>> MSIOF Base Address H'E7xx for DMAC was removed from H/W manual.
>>
>> Signed-off-by: Ryo Kataoka <ryo.kataoka.wt@renesas.com>
>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
>> ---
>>
>> This patch is based on devel branch of Simon Horman's renesas tree.
>>
>>  arch/arm/boot/dts/r8a7791.dtsi | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi
>> index 4696062..3e9f824 100644
>> --- a/arch/arm/boot/dts/r8a7791.dtsi
>> +++ b/arch/arm/boot/dts/r8a7791.dtsi
>> @@ -1288,7 +1288,7 @@
>>
>>         msiof0: spi@e6e20000 {
>>                 compatible = "renesas,msiof-r8a7791";
>> -               reg = <0 0xe6e20000 0 0x0064>, <0 0xe7e20000 0 0x0064>;
>> +               reg = <0 0xe6e20000 0 0x0064>;
>>                 interrupts = <0 156 IRQ_TYPE_LEVEL_HIGH>;
>>                 clocks = <&mstp0_clks R8A7791_CLK_MSIOF0>;
>>                 dmas = <&dmac0 0x51>, <&dmac0 0x52>;

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Yoshihiro Kaneko April 2, 2015, 4:35 p.m. UTC | #3 
Hi Geert-san,

Thanks for your reply.

It seems that you and Simon concluded that the driver change wasn't
necessary. As I don't have access to the relevant documentation I'm happy
to defer to you two on that matter.

With that in mind I'll refresh this patch as you request.

I'm assuming that the r8a7790 version of this patch is fine as-is.
I'll re-post that one unchanged other than dropping the RFC tag.

Thanks,
Kaneko

2015-03-30 18:23 GMT+09:00 Geert Uytterhoeven <geert@linux-m68k.org>:
> Hi Kaneko-san,
>
> On Sun, Mar 29, 2015 at 3:22 PM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote:
>> I'm wondering if you could find a moment to look over this patch.
>
> In light of the discussion thread w.r.t. to the driver changes (I
> don't recall you
> replying, did I miss that?), I think the DTS changes for r8a779[01] are fine.
> However, please also update the example (for r8a7791) in
> Documentation/devicetree/bindings/spi/sh-msiof.txt.
>
> Thanks!
>
>> 2015-03-15 23:43 GMT+09:00 Yoshihiro Kaneko <ykaneko0929@gmail.com>:
>>> From: Ryo Kataoka <ryo.kataoka.wt@renesas.com>
>>>
>>> MSIOF Base Address H'E6xx can be accessed by CPU and DMAC.
>>> MSIOF Base Address H'E7xx for DMAC was removed from H/W manual.
>>>
>>> Signed-off-by: Ryo Kataoka <ryo.kataoka.wt@renesas.com>
>>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
>>> ---
>>>
>>> This patch is based on devel branch of Simon Horman's renesas tree.
>>>
>>>  arch/arm/boot/dts/r8a7791.dtsi | 6 +++---
>>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi
>>> index 4696062..3e9f824 100644
>>> --- a/arch/arm/boot/dts/r8a7791.dtsi
>>> +++ b/arch/arm/boot/dts/r8a7791.dtsi
>>> @@ -1288,7 +1288,7 @@
>>>
>>>         msiof0: spi@e6e20000 {
>>>                 compatible = "renesas,msiof-r8a7791";
>>> -               reg = <0 0xe6e20000 0 0x0064>, <0 0xe7e20000 0 0x0064>;
>>> +               reg = <0 0xe6e20000 0 0x0064>;
>>>                 interrupts = <0 156 IRQ_TYPE_LEVEL_HIGH>;
>>>                 clocks = <&mstp0_clks R8A7791_CLK_MSIOF0>;
>>>                 dmas = <&dmac0 0x51>, <&dmac0 0x52>;
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman April 6, 2015, 12:48 a.m. UTC | #4 
Hi Kaneko-san,

On Fri, Apr 03, 2015 at 01:35:23AM +0900, Yoshihiro Kaneko wrote:
> Hi Geert-san,
> 
> Thanks for your reply.
> 
> It seems that you and Simon concluded that the driver change wasn't
> necessary. As I don't have access to the relevant documentation I'm happy
> to defer to you two on that matter.
> 
> With that in mind I'll refresh this patch as you request.
> 
> I'm assuming that the r8a7790 version of this patch is fine as-is.
> I'll re-post that one unchanged other than dropping the RFC tag.

Thanks for your attention to this matter. As noted elsewhere I have
queued up your reposted/updated DT patches. And I believe we should
not pursue the driver patch any further at this time. So for now I think
this case is closed.
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi
index 4696062..3e9f824 100644
--- a/arch/arm/boot/dts/r8a7791.dtsi
+++ b/arch/arm/boot/dts/r8a7791.dtsi
@@ -1288,7 +1288,7 @@ 
 
 	msiof0: spi@e6e20000 {
 		compatible = "renesas,msiof-r8a7791";
-		reg = <0 0xe6e20000 0 0x0064>, <0 0xe7e20000 0 0x0064>;
+		reg = <0 0xe6e20000 0 0x0064>;
 		interrupts = <0 156 IRQ_TYPE_LEVEL_HIGH>;
 		clocks = <&mstp0_clks R8A7791_CLK_MSIOF0>;
 		dmas = <&dmac0 0x51>, <&dmac0 0x52>;
@@ -1300,7 +1300,7 @@ 
 
 	msiof1: spi@e6e10000 {
 		compatible = "renesas,msiof-r8a7791";
-		reg = <0 0xe6e10000 0 0x0064>, <0 0xe7e10000 0 0x0064>;
+		reg = <0 0xe6e10000 0 0x0064>;
 		interrupts = <0 157 IRQ_TYPE_LEVEL_HIGH>;
 		clocks = <&mstp2_clks R8A7791_CLK_MSIOF1>;
 		dmas = <&dmac0 0x55>, <&dmac0 0x56>;
@@ -1312,7 +1312,7 @@ 
 
 	msiof2: spi@e6e00000 {
 		compatible = "renesas,msiof-r8a7791";
-		reg = <0 0xe6e00000 0 0x0064>, <0 0xe7e00000 0 0x0064>;
+		reg = <0 0xe6e00000 0 0x0064>;
 		interrupts = <0 158 IRQ_TYPE_LEVEL_HIGH>;
 		clocks = <&mstp2_clks R8A7791_CLK_MSIOF2>;
 		dmas = <&dmac0 0x41>, <&dmac0 0x42>;