diff mbox

[10/10] ARM: shmobile: marzen dts: Use generic names for device nodes

Message ID 1430139334-15272-11-git-send-email-geert+renesas@glider.be (mailing list archive)
State Accepted
Commit f92d9dc7e6cd15dcd096dc5a4d3e1fe0a034f659
Headers show

Commit Message

Geert Uytterhoeven April 27, 2015, 12:55 p.m. UTC
lan0 -> ethernet

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/boot/dts/r8a7779-marzen.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Sergei Shtylyov April 27, 2015, 1:06 p.m. UTC | #1
On 04/27/2015 03:55 PM, Geert Uytterhoeven wrote:

> lan0 -> ethernet

> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>   arch/arm/boot/dts/r8a7779-marzen.dts | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)

> diff --git a/arch/arm/boot/dts/r8a7779-marzen.dts b/arch/arm/boot/dts/r8a7779-marzen.dts
> index 540756cdf3914a2a..20afea6f06ef6735 100644
> --- a/arch/arm/boot/dts/r8a7779-marzen.dts
> +++ b/arch/arm/boot/dts/r8a7779-marzen.dts
[...]
> @@ -176,7 +176,7 @@
>   		};
>   	};
>
> -	lan0_pins: lan0 {
> +	ethernet_pins: ethernet {

    Why change the label?

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Geert Uytterhoeven April 27, 2015, 1:53 p.m. UTC | #2
On Mon, Apr 27, 2015 at 3:06 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
>> -       lan0_pins: lan0 {
>> +       ethernet_pins: ethernet {
>
>
>    Why change the label?

If there's only one instance, we usually name the pins like the device node.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/r8a7779-marzen.dts b/arch/arm/boot/dts/r8a7779-marzen.dts
index 540756cdf3914a2a..20afea6f06ef6735 100644
--- a/arch/arm/boot/dts/r8a7779-marzen.dts
+++ b/arch/arm/boot/dts/r8a7779-marzen.dts
@@ -42,10 +42,10 @@ 
 		regulator-always-on;
 	};
 
-	lan0@18000000 {
+	ethernet@18000000 {
 		compatible = "smsc,lan9220", "smsc,lan9115";
 		reg = <0x18000000 0x100>;
-		pinctrl-0 = <&lan0_pins>;
+		pinctrl-0 = <&ethernet_pins>;
 		pinctrl-names = "default";
 
 		phy-mode = "mii";
@@ -176,7 +176,7 @@ 
 		};
 	};
 
-	lan0_pins: lan0 {
+	ethernet_pins: ethernet {
 		intc {
 			renesas,groups = "intc_irq1_b";
 			renesas,function = "intc";