diff mbox

[08/10] ARM: shmobile: armadillo800eva dts: Use generic names for device nodes

Message ID 1430139334-15272-9-git-send-email-geert+renesas@glider.be (mailing list archive)
State Accepted
Commit 92d2434d8effe6160eb7f4fd0d01ef5b76930f2a
Delegated to: Simon Horman
Headers show

Commit Message

Geert Uytterhoeven April 27, 2015, 12:55 p.m. UTC
wm8978 -> codec

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sergei Shtylyov April 27, 2015, 1:05 p.m. UTC | #1
Hello.

On 04/27/2015 03:55 PM, Geert Uytterhoeven wrote:

> wm8978 -> codec

> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>   arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
> index 9bd0cb439f448d03..2e31d8c01cbf6a74 100644
> --- a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
> +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
> @@ -208,7 +208,7 @@
>   		gpios = <&pfc 166 GPIO_ACTIVE_LOW>;
>   	};
>
> -	wm8978: wm8978@1a {
> +	wm8978: codec@1a {

     Perhaps sound-codec?

[...]

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Geert Uytterhoeven April 28, 2015, 8:52 a.m. UTC | #2
On Mon, Apr 27, 2015 at 3:05 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
>> -       wm8978: wm8978@1a {
>> +       wm8978: codec@1a {
>
>     Perhaps sound-codec?

Given there's no single instance of "sound-codec" under
Documentation/devicetree/, and only four occurrences in DTS files (whoops,
I should fix up 3 of them ;-):

    arch/arm/boot/dts/r8a7778-bockw.dts: ak4643: sound-codec@12 {
    arch/arm/boot/dts/r8a7790-lager.dts: ak4643: sound-codec@12 {
    arch/arm/boot/dts/r8a7791-koelsch.dts: ak4643: sound-codec@12 {
    arch/xtensa/boot/dts/xtfpga.dtsi: tlv320aic23: sound-codec@0 {

I'm strongly leaning towards "codec".

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman April 30, 2015, 12:12 a.m. UTC | #3
On Tue, Apr 28, 2015 at 10:52:37AM +0200, Geert Uytterhoeven wrote:
> On Mon, Apr 27, 2015 at 3:05 PM, Sergei Shtylyov
> <sergei.shtylyov@cogentembedded.com> wrote:
> >> -       wm8978: wm8978@1a {
> >> +       wm8978: codec@1a {
> >
> >     Perhaps sound-codec?
> 
> Given there's no single instance of "sound-codec" under
> Documentation/devicetree/, and only four occurrences in DTS files (whoops,
> I should fix up 3 of them ;-):

:)

I'm happy to help with that if you are dunning short of cycles.

>     arch/arm/boot/dts/r8a7778-bockw.dts: ak4643: sound-codec@12 {
>     arch/arm/boot/dts/r8a7790-lager.dts: ak4643: sound-codec@12 {
>     arch/arm/boot/dts/r8a7791-koelsch.dts: ak4643: sound-codec@12 {
>     arch/xtensa/boot/dts/xtfpga.dtsi: tlv320aic23: sound-codec@0 {
> 
> I'm strongly leaning towards "codec".

On the strength of that I have queued this up.
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman April 30, 2015, 12:13 a.m. UTC | #4
On Thu, Apr 30, 2015 at 09:12:55AM +0900, Simon Horman wrote:
> On Tue, Apr 28, 2015 at 10:52:37AM +0200, Geert Uytterhoeven wrote:
> > On Mon, Apr 27, 2015 at 3:05 PM, Sergei Shtylyov
> > <sergei.shtylyov@cogentembedded.com> wrote:
> > >> -       wm8978: wm8978@1a {
> > >> +       wm8978: codec@1a {
> > >
> > >     Perhaps sound-codec?
> > 
> > Given there's no single instance of "sound-codec" under
> > Documentation/devicetree/, and only four occurrences in DTS files (whoops,
> > I should fix up 3 of them ;-):
> 
> :)
> 
> I'm happy to help with that if you are dunning short of cycles.

I see you have already sent patches, thanks.

> >     arch/arm/boot/dts/r8a7778-bockw.dts: ak4643: sound-codec@12 {
> >     arch/arm/boot/dts/r8a7790-lager.dts: ak4643: sound-codec@12 {
> >     arch/arm/boot/dts/r8a7791-koelsch.dts: ak4643: sound-codec@12 {
> >     arch/xtensa/boot/dts/xtfpga.dtsi: tlv320aic23: sound-codec@0 {
> > 
> > I'm strongly leaning towards "codec".
> 
> On the strength of that I have queued this up.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
index 9bd0cb439f448d03..2e31d8c01cbf6a74 100644
--- a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
+++ b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
@@ -208,7 +208,7 @@ 
 		gpios = <&pfc 166 GPIO_ACTIVE_LOW>;
 	};
 
-	wm8978: wm8978@1a {
+	wm8978: codec@1a {
 		#sound-dai-cells = <0>;
 		compatible = "wlf,wm8978";
 		reg = <0x1a>;