| Message ID | 1430315743-8521-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 12392f5896c9affc03c1ddd95a83c32238862a58 |
| Delegated to: | Simon Horman |
| Headers | show |
Hi Laurent, On Wed, Apr 29, 2015 at 04:55:43PM +0300, Laurent Pinchart wrote: > The adv7511 IRQ is low level triggered, not falling edge triggered. The > wrong sense configuration results in no interrupt being triggered at > all, breaking hotplug detection. Fix it. Would I be correct in adding the following and queuing it up as a fix for v4.1 and v4.0-stable? Fixes: 83a0731b39f3 ("ARM: shmobile: koelsch: Add DU HDMI output support") > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > arch/arm/boot/dts/r8a7791-koelsch.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts > index 74c3212f1f11..824ddab9c3ad 100644 > --- a/arch/arm/boot/dts/r8a7791-koelsch.dts > +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts > @@ -545,7 +545,7 @@ > compatible = "adi,adv7511w"; > reg = <0x39>; > interrupt-parent = <&gpio3>; > - interrupts = <29 IRQ_TYPE_EDGE_FALLING>; > + interrupts = <29 IRQ_TYPE_LEVEL_LOW>; > > adi,input-depth = <8>; > adi,input-colorspace = "rgb"; > -- > Regards, > > Laurent Pinchart > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Simon, On Thursday 30 April 2015 13:56:40 Simon Horman wrote: > Hi Laurent, > > On Wed, Apr 29, 2015 at 04:55:43PM +0300, Laurent Pinchart wrote: > > The adv7511 IRQ is low level triggered, not falling edge triggered. The > > wrong sense configuration results in no interrupt being triggered at > > all, breaking hotplug detection. Fix it. > > Would I be correct in adding the following and queuing it up > as a fix for v4.1 and v4.0-stable? > > Fixes: 83a0731b39f3 ("ARM: shmobile: koelsch: Add DU HDMI output support") I think that would be fine. It's not a regression fix in the traditional sense, but it fixes a shortcoming of the original commit. > > Signed-off-by: Laurent Pinchart > > <laurent.pinchart+renesas@ideasonboard.com> > > --- > > > > arch/arm/boot/dts/r8a7791-koelsch.dts | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts > > b/arch/arm/boot/dts/r8a7791-koelsch.dts index 74c3212f1f11..824ddab9c3ad > > 100644 > > --- a/arch/arm/boot/dts/r8a7791-koelsch.dts > > +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts > > @@ -545,7 +545,7 @@ > > compatible = "adi,adv7511w"; > > reg = <0x39>; > > interrupt-parent = <&gpio3>; > > - interrupts = <29 IRQ_TYPE_EDGE_FALLING>; > > + interrupts = <29 IRQ_TYPE_LEVEL_LOW>; > > > > adi,input-depth = <8>; > > adi,input-colorspace = "rgb";
Hi Laurent, On Thu, Apr 30, 2015 at 10:30:48AM +0300, Laurent Pinchart wrote: > Hi Simon, > > On Thursday 30 April 2015 13:56:40 Simon Horman wrote: > > Hi Laurent, > > > > On Wed, Apr 29, 2015 at 04:55:43PM +0300, Laurent Pinchart wrote: > > > The adv7511 IRQ is low level triggered, not falling edge triggered. The > > > wrong sense configuration results in no interrupt being triggered at > > > all, breaking hotplug detection. Fix it. > > > > Would I be correct in adding the following and queuing it up > > as a fix for v4.1 and v4.0-stable? > > > > Fixes: 83a0731b39f3 ("ARM: shmobile: koelsch: Add DU HDMI output support") > > I think that would be fine. It's not a regression fix in the traditional > sense, but it fixes a shortcoming of the original commit. Thanks, got it. > > > Signed-off-by: Laurent Pinchart > > > <laurent.pinchart+renesas@ideasonboard.com> > > > --- > > > > > > arch/arm/boot/dts/r8a7791-koelsch.dts | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts > > > b/arch/arm/boot/dts/r8a7791-koelsch.dts index 74c3212f1f11..824ddab9c3ad > > > 100644 > > > --- a/arch/arm/boot/dts/r8a7791-koelsch.dts > > > +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts > > > @@ -545,7 +545,7 @@ > > > compatible = "adi,adv7511w"; > > > reg = <0x39>; > > > interrupt-parent = <&gpio3>; > > > - interrupts = <29 IRQ_TYPE_EDGE_FALLING>; > > > + interrupts = <29 IRQ_TYPE_LEVEL_LOW>; > > > > > > adi,input-depth = <8>; > > > adi,input-colorspace = "rgb"; > > -- > Regards, > > Laurent Pinchart > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 2015-04-29 at 16:55 +0300, Laurent Pinchart wrote: > The adv7511 IRQ is low level triggered, not falling edge triggered. The > wrong sense configuration results in no interrupt being triggered at > all, breaking hotplug detection. Fix it. The Lager DT has the same bug; will you send a fix for that or should I? Ben. > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > arch/arm/boot/dts/r8a7791-koelsch.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts > index 74c3212f1f11..824ddab9c3ad 100644 > --- a/arch/arm/boot/dts/r8a7791-koelsch.dts > +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts > @@ -545,7 +545,7 @@ > compatible = "adi,adv7511w"; > reg = <0x39>; > interrupt-parent = <&gpio3>; > - interrupts = <29 IRQ_TYPE_EDGE_FALLING>; > + interrupts = <29 IRQ_TYPE_LEVEL_LOW>; > > adi,input-depth = <8>; > adi,input-colorspace = "rgb"; -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Ben, On Tuesday 05 May 2015 22:17:56 Ben Hutchings wrote: > On Wed, 2015-04-29 at 16:55 +0300, Laurent Pinchart wrote: > > The adv7511 IRQ is low level triggered, not falling edge triggered. The > > wrong sense configuration results in no interrupt being triggered at > > all, breaking hotplug detection. Fix it. > > The Lager DT has the same bug; will you send a fix for that or should I? I've sent it and CC'ed you. > > Signed-off-by: Laurent Pinchart > > <laurent.pinchart+renesas@ideasonboard.com> > > --- > > > > arch/arm/boot/dts/r8a7791-koelsch.dts | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts > > b/arch/arm/boot/dts/r8a7791-koelsch.dts index 74c3212f1f11..824ddab9c3ad > > 100644 > > --- a/arch/arm/boot/dts/r8a7791-koelsch.dts > > +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts > > @@ -545,7 +545,7 @@ > > compatible = "adi,adv7511w"; > > reg = <0x39>; > > interrupt-parent = <&gpio3>; > > - interrupts = <29 IRQ_TYPE_EDGE_FALLING>; > > + interrupts = <29 IRQ_TYPE_LEVEL_LOW>; > > > > adi,input-depth = <8>; > > adi,input-colorspace = "rgb";
diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts index 74c3212f1f11..824ddab9c3ad 100644 --- a/arch/arm/boot/dts/r8a7791-koelsch.dts +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts @@ -545,7 +545,7 @@ compatible = "adi,adv7511w"; reg = <0x39>; interrupt-parent = <&gpio3>; - interrupts = <29 IRQ_TYPE_EDGE_FALLING>; + interrupts = <29 IRQ_TYPE_LEVEL_LOW>; adi,input-depth = <8>; adi,input-colorspace = "rgb";
The adv7511 IRQ is low level triggered, not falling edge triggered. The wrong sense configuration results in no interrupt being triggered at all, breaking hotplug detection. Fix it. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- arch/arm/boot/dts/r8a7791-koelsch.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)