| Message ID | 1430397114.5802.43.camel@xylophone.i.decadent.org.uk (mailing list archive) |
|---|---|
| State | RFC |
| Delegated to: | Simon Horman |
| Headers | show |
Hi Ben, thanks for your patch-set. On Thu, Apr 30, 2015 at 01:31:54PM +0100, Ben Hutchings wrote: > Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk> > --- > arch/arm/boot/dts/r8a7790.dtsi | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi > index 4bb2f4c17321..23e826153a9d 100644 > --- a/arch/arm/boot/dts/r8a7790.dtsi > +++ b/arch/arm/boot/dts/r8a7790.dtsi > @@ -483,6 +483,23 @@ > pfc: pfc@e6060000 { > compatible = "renesas,pfc-r8a7790"; > reg = <0 0xe6060000 0 0x250>; > + > + vccq_ref_sdhi0: sd-regulator@0 { > + compatible = "renesas,pfc-r8a7790-sd-regulator"; I'm a little confused. What is "renesas,pfc-r8a7790-sd-regulator"? It suspect that it should at least be documented under Documentation/devicetree/bindings/ > + status = "disabled"; > + }; > + vccq_ref_sdhi1: sd-regulator@1 { > + compatible = "renesas,pfc-r8a7790-sd-regulator"; > + status = "disabled"; > + }; > + vccq_ref_sdhi2: sd-regulator@2 { > + compatible = "renesas,pfc-r8a7790-sd-regulator"; > + status = "disabled"; > + }; > + vccq_ref_sdhi3: sd-regulator@3 { > + compatible = "renesas,pfc-r8a7790-sd-regulator"; > + status = "disabled"; > + }; > }; > > sdhi0: sd@ee100000 { > @@ -490,6 +507,7 @@ > reg = <0 0xee100000 0 0x328>; > interrupts = <0 165 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&mstp3_clks R8A7790_CLK_SDHI0>; > + vqmmc-ref-supply = <&vccq_ref_sdhi0>; > dmas = <&dmac1 0xcd>, <&dmac1 0xce>; > dma-names = "tx", "rx"; > status = "disabled"; > @@ -500,6 +518,7 @@ > reg = <0 0xee120000 0 0x328>; > interrupts = <0 166 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&mstp3_clks R8A7790_CLK_SDHI1>; > + vqmmc-ref-supply = <&vccq_ref_sdhi1>; > dmas = <&dmac1 0xc9>, <&dmac1 0xca>; > dma-names = "tx", "rx"; > status = "disabled"; > @@ -510,6 +529,7 @@ > reg = <0 0xee140000 0 0x100>; > interrupts = <0 167 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&mstp3_clks R8A7790_CLK_SDHI2>; > + vqmmc-ref-supply = <&vccq_ref_sdhi2>; > dmas = <&dmac1 0xc1>, <&dmac1 0xc2>; > dma-names = "tx", "rx"; > status = "disabled"; > @@ -520,6 +540,7 @@ > reg = <0 0xee160000 0 0x100>; > interrupts = <0 168 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&mstp3_clks R8A7790_CLK_SDHI3>; > + vqmmc-ref-supply = <&vccq_ref_sdhi3>; > dmas = <&dmac1 0xd3>, <&dmac1 0xd4>; > dma-names = "tx", "rx"; > status = "disabled"; > -- > 1.7.10.4 > > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 2015-05-01 at 09:57 +0900, Simon Horman wrote: > Hi Ben, > > thanks for your patch-set. > > On Thu, Apr 30, 2015 at 01:31:54PM +0100, Ben Hutchings wrote: > > Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk> > > --- > > arch/arm/boot/dts/r8a7790.dtsi | 21 +++++++++++++++++++++ > > 1 file changed, 21 insertions(+) > > > > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi > > index 4bb2f4c17321..23e826153a9d 100644 > > --- a/arch/arm/boot/dts/r8a7790.dtsi > > +++ b/arch/arm/boot/dts/r8a7790.dtsi > > @@ -483,6 +483,23 @@ > > pfc: pfc@e6060000 { > > compatible = "renesas,pfc-r8a7790"; > > reg = <0 0xe6060000 0 0x250>; > > + > > + vccq_ref_sdhi0: sd-regulator@0 { > > + compatible = "renesas,pfc-r8a7790-sd-regulator"; > > I'm a little confused. What is "renesas,pfc-r8a7790-sd-regulator"? > It suspect that it should at least be documented under > Documentation/devicetree/bindings/ [...] It will be if it's agreed that this is the way to represent the voltage switch in the pfc. The sh-pfc driver is changed in patch 3/7 to look for sd-regulator@{0..3} nodes in an r8a7790 DT. The nodes carry only their address and status. The compatible value is currently ignored. Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, May 06, 2015 at 02:18:02AM +0100, Ben Hutchings wrote: > On Fri, 2015-05-01 at 09:57 +0900, Simon Horman wrote: > > Hi Ben, > > > > thanks for your patch-set. > > > > On Thu, Apr 30, 2015 at 01:31:54PM +0100, Ben Hutchings wrote: > > > Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk> > > > --- > > > arch/arm/boot/dts/r8a7790.dtsi | 21 +++++++++++++++++++++ > > > 1 file changed, 21 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi > > > index 4bb2f4c17321..23e826153a9d 100644 > > > --- a/arch/arm/boot/dts/r8a7790.dtsi > > > +++ b/arch/arm/boot/dts/r8a7790.dtsi > > > @@ -483,6 +483,23 @@ > > > pfc: pfc@e6060000 { > > > compatible = "renesas,pfc-r8a7790"; > > > reg = <0 0xe6060000 0 0x250>; > > > + > > > + vccq_ref_sdhi0: sd-regulator@0 { > > > + compatible = "renesas,pfc-r8a7790-sd-regulator"; > > > > I'm a little confused. What is "renesas,pfc-r8a7790-sd-regulator"? > > It suspect that it should at least be documented under > > Documentation/devicetree/bindings/ > [...] > > It will be if it's agreed that this is the way to represent the voltage > switch in the pfc. The sh-pfc driver is changed in patch 3/7 to look > for sd-regulator@{0..3} nodes in an r8a7790 DT. The nodes carry only > their address and status. The compatible value is currently ignored. Thanks, that makes sense. As a rule I generally don't apply DT patches that use bindings that haven't already been accepted. So if this does turn out to be the way to go then please document it. -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi index 4bb2f4c17321..23e826153a9d 100644 --- a/arch/arm/boot/dts/r8a7790.dtsi +++ b/arch/arm/boot/dts/r8a7790.dtsi @@ -483,6 +483,23 @@ pfc: pfc@e6060000 { compatible = "renesas,pfc-r8a7790"; reg = <0 0xe6060000 0 0x250>; + + vccq_ref_sdhi0: sd-regulator@0 { + compatible = "renesas,pfc-r8a7790-sd-regulator"; + status = "disabled"; + }; + vccq_ref_sdhi1: sd-regulator@1 { + compatible = "renesas,pfc-r8a7790-sd-regulator"; + status = "disabled"; + }; + vccq_ref_sdhi2: sd-regulator@2 { + compatible = "renesas,pfc-r8a7790-sd-regulator"; + status = "disabled"; + }; + vccq_ref_sdhi3: sd-regulator@3 { + compatible = "renesas,pfc-r8a7790-sd-regulator"; + status = "disabled"; + }; }; sdhi0: sd@ee100000 { @@ -490,6 +507,7 @@ reg = <0 0xee100000 0 0x328>; interrupts = <0 165 IRQ_TYPE_LEVEL_HIGH>; clocks = <&mstp3_clks R8A7790_CLK_SDHI0>; + vqmmc-ref-supply = <&vccq_ref_sdhi0>; dmas = <&dmac1 0xcd>, <&dmac1 0xce>; dma-names = "tx", "rx"; status = "disabled"; @@ -500,6 +518,7 @@ reg = <0 0xee120000 0 0x328>; interrupts = <0 166 IRQ_TYPE_LEVEL_HIGH>; clocks = <&mstp3_clks R8A7790_CLK_SDHI1>; + vqmmc-ref-supply = <&vccq_ref_sdhi1>; dmas = <&dmac1 0xc9>, <&dmac1 0xca>; dma-names = "tx", "rx"; status = "disabled"; @@ -510,6 +529,7 @@ reg = <0 0xee140000 0 0x100>; interrupts = <0 167 IRQ_TYPE_LEVEL_HIGH>; clocks = <&mstp3_clks R8A7790_CLK_SDHI2>; + vqmmc-ref-supply = <&vccq_ref_sdhi2>; dmas = <&dmac1 0xc1>, <&dmac1 0xc2>; dma-names = "tx", "rx"; status = "disabled"; @@ -520,6 +540,7 @@ reg = <0 0xee160000 0 0x100>; interrupts = <0 168 IRQ_TYPE_LEVEL_HIGH>; clocks = <&mstp3_clks R8A7790_CLK_SDHI3>; + vqmmc-ref-supply = <&vccq_ref_sdhi3>; dmas = <&dmac1 0xd3>, <&dmac1 0xd4>; dma-names = "tx", "rx"; status = "disabled";
Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk> --- arch/arm/boot/dts/r8a7790.dtsi | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)