| Message ID | 1436529553-30571-4-git-send-email-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | RFC |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
Hi Geert-san, Thank you for the patch! > Sent: Friday, July 10, 2015 8:59 PM > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > Shimoda-san, are these correct? Unfortunately, the buswitdh of SUDMAC is 1 only. > It seems the SUDMAC (used in sh7757 only) was never wired up in > mainline? This is correct. I'm not sure. But, I guess the SUDMAC is not used on new SoCs in the future. Best regards, Yoshihiro Shimoda > --- > drivers/dma/sh/sudmac.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/dma/sh/sudmac.c b/drivers/dma/sh/sudmac.c > index 31e681230e1894f2..7c4066503ce335f7 100644 > --- a/drivers/dma/sh/sudmac.c > +++ b/drivers/dma/sh/sudmac.c > @@ -331,6 +331,8 @@ static const struct shdma_ops sudmac_shdma_ops = { > > static int sudmac_probe(struct platform_device *pdev) > { > + const enum dma_slave_buswidth widths = DMA_SLAVE_BUSWIDTH_1_BYTE | > + DMA_SLAVE_BUSWIDTH_2_BYTES | DMA_SLAVE_BUSWIDTH_4_BYTES; > struct sudmac_pdata *pdata = dev_get_platdata(&pdev->dev); > int err, i; > struct sudmac_device *su_dev; > @@ -361,6 +363,9 @@ static int sudmac_probe(struct platform_device *pdev) > return PTR_ERR(su_dev->chan_reg); > > dma_cap_set(DMA_SLAVE, dma_dev->cap_mask); > + dma_dev->src_addr_widths = widths; > + dma_dev->dst_addr_widths = widths; > + dma_dev->directions = BIT(DMA_MEM_TO_DEV) | BIT(DMA_DEV_TO_MEM); > dma_dev->residue_granularity = DMA_RESIDUE_GRANULARITY_BURST; > > su_dev->shdma_dev.ops = &sudmac_shdma_ops; > -- > 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Shimoda-san, On Mon, Jul 13, 2015 at 10:31 AM, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote: >> Shimoda-san, are these correct? > > Unfortunately, the buswitdh of SUDMAC is 1 only. Thanks, I'll update the patch. >> diff --git a/drivers/dma/sh/sudmac.c b/drivers/dma/sh/sudmac.c >> index 31e681230e1894f2..7c4066503ce335f7 100644 >> --- a/drivers/dma/sh/sudmac.c >> +++ b/drivers/dma/sh/sudmac.c >> @@ -331,6 +331,8 @@ static const struct shdma_ops sudmac_shdma_ops = { >> >> static int sudmac_probe(struct platform_device *pdev) >> { >> + const enum dma_slave_buswidth widths = DMA_SLAVE_BUSWIDTH_1_BYTE | >> + DMA_SLAVE_BUSWIDTH_2_BYTES | DMA_SLAVE_BUSWIDTH_4_BYTES; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/dma/sh/sudmac.c b/drivers/dma/sh/sudmac.c index 31e681230e1894f2..7c4066503ce335f7 100644 --- a/drivers/dma/sh/sudmac.c +++ b/drivers/dma/sh/sudmac.c @@ -331,6 +331,8 @@ static const struct shdma_ops sudmac_shdma_ops = { static int sudmac_probe(struct platform_device *pdev) { + const enum dma_slave_buswidth widths = DMA_SLAVE_BUSWIDTH_1_BYTE | + DMA_SLAVE_BUSWIDTH_2_BYTES | DMA_SLAVE_BUSWIDTH_4_BYTES; struct sudmac_pdata *pdata = dev_get_platdata(&pdev->dev); int err, i; struct sudmac_device *su_dev; @@ -361,6 +363,9 @@ static int sudmac_probe(struct platform_device *pdev) return PTR_ERR(su_dev->chan_reg); dma_cap_set(DMA_SLAVE, dma_dev->cap_mask); + dma_dev->src_addr_widths = widths; + dma_dev->dst_addr_widths = widths; + dma_dev->directions = BIT(DMA_MEM_TO_DEV) | BIT(DMA_DEV_TO_MEM); dma_dev->residue_granularity = DMA_RESIDUE_GRANULARITY_BURST; su_dev->shdma_dev.ops = &sudmac_shdma_ops;
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- Shimoda-san, are these correct? It seems the SUDMAC (used in sh7757 only) was never wired up in mainline? --- drivers/dma/sh/sudmac.c | 5 +++++ 1 file changed, 5 insertions(+)