diff mbox

[PATCH/RFC,v2,3/5] arm64: dts: r8a7795: enable EthernetAVB on Salvator-X

Message ID 1441936996-18437-4-git-send-email-horms+renesas@verge.net.au (mailing list archive)
State RFC
Delegated to: Simon Horman
Headers show

Commit Message

Simon Horman Sept. 11, 2015, 2:03 a.m. UTC
From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>

Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
[horms: minor updates]
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

---

v0 [Kazuya Mizuguchi]

v1 [Simon Horman]
* updated filename to salvator-x
* updated patch subject

v2 [Simon Horman]
* Removed spurious update to r8a7795.dtsi introduced in v1
* Removed unused renesas,phy property
---
 arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 33 ++++++++++++++++++++++
 1 file changed, 33 insertions(+)

Comments

Geert Uytterhoeven Sept. 11, 2015, 7:25 a.m. UTC | #1
Hi Simon,

On Fri, Sep 11, 2015 at 4:03 AM, Simon Horman
<horms+renesas@verge.net.au> wrote:
> --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> @@ -41,6 +41,11 @@
>                 renesas,groups = "scif2_data_a";
>                 renesas,function = "scif2";
>         };
> +
> +       avb_pins: avb {
> +               renesas,groups = "avb_mdc";
> +               renesas,function = "avb";
> +       };

This is not in pfc-r8a7795.c. I believe you using CONFIG_PINCTRL=n with
the bootloader settings?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman Sept. 11, 2015, 8:09 a.m. UTC | #2
On Fri, Sep 11, 2015 at 09:25:54AM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Fri, Sep 11, 2015 at 4:03 AM, Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> > +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> > @@ -41,6 +41,11 @@
> >                 renesas,groups = "scif2_data_a";
> >                 renesas,function = "scif2";
> >         };
> > +
> > +       avb_pins: avb {
> > +               renesas,groups = "avb_mdc";
> > +               renesas,function = "avb";
> > +       };
> 
> This is not in pfc-r8a7795.c. I believe you using CONFIG_PINCTRL=n with
> the bootloader settings?

With regards to the settings: It looks like CONFIG_PINCTRL and
CONFIG_PINCTRL_PFC_R8A7795 were both enabled for my most recent test.
A bit curious.

Regardless, I agree that the above is missing from pfc-r8a7795.c.
I can take a look at creating a PFC patch unless someone else wants to.
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
index 5bae2cc0c61e..4fb141230f0c 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
@@ -41,6 +41,11 @@ 
 		renesas,groups = "scif2_data_a";
 		renesas,function = "scif2";
 	};
+
+	avb_pins: avb {
+		renesas,groups = "avb_mdc";
+		renesas,function = "avb";
+	};
 };
 
 &scif1 {
@@ -56,3 +61,31 @@ 
 
 	status = "okay";
 };
+
+&avb {
+	pinctrl-0 = <&avb_pins>;
+	pinctrl-names = "default";
+	renesas,no-ether-link;
+	phy-reset-gpio = <&gpio2 10 0>;
+	phy-handle = <&phy0>;
+	status = "okay";
+
+	phy0: ethernet-phy@0 {
+		rxc-skew-ps = <900>;
+		rxdv-skew-ps = <0>;
+		rxd0-skew-ps = <0>;
+		rxd1-skew-ps = <0>;
+		rxd2-skew-ps = <0>;
+		rxd3-skew-ps = <0>;
+		txc-skew-ps = <900>;
+		txen-skew-ps = <0>;
+		txd0-skew-ps = <0>;
+		txd1-skew-ps = <0>;
+		txd2-skew-ps = <0>;
+		txd3-skew-ps = <0>;
+		reg = <0>;
+		interrupt-parent = <&gpio2>;
+		interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
+	};
+
+};