| Message ID | 1447787440-11080-1-git-send-email-horms+renesas@verge.net.au (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 22b160713cb6944450dad0abd18d8929f60500dc |
| Headers | show |
On Tue, Nov 17, 2015 at 8:10 PM, Simon Horman <horms+renesas@verge.net.au> wrote: > PFC is already enabled on the r8a7794. > This adds pins for devices already enabled in DT on > the r8a7794 based alt board. > > Based on work by Mitsuhiro Kimura and Hisashi Nakamura. > > Cc: Mitsuhiro Kimura <mitsuhiro.kimura.kc@renesas.com> > Cc: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> Looks good. Acked-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> CU Uli -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Nov 18, 2015 at 02:04:33PM +0100, Ulrich Hecht wrote: > On Tue, Nov 17, 2015 at 8:10 PM, Simon Horman > <horms+renesas@verge.net.au> wrote: > > PFC is already enabled on the r8a7794. > > This adds pins for devices already enabled in DT on > > the r8a7794 based alt board. > > > > Based on work by Mitsuhiro Kimura and Hisashi Nakamura. > > > > Cc: Mitsuhiro Kimura <mitsuhiro.kimura.kc@renesas.com> > > Cc: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com> > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > Looks good. > > Acked-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> Thanks for reviewing this. I have queued it up. -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello. On 11/17/2015 10:10 PM, Simon Horman wrote: > PFC is already enabled on the r8a7794. > This adds pins for devices already enabled in DT on > the r8a7794 based alt board. > > Based on work by Mitsuhiro Kimura and Hisashi Nakamura. > > Cc: Mitsuhiro Kimura <mitsuhiro.kimura.kc@renesas.com> > Cc: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > --- > Tested > --- > arch/arm/boot/dts/r8a7794-alt.dts | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm/boot/dts/r8a7794-alt.dts b/arch/arm/boot/dts/r8a7794-alt.dts > index 928cfa641475..2e889991ce8f 100644 > --- a/arch/arm/boot/dts/r8a7794-alt.dts > +++ b/arch/arm/boot/dts/r8a7794-alt.dts > @@ -39,6 +39,23 @@ > clock-frequency = <20000000>; > }; > > +&pfc { > + scif2_pins: serial2 { > + renesas,groups = "scif2_data"; > + renesas,function = "scif2"; > + }; > + > + ether_pins: ether { > + renesas,groups = "eth_link", "eth_mdio", "eth_rmii"; > + renesas,function = "eth"; > + }; > + > + ether_b_pins: ether { > + renesas,groups = "eth_link_b", "eth_mdio_b", "eth_rmii_b"; > + renesas,function = "eth"; > + }; > +}; > + > &cmt0 { > status = "okay"; > }; Why add unreferenced pins? How have you tested this? MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Nov 20, 2015 at 03:11:17PM +0300, Sergei Shtylyov wrote: > Hello. > > On 11/17/2015 10:10 PM, Simon Horman wrote: > > >PFC is already enabled on the r8a7794. > >This adds pins for devices already enabled in DT on > >the r8a7794 based alt board. > > > >Based on work by Mitsuhiro Kimura and Hisashi Nakamura. > > > >Cc: Mitsuhiro Kimura <mitsuhiro.kimura.kc@renesas.com> > >Cc: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com> > >Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > > >--- > >Tested > >--- > > arch/arm/boot/dts/r8a7794-alt.dts | 17 +++++++++++++++++ > > 1 file changed, 17 insertions(+) > > > >diff --git a/arch/arm/boot/dts/r8a7794-alt.dts b/arch/arm/boot/dts/r8a7794-alt.dts > >index 928cfa641475..2e889991ce8f 100644 > >--- a/arch/arm/boot/dts/r8a7794-alt.dts > >+++ b/arch/arm/boot/dts/r8a7794-alt.dts > >@@ -39,6 +39,23 @@ > > clock-frequency = <20000000>; > > }; > > > >+&pfc { > >+ scif2_pins: serial2 { > >+ renesas,groups = "scif2_data"; > >+ renesas,function = "scif2"; > >+ }; > >+ > >+ ether_pins: ether { > >+ renesas,groups = "eth_link", "eth_mdio", "eth_rmii"; > >+ renesas,function = "eth"; > >+ }; > >+ > >+ ether_b_pins: ether { > >+ renesas,groups = "eth_link_b", "eth_mdio_b", "eth_rmii_b"; > >+ renesas,function = "eth"; > >+ }; > >+}; > >+ > > &cmt0 { > > status = "okay"; > > }; > > Why add unreferenced pins? How have you tested this? Thanks for pointing out that oversight. I'll see about filling in the gaps. -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11/20/2015 09:34 PM, Simon Horman wrote: >>> PFC is already enabled on the r8a7794. >>> This adds pins for devices already enabled in DT on >>> the r8a7794 based alt board. >>> >>> Based on work by Mitsuhiro Kimura and Hisashi Nakamura. >>> >>> Cc: Mitsuhiro Kimura <mitsuhiro.kimura.kc@renesas.com> >>> Cc: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com> >>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au> >>> >>> --- >>> Tested >>> --- >>> arch/arm/boot/dts/r8a7794-alt.dts | 17 +++++++++++++++++ >>> 1 file changed, 17 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/r8a7794-alt.dts b/arch/arm/boot/dts/r8a7794-alt.dts >>> index 928cfa641475..2e889991ce8f 100644 >>> --- a/arch/arm/boot/dts/r8a7794-alt.dts >>> +++ b/arch/arm/boot/dts/r8a7794-alt.dts >>> @@ -39,6 +39,23 @@ >>> clock-frequency = <20000000>; >>> }; >>> >>> +&pfc { >>> + scif2_pins: serial2 { >>> + renesas,groups = "scif2_data"; >>> + renesas,function = "scif2"; >>> + }; >>> + >>> + ether_pins: ether { >>> + renesas,groups = "eth_link", "eth_mdio", "eth_rmii"; >>> + renesas,function = "eth"; >>> + }; >>> + >>> + ether_b_pins: ether { >>> + renesas,groups = "eth_link_b", "eth_mdio_b", "eth_rmii_b"; >>> + renesas,function = "eth"; >>> + }; >>> +}; >>> + >>> &cmt0 { >>> status = "okay"; >>> }; >> >> Why add unreferenced pins? How have you tested this? > > Thanks for pointing out that oversight. I'll see about filling in the gaps. Sorry for noticing this too late, only when you were pushing your branches upstream... MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Nov 20, 2015 at 09:50:08PM +0300, Sergei Shtylyov wrote: > On 11/20/2015 09:34 PM, Simon Horman wrote: > > >>>PFC is already enabled on the r8a7794. > >>>This adds pins for devices already enabled in DT on > >>>the r8a7794 based alt board. > >>> > >>>Based on work by Mitsuhiro Kimura and Hisashi Nakamura. > >>> > >>>Cc: Mitsuhiro Kimura <mitsuhiro.kimura.kc@renesas.com> > >>>Cc: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com> > >>>Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > >>> > >>>--- > >>>Tested > >>>--- > >>> arch/arm/boot/dts/r8a7794-alt.dts | 17 +++++++++++++++++ > >>> 1 file changed, 17 insertions(+) > >>> > >>>diff --git a/arch/arm/boot/dts/r8a7794-alt.dts b/arch/arm/boot/dts/r8a7794-alt.dts > >>>index 928cfa641475..2e889991ce8f 100644 > >>>--- a/arch/arm/boot/dts/r8a7794-alt.dts > >>>+++ b/arch/arm/boot/dts/r8a7794-alt.dts > >>>@@ -39,6 +39,23 @@ > >>> clock-frequency = <20000000>; > >>> }; > >>> > >>>+&pfc { > >>>+ scif2_pins: serial2 { > >>>+ renesas,groups = "scif2_data"; > >>>+ renesas,function = "scif2"; > >>>+ }; > >>>+ > >>>+ ether_pins: ether { > >>>+ renesas,groups = "eth_link", "eth_mdio", "eth_rmii"; > >>>+ renesas,function = "eth"; > >>>+ }; > >>>+ > >>>+ ether_b_pins: ether { > >>>+ renesas,groups = "eth_link_b", "eth_mdio_b", "eth_rmii_b"; > >>>+ renesas,function = "eth"; > >>>+ }; > >>>+}; > >>>+ > >>> &cmt0 { > >>> status = "okay"; > >>> }; > >> > >> Why add unreferenced pins? How have you tested this? > > > >Thanks for pointing out that oversight. I'll see about filling in the gaps. > > Sorry for noticing this too late, only when you were pushing your > branches upstream... No problem, thanks for noticing at all. FYI: It looks like things work well when using the scif2 but not the ether pins. I suspect the latter is due to the lack of phy pin support both above and by inspection in the pfc driver. I will investigate further. -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/r8a7794-alt.dts b/arch/arm/boot/dts/r8a7794-alt.dts index 928cfa641475..2e889991ce8f 100644 --- a/arch/arm/boot/dts/r8a7794-alt.dts +++ b/arch/arm/boot/dts/r8a7794-alt.dts @@ -39,6 +39,23 @@ clock-frequency = <20000000>; }; +&pfc { + scif2_pins: serial2 { + renesas,groups = "scif2_data"; + renesas,function = "scif2"; + }; + + ether_pins: ether { + renesas,groups = "eth_link", "eth_mdio", "eth_rmii"; + renesas,function = "eth"; + }; + + ether_b_pins: ether { + renesas,groups = "eth_link_b", "eth_mdio_b", "eth_rmii_b"; + renesas,function = "eth"; + }; +}; + &cmt0 { status = "okay"; };
PFC is already enabled on the r8a7794. This adds pins for devices already enabled in DT on the r8a7794 based alt board. Based on work by Mitsuhiro Kimura and Hisashi Nakamura. Cc: Mitsuhiro Kimura <mitsuhiro.kimura.kc@renesas.com> Cc: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com> Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- Tested --- arch/arm/boot/dts/r8a7794-alt.dts | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)