| Message ID | 1449505537-15428-1-git-send-email-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a6ff5e8d5ebc0392d5c470652cd22f730e090e29 |
| Headers | show |
Hi > The default value of #sound-dai-cells in r8a7778.dtsi is one, while > the /sound/simple-audio-card,cpu device node in r8a7778-bockw.dts uses a > phandle without any extra cells ("<&rcar_sound>"), causing: > > /sound/simple-audio-card,cpu: arguments longer than property > asoc-simple-card sound: parse error -22 > asoc-simple-card: probe of sound failed with error -22 > > Override #sound-dai-cells to zero to fix this. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > The rcar_sound node is still disabled. So why is this needed?!? This error came from "simple-audio-card", not "rcar_sound" I think. # sound needs many drivers... Actually, I don't want to have default #sound-dai-cells in r8a7778.dtsi. Like below. I will send this patch soon ad63241cdc328edbb0f879416ea7707bf0997f08 ("ARM: shmobile: r8a7790: tidyup #sound-dai-cells settings") -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/r8a7778-bockw.dts b/arch/arm/boot/dts/r8a7778-bockw.dts index 3c03e6b8261e9348..158ad94fd4d187a7 100644 --- a/arch/arm/boot/dts/r8a7778-bockw.dts +++ b/arch/arm/boot/dts/r8a7778-bockw.dts @@ -172,6 +172,11 @@ }; }; +&rcar_sound { + /* Single DAI */ + #sound-dai-cells = <0>; +}; + &sdhi0 { pinctrl-0 = <&sdhi0_pins>, <&sdhi0_pup_pins>; pinctrl-names = "default";
The default value of #sound-dai-cells in r8a7778.dtsi is one, while the /sound/simple-audio-card,cpu device node in r8a7778-bockw.dts uses a phandle without any extra cells ("<&rcar_sound>"), causing: /sound/simple-audio-card,cpu: arguments longer than property asoc-simple-card sound: parse error -22 asoc-simple-card: probe of sound failed with error -22 Override #sound-dai-cells to zero to fix this. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- The rcar_sound node is still disabled. So why is this needed?!? --- arch/arm/boot/dts/r8a7778-bockw.dts | 5 +++++ 1 file changed, 5 insertions(+)