diff mbox

[2/2] v4l: vsp1: Add missing #include <linux/slab.h>

Message ID 1452536727-19538-2-git-send-email-geert+renesas@glider.be
State Under Review
Delegated to: Geert Uytterhoeven
Headers show

Commit Message

Geert Uytterhoeven Jan. 11, 2016, 6:25 p.m. UTC
If CONFIG_SPI=n:

drivers/media/platform/vsp1/vsp1_dl.c: In function 'vsp1_dl_create':
drivers/media/platform/vsp1/vsp1_dl.c:271:2: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration]
  dl = kzalloc(sizeof(*dl), GFP_KERNEL);
  ^
drivers/media/platform/vsp1/vsp1_dl.c:271:5: warning: assignment makes pointer from integer without a cast
  dl = kzalloc(sizeof(*dl), GFP_KERNEL);
     ^
drivers/media/platform/vsp1/vsp1_dl.c:283:3: error: implicit declaration of function 'kfree' [-Werror=implicit-function-declaration]
   kfree(dl);
   ^

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Against renesas-drivers-2016-01-05-v4.4-rc8

 drivers/media/platform/vsp1/vsp1_dl.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Laurent Pinchart Jan. 11, 2016, 6:27 p.m. UTC | #1
Hi Geert,

Thank you for the patch.

On Monday 11 January 2016 19:25:27 Geert Uytterhoeven wrote:
> If CONFIG_SPI=n:
> 
> drivers/media/platform/vsp1/vsp1_dl.c: In function 'vsp1_dl_create':
> drivers/media/platform/vsp1/vsp1_dl.c:271:2: error: implicit declaration of
> function 'kzalloc' [-Werror=implicit-function-declaration] dl =
> kzalloc(sizeof(*dl), GFP_KERNEL);
>   ^
> drivers/media/platform/vsp1/vsp1_dl.c:271:5: warning: assignment makes
> pointer from integer without a cast dl = kzalloc(sizeof(*dl), GFP_KERNEL);
>      ^
> drivers/media/platform/vsp1/vsp1_dl.c:283:3: error: implicit declaration of
> function 'kfree' [-Werror=implicit-function-declaration] kfree(dl);
>    ^
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

I have this in my tree already.

> ---
> Against renesas-drivers-2016-01-05-v4.4-rc8
> 
>  drivers/media/platform/vsp1/vsp1_dl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/vsp1/vsp1_dl.c
> b/drivers/media/platform/vsp1/vsp1_dl.c index
> a4dcccf0778bb479..7dc27ac6bd02a38b 100644
> --- a/drivers/media/platform/vsp1/vsp1_dl.c
> +++ b/drivers/media/platform/vsp1/vsp1_dl.c
> @@ -14,6 +14,7 @@
>  #include <linux/device.h>
>  #include <linux/dma-mapping.h>
>  #include <linux/gfp.h>
> +#include <linux/slab.h>
> 
>  #include "vsp1.h"
>  #include "vsp1_dl.h"
Geert Uytterhoeven Jan. 11, 2016, 6:43 p.m. UTC | #2
Hi Laurent,

On Mon, Jan 11, 2016 at 7:27 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Monday 11 January 2016 19:25:27 Geert Uytterhoeven wrote:
>> If CONFIG_SPI=n:
>>
>> drivers/media/platform/vsp1/vsp1_dl.c: In function 'vsp1_dl_create':
>> drivers/media/platform/vsp1/vsp1_dl.c:271:2: error: implicit declaration of
>> function 'kzalloc' [-Werror=implicit-function-declaration] dl =
>> kzalloc(sizeof(*dl), GFP_KERNEL);
>>   ^
>> drivers/media/platform/vsp1/vsp1_dl.c:271:5: warning: assignment makes
>> pointer from integer without a cast dl = kzalloc(sizeof(*dl), GFP_KERNEL);
>>      ^
>> drivers/media/platform/vsp1/vsp1_dl.c:283:3: error: implicit declaration of
>> function 'kfree' [-Werror=implicit-function-declaration] kfree(dl);
>>    ^
>>
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> I have this in my tree already.

OK.

I had checked http://git.linuxtv.org//pinchartl/media.git/, but didn't see a
new tag ;-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/media/platform/vsp1/vsp1_dl.c b/drivers/media/platform/vsp1/vsp1_dl.c
index a4dcccf0778bb479..7dc27ac6bd02a38b 100644
--- a/drivers/media/platform/vsp1/vsp1_dl.c
+++ b/drivers/media/platform/vsp1/vsp1_dl.c
@@ -14,6 +14,7 @@ 
 #include <linux/device.h>
 #include <linux/dma-mapping.h>
 #include <linux/gfp.h>
+#include <linux/slab.h>
 
 #include "vsp1.h"
 #include "vsp1_dl.h"