diff mbox

pinctrl: sh-pfc: sh7757: Fix duplicate initializer in GPIO pinmux data

Message ID 1465552699-5990-1-git-send-email-geert+renesas@glider.be (mailing list archive)
State New, archived
Headers show

Commit Message

Geert Uytterhoeven June 10, 2016, 9:58 a.m. UTC
With C=1:

    drivers/pinctrl/sh-pfc/pfc-sh7757.c:1613:9: warning: Initializer entry defined twice
    drivers/pinctrl/sh-pfc/pfc-sh7757.c:1628:9:   also defined here

Remove the duplicate initializer to fix this.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Based on the comment near the definition of A16_MARK, which states A16
belongs to the "PTV" section.

I do not have a sh7757 datasheet.
---
 drivers/pinctrl/sh-pfc/pfc-sh7757.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Laurent Pinchart June 10, 2016, 12:17 p.m. UTC | #1
Hi Geert,

Thank you for the patch.

On Friday 10 Jun 2016 11:58:19 Geert Uytterhoeven wrote:
> With C=1:
> 
>     drivers/pinctrl/sh-pfc/pfc-sh7757.c:1613:9: warning: Initializer entry
> defined twice drivers/pinctrl/sh-pfc/pfc-sh7757.c:1628:9:   also defined
> here
> 
> Remove the duplicate initializer to fix this.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> Based on the comment near the definition of A16_MARK, which states A16
> belongs to the "PTV" section.
> 
> I do not have a sh7757 datasheet.
> ---
>  drivers/pinctrl/sh-pfc/pfc-sh7757.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/sh-pfc/pfc-sh7757.c
> b/drivers/pinctrl/sh-pfc/pfc-sh7757.c index
> 0555a1fe076ed353..6d8c31caefc105e0 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-sh7757.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-sh7757.c
> @@ -1625,7 +1625,6 @@ static const struct pinmux_func pinmux_func_gpios[] =
> { GPIO_FN(VBIOS_CS),
> 
>  	/* PTW (mobule: LBSC, EVC, SCIF) */
> -	GPIO_FN(A16),
>  	GPIO_FN(A15),
>  	GPIO_FN(A14),
>  	GPIO_FN(A13),
diff mbox

Patch

diff --git a/drivers/pinctrl/sh-pfc/pfc-sh7757.c b/drivers/pinctrl/sh-pfc/pfc-sh7757.c
index 0555a1fe076ed353..6d8c31caefc105e0 100644
--- a/drivers/pinctrl/sh-pfc/pfc-sh7757.c
+++ b/drivers/pinctrl/sh-pfc/pfc-sh7757.c
@@ -1625,7 +1625,6 @@  static const struct pinmux_func pinmux_func_gpios[] = {
 	GPIO_FN(VBIOS_CS),
 
 	/* PTW (mobule: LBSC, EVC, SCIF) */
-	GPIO_FN(A16),
 	GPIO_FN(A15),
 	GPIO_FN(A14),
 	GPIO_FN(A13),