From patchwork Wed Apr 25 11:17:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Brodkin X-Patchwork-Id: 10362733 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B50696032C for ; Wed, 25 Apr 2018 11:27:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A3D2F283CB for ; Wed, 25 Apr 2018 11:27:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 97FA628D43; Wed, 25 Apr 2018 11:27:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 096E52842B for ; Wed, 25 Apr 2018 11:27:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753503AbeDYL1A (ORCPT ); Wed, 25 Apr 2018 07:27:00 -0400 Received: from smtprelay6.synopsys.com ([198.182.37.59]:54119 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753297AbeDYL0y (ORCPT ); Wed, 25 Apr 2018 07:26:54 -0400 X-Greylist: delayed 585 seconds by postgrey-1.27 at vger.kernel.org; Wed, 25 Apr 2018 07:26:52 EDT Received: from mailhost.synopsys.com (mailhost1.synopsys.com [10.12.238.239]) by smtprelay.synopsys.com (Postfix) with ESMTP id AB1631E05F3; Wed, 25 Apr 2018 13:17:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1524655026; bh=UIJ+6F1B+rhlg4heqGy8v9NuLpPAztUUul3x3X3RHbA=; h=From:To:CC:Subject:Date:References:In-Reply-To:From; b=gnvV2HVbACDe8JwGRImT/F66Coc+V43yZ8Old2riELYTjP2x1Fr2fGO0V3FRg8e2a mrEZ5afymzJz4UkdDXMF9QeklZrij5Qi8uUvbab12e1RrUX+V01ZBEzCcGh6yIDS6n c3CB39mswiCer1fqKR1UgGi2X0D2CWy8IO+PWmsHpvlLveDD6RBLuUjVoHi4xbMLTn zh6btgHXOGuzWikv8pYHAlzKXpCR7GXo3PyUIxJg8t/f+ycSWEjViYdJh/4FzKFvtd 61Lcd8U0aKU1TeVp+0f4XFKNE3D+yUWXRyz5iQrL9ZHsF/MaDy3VXMmmiC3Gx9LWU3 XACc0hZzBE3ZQ== Received: from US01WEHTC3.internal.synopsys.com (us01wehtc3.internal.synopsys.com [10.15.84.232]) by mailhost.synopsys.com (Postfix) with ESMTP id 8BAA55E1F; Wed, 25 Apr 2018 04:17:04 -0700 (PDT) Received: from DE02WEHTCB.internal.synopsys.com (10.225.19.94) by US01WEHTC3.internal.synopsys.com (10.15.84.232) with Microsoft SMTP Server (TLS) id 14.3.361.1; Wed, 25 Apr 2018 04:17:04 -0700 Received: from DE02WEMBXB.internal.synopsys.com ([fe80::95ce:118a:8321:a099]) by DE02WEHTCB.internal.synopsys.com ([::1]) with mapi id 14.03.0361.001; Wed, 25 Apr 2018 13:17:02 +0200 From: Alexey Brodkin To: "hch@lst.de" CC: "deanbo422@gmail.com" , "linux-sh@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "nios2-dev@lists.rocketboards.org" , "linux-xtensa@linux-xtensa.org" , "linux-m68k@lists.linux-m68k.org" , "linux-alpha@vger.kernel.org" , "linux-hexagon@vger.kernel.org" , "linux-snps-arc@lists.infradead.org" , "green.hu@gmail.com" , "openrisc@lists.librecores.org" , "linux-arm-kernel@lists.infradead.org" , "monstr@monstr.eu" , "linux-parisc@vger.kernel.org" , "linux-c6x-dev@linux-c6x.org" , "linux-arch@vger.kernel.org" , "sparclinux@vger.kernel.org" Subject: Re: [PATCH 06/22] arc: use generic dma_noncoherent_ops Thread-Topic: [PATCH 06/22] arc: use generic dma_noncoherent_ops Thread-Index: AQHT2H4VURtktiHrREGui6QsrcbxH6QJKXmAgAgR3wA= Date: Wed, 25 Apr 2018 11:17:01 +0000 Message-ID: <1524655020.5315.9.camel@synopsys.com> References: <20180420080313.18796-1-hch@lst.de> <20180420080313.18796-7-hch@lst.de> In-Reply-To: <20180420080313.18796-7-hch@lst.de> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.121.8.87] Content-ID: <213720B0788595488614ECA66BA22CC2@internal.synopsys.com> MIME-Version: 1.0 Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Christoph, On Fri, 2018-04-20 at 10:02 +0200, Christoph Hellwig wrote: > Switch to the generic noncoherent direct mapping implementation. > > Signed-off-by: Christoph Hellwig > --- > arch/arc/Kconfig | 4 + > arch/arc/include/asm/Kbuild | 1 + > arch/arc/include/asm/dma-mapping.h | 21 ----- > arch/arc/mm/dma.c | 141 +++-------------------------- > 4 files changed, 19 insertions(+), 148 deletions(-) > delete mode 100644 arch/arc/include/asm/dma-mapping.h > [snip] > @@ -135,7 +134,7 @@ static int arc_dma_mmap(struct device *dev, struct vm_area_struct *vma, > * CPU accesses page via normal paddr, thus needs to explicitly made > * consistent before each use > */ > -static void _dma_cache_sync(phys_addr_t paddr, size_t size, > +static void _dma_cache_sync(struct device *dev, phys_addr_t paddr size_t size, > enum dma_data_direction dir) Seems like there's a missing comma: ----------------------------------->8------------------------------------ --- a/arch/arc/mm/dma.c +++ b/arch/arc/mm/dma.c @@ -134,7 +134,7 @@ int arch_dma_mmap(struct device *dev, struct vm_area_struct *vma, * CPU accesses page via normal paddr, thus needs to explicitly made * consistent before each use */ -static void _dma_cache_sync(struct device *dev, phys_addr_t paddr size_t size, +static void _dma_cache_sync(struct device *dev, phys_addr_t paddr, size_t size, enum dma_data_direction dir) { switch (dir) { ----------------------------------->8------------------------------------ Which is actually strange as I would expect ARC code to be built by bots. Anyways with above fix I do see problems with both USB and Ethernet controllers on ARC HSDK board. ----------------------------------->8------------------------------------ usb 1-1: new high-speed USB device number 2 using ehci-platform usb 1-1: device descriptor read/64, error -32 usb 1-1: device descriptor read/64, error -32 usb 1-1: new high-speed USB device number 3 using ehci-platform usb 1-1: device descriptor read/64, error -32 usb 1-1: device descriptor read/64, error -32 usb usb1-port1: attempt power cycle usb 1-1: new high-speed USB device number 4 using ehci-platform usb 1-1: device not accepting address 4, error -32 usb 1-1: new high-speed USB device number 5 using ehci-platform usb 1-1: device not accepting address 5, error -32 ... # wget ftp://ftp.denx.de/pub/u-boot/u-boot-1.0.0.tar.bz2 Connecting to ftp.denx.de (81.169.202.6:21) wget: can't connect to remote host (81.169.202.6): No route to host ----------------------------------->8------------------------------------ Will all patches from the series reverted (i.e. with your base-line) all issues go away. I'll need to spend more time on checking what's actually wrong. -Alexey P.S. Note to my ARC colleagues - it's required to disable IO Coherency to get DMA ops really used, it could be obviously done with: ----------------------------------->8------------------------------------ --- a/arch/arc/mm/cache.c +++ b/arch/arc/mm/cache.c @@ -27,7 +27,7 @@ static int l2_line_sz; static int ioc_exists; -int slc_enable = 1, ioc_enable = 1; +int slc_enable = 1, ioc_enable = 0; unsigned long perip_base = ARC_UNCACHED_ADDR_SPACE; /* legacy value for boot */ unsigned long perip_end = 0xFFFFFFFF; /* legacy value */ ----------------------------------->8------------------------------------