From patchwork Sat Jun 20 00:50:35 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Shtylyov X-Patchwork-Id: 6649931 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 9F8EEC05AD for ; Sat, 20 Jun 2015 00:50:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0BDAB20888 for ; Sat, 20 Jun 2015 00:50:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 595B020897 for ; Sat, 20 Jun 2015 00:50:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932145AbbFTAuq (ORCPT ); Fri, 19 Jun 2015 20:50:46 -0400 Received: from mail-la0-f46.google.com ([209.85.215.46]:34394 "EHLO mail-la0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754182AbbFTAuj (ORCPT ); Fri, 19 Jun 2015 20:50:39 -0400 Received: by labbc20 with SMTP id bc20so83049048lab.1 for ; Fri, 19 Jun 2015 17:50:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=hzNw9sB2sZKjmK3HAkZ5IAmeIEsA85imRXURlckwmIc=; b=PaMrChGFJmHTY710LMEQkPMqhoPNjyMJ8+y/Qspisfzv6moUxSXngOXJKT5hl7dWBg WFc+wkERf3Ff+3sGLuIROe/xhHyxcu73+LHJtmLOa6U+LpGcgH+rnEQXtvrMvSKVGGl0 C5zT2v9n/vc/RS95VrTarBU08b2KlIZl2MJXfJfpn+PZJ4MVQiKEtgKb0ejcGxRy0I9/ nTckvmfV6veOHfxQQfRx/OPMo5JaeIA/cAuuxtILIZYvy/WR3KxEAilTG4tCySEB7Ltp zxp2czgJdM3otLGJiKyHq/y5KqIh7NL8pL7JaRpKeBGDpP6DVoAjC4oSpWaJeMLquC55 3Bnw== X-Gm-Message-State: ALoCoQmMkdimjKrlW4sizgGvybTMPtOkecXw7y3bVjPc1gnIpMs3rSNviIV4ZEXwbxNGJWbkNRHp X-Received: by 10.152.204.7 with SMTP id ku7mr20198006lac.38.1434761437310; Fri, 19 Jun 2015 17:50:37 -0700 (PDT) Received: from wasted.cogentembedded.com (ppp83-237-255-137.pppoe.mtu-net.ru. [83.237.255.137]) by mx.google.com with ESMTPSA id ap8sm2823452lac.4.2015.06.19.17.50.35 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Jun 2015 17:50:36 -0700 (PDT) From: Sergei Shtylyov To: netdev@vger.kernel.org, wg@grandegger.com, mkl@pengutronix.de, linux-can@vger.kernel.org Cc: linux-sh@vger.kernel.org Subject: [PATCH 1/2] rcar_can: print request_irq() error code Date: Sat, 20 Jun 2015 03:50:35 +0300 Message-ID: <1636106.QZXWqHuxCQ@wasted.cogentembedded.com> Organization: Cogent Embedded Inc. User-Agent: KMail/4.14.7 (Linux/4.0.4-202.fc21.x86_64; KDE/4.14.9; x86_64; ; ) In-Reply-To: <1593397.kKIHxKLe5s@wasted.cogentembedded.com> References: <1593397.kKIHxKLe5s@wasted.cogentembedded.com> MIME-Version: 1.0 Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Also print the error code when the request_irq() call fails in rcar_can_open(), rewording the error message... Signed-off-by: Sergei Shtylyov --- drivers/net/can/rcar_can.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in Index: linux-can/drivers/net/can/rcar_can.c =================================================================== --- linux-can.orig/drivers/net/can/rcar_can.c +++ linux-can/drivers/net/can/rcar_can.c @@ -527,7 +527,8 @@ static int rcar_can_open(struct net_devi napi_enable(&priv->napi); err = request_irq(ndev->irq, rcar_can_interrupt, 0, ndev->name, ndev); if (err) { - netdev_err(ndev, "error requesting interrupt %d\n", ndev->irq); + netdev_err(ndev, "request_irq(%d) failed, error %d\n", + ndev->irq, err); goto out_close; } can_led_event(ndev, CAN_LED_EVENT_OPEN);