diff mbox

input: sh_keysc suspend can use to_platform_device()

Message ID 20090311080423.2006.22858.sendpatchset@rx1.opensource.se (mailing list archive)
State Accepted
Headers show

Commit Message

Magnus Damm March 11, 2009, 8:04 a.m. UTC 
From: Magnus Damm <damm@igel.co.jp>

This patch changes sh_keysc to use to_platform_device()
for suspend. Thanks to Trilok Soni for this suggestion.

Signed-off-by: Magnus Damm <damm@igel.co.jp>
---

 drivers/input/keyboard/sh_keysc.c |    7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Trilok Soni March 11, 2009, 8:13 a.m. UTC | #1 
Hi Magnus,

On Wed, Mar 11, 2009 at 1:34 PM, Magnus Damm <magnus.damm@gmail.com> wrote:
> From: Magnus Damm <damm@igel.co.jp>
>
> This patch changes sh_keysc to use to_platform_device()
> for suspend. Thanks to Trilok Soni for this suggestion.
>
> Signed-off-by: Magnus Damm <damm@igel.co.jp>

Thanks.

Reviewed-by: Trilok Soni <soni.trilok@gmail.com>
Paul Mundt March 11, 2009, 8:29 a.m. UTC | #2 
On Wed, Mar 11, 2009 at 05:04:23PM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm@igel.co.jp>
> 
> This patch changes sh_keysc to use to_platform_device()
> for suspend. Thanks to Trilok Soni for this suggestion.
> 
> Signed-off-by: Magnus Damm <damm@igel.co.jp>

Applied on top of the earlier patch, with Trilok's Reviewed-by, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

--- 0001/drivers/input/keyboard/sh_keysc.c
+++ work/drivers/input/keyboard/sh_keysc.c	2009-03-11 13:33:14.000000000 +0900
@@ -257,13 +257,10 @@  static int __devexit sh_keysc_remove(str
 
 static int sh_keysc_suspend(struct device *dev)
 {
-	struct platform_device *pdev;
-	struct sh_keysc_priv *priv;
+	struct platform_device *pdev = to_platform_device(dev);
+	struct sh_keysc_priv *priv = platform_get_drvdata(pdev);
 	unsigned short value;
 
-	pdev = container_of(dev, struct platform_device, dev);
-	priv = platform_get_drvdata(pdev);
-
 	value = ioread16(priv->iomem_base + KYCR1_OFFS);
 
 	if (device_may_wakeup(dev))