| Message ID | 20090827120103.a24e8837.yoshii.takashi@renesas.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Thu, Aug 27, 2009 at 12:01:03PM +0900, yoshii.takashi@renesas.com wrote: > Oh, sorry. > This might be because the board I sent you was a special version. > You (and possibly others who use this version) should revert that commit. > I'm really sorry for inconvenient. > > Paul, are there any good way to support this kind of small differences? > Is it ok to add configuration menu item like below? > Presumably we can figure the version out from the FPGA? If so, we can just figure out which devices to register, and have different devices for different versions. If we can't figure it out from the FPGA, then the next best bet is to use the mach types, the version information can be encoded in a new mach-type, and we can simply have a mach_is_xxx() check for determining the board version and doing the appropriate fixups. We already do this today for some boards (highlander, r2d, etc.). -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- a/arch/sh/boards/Kconfig +++ b/arch/sh/boards/Kconfig @@ -171,6 +171,15 @@ config SH_SH7785LCR_29BIT_PHYSMAPS DIP switch(S2-5). If you set the DIP switch for S2-5 = ON, you can access all on-board device in 29bit address mode. +config SH_SH7785LCR_VERSION + int "SH7785LCR board version" + depends on SH_SH7785LCR + default "1" + help + There are two versions of the boards known. + Set 0 for old, pre mass-product version. + Set 1 for all the other. + config SH_URQUELL bool "Urquell" depends on CPU_SUBTYPE_SH7786