| Message ID | 201108212111.45012.rjw@sisk.pl (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On Sun, Aug 21, 2011 at 09:11:44PM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <rjw@sisk.pl> > > Since sci_port_enable() and sci_port_disable() may be run with > interrupts off and they execute pm_runtime_get_sync() and > pm_runtime_put_sync(), respectively, the SCI device's > power.irq_safe flags has to be used to indicate that it is safe > to execute runtime PM callbacks for this device with interrupts off. > > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl> Not sure how you want this one handled. Did you simply want to roll this in with your other patch with my Acked-by, or should I be taking this through my tree already regardless of the 1/2 patch? -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wednesday, August 24, 2011, Paul Mundt wrote: > On Sun, Aug 21, 2011 at 09:11:44PM +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki <rjw@sisk.pl> > > > > Since sci_port_enable() and sci_port_disable() may be run with > > interrupts off and they execute pm_runtime_get_sync() and > > pm_runtime_put_sync(), respectively, the SCI device's > > power.irq_safe flags has to be used to indicate that it is safe > > to execute runtime PM callbacks for this device with interrupts off. > > > > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl> > > Not sure how you want this one handled. Did you simply want to roll this > in with your other patch with my Acked-by, or should I be taking this > through my tree already regardless of the 1/2 patch? I'd prefer to push it through my tree, if you don't mind. Magnus has already acked it for me, hopefully that's OK? Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Aug 24, 2011 at 10:52:24PM +0200, Rafael J. Wysocki wrote: > On Wednesday, August 24, 2011, Paul Mundt wrote: > > On Sun, Aug 21, 2011 at 09:11:44PM +0200, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki <rjw@sisk.pl> > > > > > > Since sci_port_enable() and sci_port_disable() may be run with > > > interrupts off and they execute pm_runtime_get_sync() and > > > pm_runtime_put_sync(), respectively, the SCI device's > > > power.irq_safe flags has to be used to indicate that it is safe > > > to execute runtime PM callbacks for this device with interrupts off. > > > > > > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl> > > > > Not sure how you want this one handled. Did you simply want to roll this > > in with your other patch with my Acked-by, or should I be taking this > > through my tree already regardless of the 1/2 patch? > > I'd prefer to push it through my tree, if you don't mind. Magnus has > already acked it for me, hopefully that's OK? > Sure, sounds fine to me. I'll just ignore it then. -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Index: linux/drivers/tty/serial/sh-sci.c =================================================================== --- linux.orig/drivers/tty/serial/sh-sci.c +++ linux/drivers/tty/serial/sh-sci.c @@ -1913,6 +1913,7 @@ static int __devinit sci_init_single(str port->dev = &dev->dev; + pm_runtime_irq_safe(&dev->dev); pm_runtime_enable(&dev->dev); }