diff mbox

[v4,1/4] sh-pfc: r8a7778: add USB pin groups

Message ID 201305090312.48346.sergei.shtylyov@cogentembedded.com (mailing list archive)
State Superseded
Commit 34d014fed064eec4afcb9f585f9950cbeb322570
Headers show

Commit Message

Sergei Shtylyov May 8, 2013, 11:12 p.m. UTC 
Add USB0/1 PENC/USB_OVC pin groups to R8A7778 PFC driver.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
Changes from version 3:
- new patch in this series.

 drivers/pinctrl/sh-pfc/pfc-r8a7778.c |   28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Laurent Pinchart May 9, 2013, 10:25 a.m. UTC | #1 
Hi Sergei,

Thank you for the patch.

On Thursday 09 May 2013 03:12:47 Sergei Shtylyov wrote:
> Add USB0/1 PENC/USB_OVC pin groups to R8A7778 PFC driver.
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> Changes from version 3:
> - new patch in this series.
> 
>  drivers/pinctrl/sh-pfc/pfc-r8a7778.c |   28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> Index: renesas/drivers/pinctrl/sh-pfc/pfc-r8a7778.c
> ===================================================================
> --- renesas.orig/drivers/pinctrl/sh-pfc/pfc-r8a7778.c
> +++ renesas/drivers/pinctrl/sh-pfc/pfc-r8a7778.c
> @@ -1501,6 +1501,18 @@ SDHI_PFC_WPPN(sdhi2_wp_a,	SD2_WP_A);
>  SDHI_PFC_PINS(sdhi2_wp_b,	RCAR_GP_PIN(3, 28));
>  SDHI_PFC_WPPN(sdhi2_wp_b,	SD2_WP_B);
> 
> +/* - USB0
> ------------------------------------------------------------------- */
> +SH_PFC_PINS(usb0,		RCAR_GP_PIN(0, 1));
> +SH_PFC_MUX1(usb0,		PENC0);
> +SH_PFC_PINS(usb0_ovc,		RCAR_GP_PIN(0, 3));
> +SH_PFC_MUX1(usb0_ovc,		USB_OVC0);
> +
> +/* - USB1
> ------------------------------------------------------------------- */
> +SH_PFC_PINS(usb1,		RCAR_GP_PIN(0, 2));
> +SH_PFC_MUX1(usb1,		PENC1);
> +SH_PFC_PINS(usb1_ovc,		RCAR_GP_PIN(0, 4));
> +SH_PFC_MUX1(usb1_ovc,		USB_OVC1);
> +
>  static const struct sh_pfc_pin_group pinmux_groups[] = {
>  	SH_PFC_PIN_GROUP(hscif0_data_a),
>  	SH_PFC_PIN_GROUP(hscif0_data_b),
> @@ -1570,6 +1582,10 @@ static const struct sh_pfc_pin_group pin
>  	SH_PFC_PIN_GROUP(sdhi2_data4_b),
>  	SH_PFC_PIN_GROUP(sdhi2_wp_a),
>  	SH_PFC_PIN_GROUP(sdhi2_wp_b),
> +	SH_PFC_PIN_GROUP(usb0),
> +	SH_PFC_PIN_GROUP(usb0_ovc),
> +	SH_PFC_PIN_GROUP(usb1),
> +	SH_PFC_PIN_GROUP(usb1_ovc),
>  };
> 
>  static const char * const hscif0_groups[] = {
> @@ -1677,6 +1693,16 @@ static const char * const sdhi2_groups[]
>  	"sdhi2_wp_b",
>  };
> 
> +static const char * const usb0_groups[] = {
> +	"usb0",
> +	"usb0_ovc",
> +};
> +
> +static const char * const usb1_groups[] = {
> +	"usb1",
> +	"usb1_ovc",
> +};
> +
>  static const struct sh_pfc_function pinmux_functions[] = {
>  	SH_PFC_FUNCTION(hscif0),
>  	SH_PFC_FUNCTION(hscif1),
> @@ -1690,6 +1716,8 @@ static const struct sh_pfc_function pinm
>  	SH_PFC_FUNCTION(sdhi0),
>  	SH_PFC_FUNCTION(sdhi1),
>  	SH_PFC_FUNCTION(sdhi2),
> +	SH_PFC_FUNCTION(usb0),
> +	SH_PFC_FUNCTION(usb1),
>  };
> 
>  static struct pinmux_cfg_reg pinmux_config_regs[] = {
Simon Horman May 10, 2013, 8:09 a.m. UTC | #2 
On Thu, May 09, 2013 at 12:25:12PM +0200, Laurent Pinchart wrote:
> Hi Sergei,
> 
> Thank you for the patch.
> 
> On Thursday 09 May 2013 03:12:47 Sergei Shtylyov wrote:
> > Add USB0/1 PENC/USB_OVC pin groups to R8A7778 PFC driver.
> > 
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Thanks, queued-up for v3.11 in the pinmux branch.
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sergei Shtylyov May 10, 2013, 10:46 a.m. UTC | #3 
Hello.

On 10-05-2013 12:09, Simon Horman wrote:

>>> Add USB0/1 PENC/USB_OVC pin groups to R8A7778 PFC driver.

>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

>> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Thanks, queued-up for v3.11 in the pinmux branch.

    Thank you, but I wonder why not all the series -- it has been fully
ACKed before (while this patch has only been ACKed by Laurent).

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman May 13, 2013, 12:43 a.m. UTC | #4 
On Fri, May 10, 2013 at 02:46:16PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 10-05-2013 12:09, Simon Horman wrote:
> 
> >>>Add USB0/1 PENC/USB_OVC pin groups to R8A7778 PFC driver.
> 
> >>>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> >>Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> >Thanks, queued-up for v3.11 in the pinmux branch.
> 
>    Thank you, but I wonder why not all the series -- it has been fully
> ACKed before (while this patch has only been ACKed by Laurent).

Sorry about that, its just an oversight. I'll pick up the remaining patches.
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Linus Walleij May 20, 2013, 7:30 a.m. UTC | #5 
On Thu, May 9, 2013 at 1:12 AM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:

> Add USB0/1 PENC/USB_OVC pin groups to R8A7778 PFC driver.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> Changes from version 3:
> - new patch in this series.

Acked-by: Linus Walleij <linus.walleij@linaro.org>

Sorry for the backlog, I'm a bit overloaded :-/

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman May 22, 2013, 2:25 p.m. UTC | #6 
On Mon, May 20, 2013 at 09:30:00AM +0200, Linus Walleij wrote:
> On Thu, May 9, 2013 at 1:12 AM, Sergei Shtylyov
> <sergei.shtylyov@cogentembedded.com> wrote:
> 
> > Add USB0/1 PENC/USB_OVC pin groups to R8A7778 PFC driver.
> >
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> >
> > ---
> > Changes from version 3:
> > - new patch in this series.
> 
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> 
> Sorry for the backlog, I'm a bit overloaded :-/

Sergei, shall I queue this up in the pinmux branch?
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman May 22, 2013, 2:27 p.m. UTC | #7 
On Wed, May 22, 2013 at 11:25:55PM +0900, Simon Horman wrote:
> On Mon, May 20, 2013 at 09:30:00AM +0200, Linus Walleij wrote:
> > On Thu, May 9, 2013 at 1:12 AM, Sergei Shtylyov
> > <sergei.shtylyov@cogentembedded.com> wrote:
> > 
> > > Add USB0/1 PENC/USB_OVC pin groups to R8A7778 PFC driver.
> > >
> > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> > >
> > > ---
> > > Changes from version 3:
> > > - new patch in this series.
> > 
> > Acked-by: Linus Walleij <linus.walleij@linaro.org>
> > 
> > Sorry for the backlog, I'm a bit overloaded :-/
> 
> Sergei, shall I queue this up in the pinmux branch?

Scratch that, it is already there.

I will update the pinmux branch to include Linus's ack.
I intend to do a push to kernel.org tomorrow.
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sergei Shtylyov May 22, 2013, 2:44 p.m. UTC | #8 
On 22-05-2013 18:25, Simon Horman wrote:

>>> Add USB0/1 PENC/USB_OVC pin groups to R8A7778 PFC driver.

>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

>>> ---
>>> Changes from version 3:
>>> - new patch in this series.

>> Acked-by: Linus Walleij <linus.walleij@linaro.org>

>> Sorry for the backlog, I'm a bit overloaded :-/

> Sergei, shall I queue this up in the pinmux branch?

    You forgot -- you already queued it 12 days ago. :-)

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman May 22, 2013, 2:58 p.m. UTC | #9 
On Wed, May 22, 2013 at 06:44:42PM +0400, Sergei Shtylyov wrote:
> On 22-05-2013 18:25, Simon Horman wrote:
> 
> >>>Add USB0/1 PENC/USB_OVC pin groups to R8A7778 PFC driver.
> 
> >>>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> >>>---
> >>>Changes from version 3:
> >>>- new patch in this series.
> 
> >>Acked-by: Linus Walleij <linus.walleij@linaro.org>
> 
> >>Sorry for the backlog, I'm a bit overloaded :-/
> 
> >Sergei, shall I queue this up in the pinmux branch?
> 
>    You forgot -- you already queued it 12 days ago. :-)

Indeed. I seem to have a very short memory.
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

Index: renesas/drivers/pinctrl/sh-pfc/pfc-r8a7778.c
===================================================================
--- renesas.orig/drivers/pinctrl/sh-pfc/pfc-r8a7778.c
+++ renesas/drivers/pinctrl/sh-pfc/pfc-r8a7778.c
@@ -1501,6 +1501,18 @@  SDHI_PFC_WPPN(sdhi2_wp_a,	SD2_WP_A);
 SDHI_PFC_PINS(sdhi2_wp_b,	RCAR_GP_PIN(3, 28));
 SDHI_PFC_WPPN(sdhi2_wp_b,	SD2_WP_B);
 
+/* - USB0 ------------------------------------------------------------------- */
+SH_PFC_PINS(usb0,		RCAR_GP_PIN(0, 1));
+SH_PFC_MUX1(usb0,		PENC0);
+SH_PFC_PINS(usb0_ovc,		RCAR_GP_PIN(0, 3));
+SH_PFC_MUX1(usb0_ovc,		USB_OVC0);
+
+/* - USB1 ------------------------------------------------------------------- */
+SH_PFC_PINS(usb1,		RCAR_GP_PIN(0, 2));
+SH_PFC_MUX1(usb1,		PENC1);
+SH_PFC_PINS(usb1_ovc,		RCAR_GP_PIN(0, 4));
+SH_PFC_MUX1(usb1_ovc,		USB_OVC1);
+
 static const struct sh_pfc_pin_group pinmux_groups[] = {
 	SH_PFC_PIN_GROUP(hscif0_data_a),
 	SH_PFC_PIN_GROUP(hscif0_data_b),
@@ -1570,6 +1582,10 @@  static const struct sh_pfc_pin_group pin
 	SH_PFC_PIN_GROUP(sdhi2_data4_b),
 	SH_PFC_PIN_GROUP(sdhi2_wp_a),
 	SH_PFC_PIN_GROUP(sdhi2_wp_b),
+	SH_PFC_PIN_GROUP(usb0),
+	SH_PFC_PIN_GROUP(usb0_ovc),
+	SH_PFC_PIN_GROUP(usb1),
+	SH_PFC_PIN_GROUP(usb1_ovc),
 };
 
 static const char * const hscif0_groups[] = {
@@ -1677,6 +1693,16 @@  static const char * const sdhi2_groups[]
 	"sdhi2_wp_b",
 };
 
+static const char * const usb0_groups[] = {
+	"usb0",
+	"usb0_ovc",
+};
+
+static const char * const usb1_groups[] = {
+	"usb1",
+	"usb1_ovc",
+};
+
 static const struct sh_pfc_function pinmux_functions[] = {
 	SH_PFC_FUNCTION(hscif0),
 	SH_PFC_FUNCTION(hscif1),
@@ -1690,6 +1716,8 @@  static const struct sh_pfc_function pinm
 	SH_PFC_FUNCTION(sdhi0),
 	SH_PFC_FUNCTION(sdhi1),
 	SH_PFC_FUNCTION(sdhi2),
+	SH_PFC_FUNCTION(usb0),
+	SH_PFC_FUNCTION(usb1),
 };
 
 static struct pinmux_cfg_reg pinmux_config_regs[] = {