diff mbox

[1/2] ARM: shmobile: r8a7779: add HPB-DMAC support

Message ID 201308090142.08148.sergei.shtylyov@cogentembedded.com (mailing list archive)
State Superseded
Headers show

Commit Message

Sergei Shtylyov Aug. 8, 2013, 9:42 p.m. UTC
From: Max Filippov <max.filippov@cogentembedded.com>

Add HPB-DMAC platform device on R8A7779 SoC along with its slave and channel
configurations.

Signed-off-by: Max Filippov <max.filippov@cogentembedded.com>
[Sergei: moved *enum* declaring HPB-DMAC slave IDs from now removed <mach/dma.h>
to <mach/r8a7779.h>, removed #include <mach/dma.h> from setup-r8a7779.c, removed
SSI-related *enum* values and SSI-related data from hpb_dmae_slaves[] and
hpb_dmae_channels[], added ASYNCMDR.ASBTMD20 and ASYNCMDR.ASMD20 fields/values,
fixed comments to ASYNCMDR.ASBTMD2[123]  and ASYNCMDR.ASMD2[123] fields/values,
moved comments after the element initializers of hpb_dmae_channels[].]
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
 arch/arm/mach-shmobile/include/mach/r8a7779.h |    7 +
 arch/arm/mach-shmobile/setup-r8a7779.c        |  132 ++++++++++++++++++++++++++
 2 files changed, 139 insertions(+)

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Kuninori Morimoto Aug. 9, 2013, 1:33 a.m. UTC | #1
Hi

> From: Max Filippov <max.filippov@cogentembedded.com>
> 
> Add HPB-DMAC platform device on R8A7779 SoC along with its slave and channel
> configurations.
> 
> Signed-off-by: Max Filippov <max.filippov@cogentembedded.com>
> [Sergei: moved *enum* declaring HPB-DMAC slave IDs from now removed <mach/dma.h>
> to <mach/r8a7779.h>, removed #include <mach/dma.h> from setup-r8a7779.c, removed
> SSI-related *enum* values and SSI-related data from hpb_dmae_slaves[] and
> hpb_dmae_channels[], added ASYNCMDR.ASBTMD20 and ASYNCMDR.ASMD20 fields/values,
> fixed comments to ASYNCMDR.ASBTMD2[123]  and ASYNCMDR.ASMD2[123] fields/values,
> moved comments after the element initializers of hpb_dmae_channels[].]
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
(snip)
> +/* HPB-DMA */
> +
> +/* Asynchronous mode register bits */
> +#define	ASYNCMDR_ASMD41_MASK		BIT(19)	/* SDHI3 */
> +#define	ASYNCMDR_ASMD41_SINGLE		BIT(19)	/* SDHI3 */
> +#define	ASYNCMDR_ASMD41_MULTI		0	/* SDHI3 */
> +#define	ASYNCMDR_ASBTMD41_MASK		BIT(18)	/* SDHI3 */
> +#define	ASYNCMDR_ASBTMD41_BURST		BIT(18)	/* SDHI3 */
> +#define	ASYNCMDR_ASBTMD41_NBURST	0	/* SDHI3 */
> +#define	ASYNCMDR_ASMD40_MASK		BIT(17)	/* SDHI3 */
> +#define	ASYNCMDR_ASMD40_SINGLE		BIT(17)	/* SDHI3 */
> +#define	ASYNCMDR_ASMD40_MULTI		0	/* SDHI3 */
> +#define	ASYNCMDR_ASBTMD40_MASK		BIT(16)	/* SDHI3 */
> +#define	ASYNCMDR_ASBTMD40_BURST		BIT(16)	/* SDHI3 */
> +#define	ASYNCMDR_ASBTMD40_NBURST	0	/* SDHI3 */
> +#define	ASYNCMDR_ASMD39_MASK		BIT(15)	/* SDHI3 */
> +#define	ASYNCMDR_ASMD39_SINGLE		BIT(15)	/* SDHI3 */
> +#define	ASYNCMDR_ASMD39_MULTI		0	/* SDHI3 */
> +#define	ASYNCMDR_ASBTMD39_MASK		BIT(14)	/* SDHI3 */
> +#define	ASYNCMDR_ASBTMD39_BURST		BIT(14)	/* SDHI3 */
> +#define	ASYNCMDR_ASBTMD39_NBURST	0	/* SDHI3 */
> +#define	ASYNCMDR_ASMD27_MASK		BIT(13)	/* SDHI2 */
> +#define	ASYNCMDR_ASMD27_SINGLE		BIT(13)	/* SDHI2 */
> +#define	ASYNCMDR_ASMD27_MULTI		0	/* SDHI2 */
> +#define	ASYNCMDR_ASBTMD27_MASK		BIT(12)	/* SDHI2 */
> +#define	ASYNCMDR_ASBTMD27_BURST		BIT(12)	/* SDHI2 */
> +#define	ASYNCMDR_ASBTMD27_NBURST	0	/* SDHI2 */
> +#define	ASYNCMDR_ASMD26_MASK		BIT(11)	/* SDHI2 */
> +#define	ASYNCMDR_ASMD26_SINGLE		BIT(11)	/* SDHI2 */
> +#define	ASYNCMDR_ASMD26_MULTI		0	/* SDHI2 */
> +#define	ASYNCMDR_ASBTMD26_MASK		BIT(10)	/* SDHI2 */
> +#define	ASYNCMDR_ASBTMD26_BURST		BIT(10)	/* SDHI2 */
> +#define	ASYNCMDR_ASBTMD26_NBURST	0	/* SDHI2 */
> +#define	ASYNCMDR_ASMD25_MASK		BIT(9)	/* SDHI2 */
> +#define	ASYNCMDR_ASMD25_SINGLE		BIT(9)	/* SDHI2 */
> +#define	ASYNCMDR_ASMD25_MULTI		0	/* SDHI2 */
> +#define	ASYNCMDR_ASBTMD25_MASK		BIT(8)	/* SDHI2 */
> +#define	ASYNCMDR_ASBTMD25_BURST		BIT(8)	/* SDHI2 */
> +#define	ASYNCMDR_ASBTMD25_NBURST	0	/* SDHI2 */
> +#define	ASYNCMDR_ASMD23_MASK		BIT(7)	/* SDHI0 */
> +#define	ASYNCMDR_ASMD23_SINGLE		BIT(7)	/* SDHI0 */
> +#define	ASYNCMDR_ASMD23_MULTI		0	/* SDHI0 */
> +#define	ASYNCMDR_ASBTMD23_MASK		BIT(6)	/* SDHI0 */
> +#define	ASYNCMDR_ASBTMD23_BURST		BIT(6)	/* SDHI0 */
> +#define	ASYNCMDR_ASBTMD23_NBURST	0	/* SDHI0 */
> +#define	ASYNCMDR_ASMD22_MASK		BIT(5)	/* SDHI0 */
> +#define	ASYNCMDR_ASMD22_SINGLE		BIT(5)	/* SDHI0 */
> +#define	ASYNCMDR_ASMD22_MULTI		0	/* SDHI0 */
> +#define	ASYNCMDR_ASBTMD22_MASK		BIT(4)	/* SDHI0 */
> +#define	ASYNCMDR_ASBTMD22_BURST		BIT(4)	/* SDHI0 */
> +#define	ASYNCMDR_ASBTMD22_NBURST	0	/* SDHI0 */
> +#define	ASYNCMDR_ASMD21_MASK		BIT(3)	/* SDHI0 */
> +#define	ASYNCMDR_ASMD21_SINGLE		BIT(3)	/* SDHI0 */
> +#define	ASYNCMDR_ASMD21_MULTI		0	/* SDHI0 */
> +#define	ASYNCMDR_ASBTMD21_MASK		BIT(2)	/* SDHI0 */
> +#define	ASYNCMDR_ASBTMD21_BURST		BIT(2)	/* SDHI0 */
> +#define	ASYNCMDR_ASBTMD21_NBURST	0	/* SDHI0 */
> +#define	ASYNCMDR_ASMD20_MASK		BIT(1)	/* SDHI1 */
> +#define	ASYNCMDR_ASMD20_SINGLE		BIT(1)	/* SDHI1 */
> +#define	ASYNCMDR_ASMD20_MULTI		0	/* SDHI1 */
> +#define	ASYNCMDR_ASBTMD20_MASK		BIT(0)	/* SDHI1 */
> +#define	ASYNCMDR_ASBTMD20_BURST		BIT(0)	/* SDHI1 */
> +#define	ASYNCMDR_ASBTMD20_NBURST	0	/* SDHI1 */

Your "r8a7778"'s HPB-DMAC patch had "used" ASYNCMDR_xxx only,
and here, r8a7779 seems have "all" ASYNCMDR_xxx.
I don't care about it,
but, above "all" settings seems doesn't have 
channel 43 (= 23/22 bit) and channel 24 (= 21/20 bit).

Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

Index: renesas/arch/arm/mach-shmobile/include/mach/r8a7779.h
===================================================================
--- renesas.orig/arch/arm/mach-shmobile/include/mach/r8a7779.h
+++ renesas/arch/arm/mach-shmobile/include/mach/r8a7779.h
@@ -5,6 +5,13 @@ 
 #include <linux/pm_domain.h>
 #include <linux/sh_eth.h>
 
+/* HPB-DMA slave IDs */
+enum {
+	HPBDMA_SLAVE_DUMMY,
+	HPBDMA_SLAVE_SDHI0_TX,
+	HPBDMA_SLAVE_SDHI0_RX,
+};
+
 struct platform_device;
 
 struct r8a7779_pm_ch {
Index: renesas/arch/arm/mach-shmobile/setup-r8a7779.c
===================================================================
--- renesas.orig/arch/arm/mach-shmobile/setup-r8a7779.c
+++ renesas/arch/arm/mach-shmobile/setup-r8a7779.c
@@ -25,6 +25,7 @@ 
 #include <linux/irqchip.h>
 #include <linux/irqchip/arm-gic.h>
 #include <linux/of_platform.h>
+#include <linux/platform_data/dma-rcar-hpbdma.h>
 #include <linux/platform_data/gpio-rcar.h>
 #include <linux/platform_data/irq-renesas-intc-irqpin.h>
 #include <linux/platform_device.h>
@@ -605,6 +606,136 @@  static struct resource ether_resources[]
 	},
 };
 
+/* HPB-DMA */
+
+/* Asynchronous mode register bits */
+#define	ASYNCMDR_ASMD41_MASK		BIT(19)	/* SDHI3 */
+#define	ASYNCMDR_ASMD41_SINGLE		BIT(19)	/* SDHI3 */
+#define	ASYNCMDR_ASMD41_MULTI		0	/* SDHI3 */
+#define	ASYNCMDR_ASBTMD41_MASK		BIT(18)	/* SDHI3 */
+#define	ASYNCMDR_ASBTMD41_BURST		BIT(18)	/* SDHI3 */
+#define	ASYNCMDR_ASBTMD41_NBURST	0	/* SDHI3 */
+#define	ASYNCMDR_ASMD40_MASK		BIT(17)	/* SDHI3 */
+#define	ASYNCMDR_ASMD40_SINGLE		BIT(17)	/* SDHI3 */
+#define	ASYNCMDR_ASMD40_MULTI		0	/* SDHI3 */
+#define	ASYNCMDR_ASBTMD40_MASK		BIT(16)	/* SDHI3 */
+#define	ASYNCMDR_ASBTMD40_BURST		BIT(16)	/* SDHI3 */
+#define	ASYNCMDR_ASBTMD40_NBURST	0	/* SDHI3 */
+#define	ASYNCMDR_ASMD39_MASK		BIT(15)	/* SDHI3 */
+#define	ASYNCMDR_ASMD39_SINGLE		BIT(15)	/* SDHI3 */
+#define	ASYNCMDR_ASMD39_MULTI		0	/* SDHI3 */
+#define	ASYNCMDR_ASBTMD39_MASK		BIT(14)	/* SDHI3 */
+#define	ASYNCMDR_ASBTMD39_BURST		BIT(14)	/* SDHI3 */
+#define	ASYNCMDR_ASBTMD39_NBURST	0	/* SDHI3 */
+#define	ASYNCMDR_ASMD27_MASK		BIT(13)	/* SDHI2 */
+#define	ASYNCMDR_ASMD27_SINGLE		BIT(13)	/* SDHI2 */
+#define	ASYNCMDR_ASMD27_MULTI		0	/* SDHI2 */
+#define	ASYNCMDR_ASBTMD27_MASK		BIT(12)	/* SDHI2 */
+#define	ASYNCMDR_ASBTMD27_BURST		BIT(12)	/* SDHI2 */
+#define	ASYNCMDR_ASBTMD27_NBURST	0	/* SDHI2 */
+#define	ASYNCMDR_ASMD26_MASK		BIT(11)	/* SDHI2 */
+#define	ASYNCMDR_ASMD26_SINGLE		BIT(11)	/* SDHI2 */
+#define	ASYNCMDR_ASMD26_MULTI		0	/* SDHI2 */
+#define	ASYNCMDR_ASBTMD26_MASK		BIT(10)	/* SDHI2 */
+#define	ASYNCMDR_ASBTMD26_BURST		BIT(10)	/* SDHI2 */
+#define	ASYNCMDR_ASBTMD26_NBURST	0	/* SDHI2 */
+#define	ASYNCMDR_ASMD25_MASK		BIT(9)	/* SDHI2 */
+#define	ASYNCMDR_ASMD25_SINGLE		BIT(9)	/* SDHI2 */
+#define	ASYNCMDR_ASMD25_MULTI		0	/* SDHI2 */
+#define	ASYNCMDR_ASBTMD25_MASK		BIT(8)	/* SDHI2 */
+#define	ASYNCMDR_ASBTMD25_BURST		BIT(8)	/* SDHI2 */
+#define	ASYNCMDR_ASBTMD25_NBURST	0	/* SDHI2 */
+#define	ASYNCMDR_ASMD23_MASK		BIT(7)	/* SDHI0 */
+#define	ASYNCMDR_ASMD23_SINGLE		BIT(7)	/* SDHI0 */
+#define	ASYNCMDR_ASMD23_MULTI		0	/* SDHI0 */
+#define	ASYNCMDR_ASBTMD23_MASK		BIT(6)	/* SDHI0 */
+#define	ASYNCMDR_ASBTMD23_BURST		BIT(6)	/* SDHI0 */
+#define	ASYNCMDR_ASBTMD23_NBURST	0	/* SDHI0 */
+#define	ASYNCMDR_ASMD22_MASK		BIT(5)	/* SDHI0 */
+#define	ASYNCMDR_ASMD22_SINGLE		BIT(5)	/* SDHI0 */
+#define	ASYNCMDR_ASMD22_MULTI		0	/* SDHI0 */
+#define	ASYNCMDR_ASBTMD22_MASK		BIT(4)	/* SDHI0 */
+#define	ASYNCMDR_ASBTMD22_BURST		BIT(4)	/* SDHI0 */
+#define	ASYNCMDR_ASBTMD22_NBURST	0	/* SDHI0 */
+#define	ASYNCMDR_ASMD21_MASK		BIT(3)	/* SDHI0 */
+#define	ASYNCMDR_ASMD21_SINGLE		BIT(3)	/* SDHI0 */
+#define	ASYNCMDR_ASMD21_MULTI		0	/* SDHI0 */
+#define	ASYNCMDR_ASBTMD21_MASK		BIT(2)	/* SDHI0 */
+#define	ASYNCMDR_ASBTMD21_BURST		BIT(2)	/* SDHI0 */
+#define	ASYNCMDR_ASBTMD21_NBURST	0	/* SDHI0 */
+#define	ASYNCMDR_ASMD20_MASK		BIT(1)	/* SDHI1 */
+#define	ASYNCMDR_ASMD20_SINGLE		BIT(1)	/* SDHI1 */
+#define	ASYNCMDR_ASMD20_MULTI		0	/* SDHI1 */
+#define	ASYNCMDR_ASBTMD20_MASK		BIT(0)	/* SDHI1 */
+#define	ASYNCMDR_ASBTMD20_BURST		BIT(0)	/* SDHI1 */
+#define	ASYNCMDR_ASBTMD20_NBURST	0	/* SDHI1 */
+
+static const struct hpb_dmae_slave_config hpb_dmae_slaves[] = {
+	{
+		.id	= HPBDMA_SLAVE_SDHI0_TX,
+		.addr	= 0xffe4c000 + 0x30,
+		.dcr	= DCR_SPDS_16BIT | DCR_DMDL | DCR_DPDS_16BIT,
+		.rstr	= ASYNCRSTR_ASRST21 | ASYNCRSTR_ASRST22 |
+			  ASYNCRSTR_ASRST23,
+		.mdr	= ASYNCMDR_ASMD21_SINGLE | ASYNCMDR_ASBTMD21_NBURST,
+		.mdm	= ASYNCMDR_ASMD21_MASK | ASYNCMDR_ASBTMD21_MASK,
+		.port	= 0x0D0C,
+		.flags	= HPB_DMAE_SET_ASYNC_RESET | HPB_DMAE_SET_ASYNC_MODE,
+		.dma_ch	= 21,
+	}, {
+		.id	= HPBDMA_SLAVE_SDHI0_RX,
+		.addr	= 0xffe4c000 + 0x30,
+		.dcr	= DCR_SMDL | DCR_SPDS_16BIT | DCR_DPDS_16BIT,
+		.rstr	= ASYNCRSTR_ASRST21 | ASYNCRSTR_ASRST22 |
+			  ASYNCRSTR_ASRST23,
+		.mdr	= ASYNCMDR_ASMD22_SINGLE | ASYNCMDR_ASBTMD22_NBURST,
+		.mdm	= ASYNCMDR_ASMD22_MASK | ASYNCMDR_ASBTMD22_MASK,
+		.port	= 0x0D0C,
+		.flags	= HPB_DMAE_SET_ASYNC_RESET | HPB_DMAE_SET_ASYNC_MODE,
+		.dma_ch	= 22,
+	},
+};
+
+static const struct hpb_dmae_channel hpb_dmae_channels[] = {
+	HPB_DMAE_CHANNEL(0x93, HPBDMA_SLAVE_SDHI0_TX), /* ch. 21 */
+	HPB_DMAE_CHANNEL(0x93, HPBDMA_SLAVE_SDHI0_RX), /* ch. 22 */
+};
+
+static struct hpb_dmae_pdata dma_platform_data __initdata = {
+	.slaves			= hpb_dmae_slaves,
+	.num_slaves		= ARRAY_SIZE(hpb_dmae_slaves),
+	.channels		= hpb_dmae_channels,
+	.num_channels		= ARRAY_SIZE(hpb_dmae_channels),
+	.ts_shift		= {
+		[XMIT_SZ_8BIT]	= 0,
+		[XMIT_SZ_16BIT]	= 1,
+		[XMIT_SZ_32BIT]	= 2,
+	},
+	.num_hw_channels	= 44,
+};
+
+static struct resource hpb_dmae_resources[] __initdata = {
+	/* Channel registers */
+	DEFINE_RES_MEM(0xffc08000, 0x1000),
+	/* Common registers */
+	DEFINE_RES_MEM(0xffc09000, 0x170),
+	/* Asynchronous reset registers */
+	DEFINE_RES_MEM(0xffc00300, 4),
+	/* Asynchronous mode registers */
+	DEFINE_RES_MEM(0xffc00400, 4),
+	/* IRQ for DMA channels */
+	DEFINE_RES_NAMED(gic_iid(0x8e), 12, NULL, IORESOURCE_IRQ),
+};
+
+static void __init r8a7779_register_hpb_dmae(void)
+{
+	platform_device_register_resndata(&platform_bus, "hpb-dma-engine", -1,
+					  hpb_dmae_resources,
+					  ARRAY_SIZE(hpb_dmae_resources),
+					  &dma_platform_data,
+					  sizeof(dma_platform_data));
+}
+
 static struct platform_device *r8a7779_devices_dt[] __initdata = {
 	&scif0_device,
 	&scif1_device,
@@ -638,6 +769,7 @@  void __init r8a7779_add_standard_devices
 			    ARRAY_SIZE(r8a7779_devices_dt));
 	platform_add_devices(r8a7779_standard_devices,
 			    ARRAY_SIZE(r8a7779_standard_devices));
+	r8a7779_register_hpb_dmae();
 }
 
 void __init r8a7779_add_ether_device(struct sh_eth_plat_data *pdata)