From patchwork Tue Dec 17 21:04:03 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 3365931 X-Patchwork-Delegate: lethal@linux-sh.org Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 1231A9F314 for ; Tue, 17 Dec 2013 21:04:10 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3C97A20394 for ; Tue, 17 Dec 2013 21:04:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0FD6420364 for ; Tue, 17 Dec 2013 21:04:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753062Ab3LQVEH (ORCPT ); Tue, 17 Dec 2013 16:04:07 -0500 Received: from sauhun.de ([89.238.76.85]:47278 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752963Ab3LQVEG (ORCPT ); Tue, 17 Dec 2013 16:04:06 -0500 Received: from p4fe24b4c.dip0.t-ipconnect.de ([79.226.75.76]:44303 helo=localhost) by pokefinder.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.69) (envelope-from ) id 1Vt1oB-0002gW-Of; Tue, 17 Dec 2013 22:04:03 +0100 Date: Tue, 17 Dec 2013 22:04:03 +0100 From: Wolfram Sang To: Magnus Damm Cc: linux-kernel@vger.kernel.org, linus.walleij@linaro.org, linux-sh@vger.kernel.org, horms@verge.net.au, laurent.pinchart@ideasonboard.com Subject: Re: [PATCH 02/05 v2] pinctrl: sh-pfc: r7s72100 base support Message-ID: <20131217210403.GA1196@katana> References: <20131217023745.24573.3660.sendpatchset@w520> <20131217023804.24573.82351.sendpatchset@w520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20131217023804.24573.82351.sendpatchset@w520> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_TVD_MIME_EPI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, > +#define _P_DATA(bank, pin, name, sfx) \ > + PINMUX_DATA(name##_DATA, name##_PMC_0, name##_PIPC_0, \ > + name##_PIBC_1, name##_PBDC_1) > + > +#define _P_FN(n, fn, pfcae, pfce, pfc) \ > + PINMUX_DATA(n##_MARK_FN##fn, n##_PMC_1, n##_PIPC_1, \ > + n##_PFCAE_##pfcae, n##_PFCE_##pfce, n##_PFC_##pfc) I need to apply this patch, otherwise my i2c pinmuxing fails? diff --git a/drivers/pinctrl/sh-pfc/pfc-r7s72100.c b/drivers/pinctrl/sh-pfc/pfc-r7s72100.c index 4acdaae..2b716d1 100644 --- a/drivers/pinctrl/sh-pfc/pfc-r7s72100.c +++ b/drivers/pinctrl/sh-pfc/pfc-r7s72100.c @@ -68,11 +68,11 @@ enum { #define _P_GPIO(bank, _pin, _name, sfx) _GP_GPIO(16, bank, _pin, _name, sfx) #define _P_DATA(bank, pin, name, sfx) \ - PINMUX_DATA(name##_DATA, name##_PMC_0, name##_PIPC_0, \ + PINMUX_DATA(name##_DATA, name##_PMC_0, \ name##_PIBC_1, name##_PBDC_1) #define _P_FN(n, fn, pfcae, pfce, pfc) \ - PINMUX_DATA(n##_MARK_FN##fn, n##_PMC_1, n##_PIPC_1, \ + PINMUX_DATA(n##_MARK_FN##fn, n##_PMC_1, \ n##_PFCAE_##pfcae, n##_PFCE_##pfce, n##_PFC_##pfc) #define _P_MARK_FN1(bank, pin, name, sfx) _P_FN(name, 1, 0, 0, 0)