From patchwork Tue Dec 17 21:47:34 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 3366181 Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id B7B20C0D4A for ; Tue, 17 Dec 2013 21:47:38 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9F4D720382 for ; Tue, 17 Dec 2013 21:47:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 990262035E for ; Tue, 17 Dec 2013 21:47:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753862Ab3LQVrg (ORCPT ); Tue, 17 Dec 2013 16:47:36 -0500 Received: from sauhun.de ([89.238.76.85]:55084 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753858Ab3LQVrf (ORCPT ); Tue, 17 Dec 2013 16:47:35 -0500 Received: from p4fe24b4c.dip0.t-ipconnect.de ([79.226.75.76]:44334 helo=localhost) by pokefinder.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.69) (envelope-from ) id 1Vt2UI-0002nd-CN; Tue, 17 Dec 2013 22:47:34 +0100 Date: Tue, 17 Dec 2013 22:47:34 +0100 From: Wolfram Sang To: linux-sh@vger.kernel.org Cc: linux-i2c@vger.kernel.org, Magnus Damm , Laurent Pinchart , Simon Horman , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/5] pinctrl: r7s72100: add riic groups Message-ID: <20131217214734.GC1196@katana> References: <1387316678-10174-1-git-send-email-wsa@the-dreams.de> <1387316678-10174-2-git-send-email-wsa@the-dreams.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1387316678-10174-2-git-send-email-wsa@the-dreams.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_TVD_MIME_EPI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, Dec 17, 2013 at 10:44:34PM +0100, Wolfram Sang wrote: > From: Wolfram Sang > > Tested RIIC2 on a genmai board. Other riic groups are untested but seem > trivial enough to be added. > > Signed-off-by: Wolfram Sang > Acked-by: Magnus Damm > --- > > Note: With the current PFC driver as posted by Magnus, it needs another patch > to work. Yet, I think this is a seperate PFC issue which needs to be sorted out > seperately and shouldn't affect these declarations. I'll add the needed patch > as a response to this mail. Here it goes... From: Wolfram Sang Subject: [PATCH] HACK: make magnus new driver work Signed-off-by: Wolfram Sang --- drivers/pinctrl/sh-pfc/pfc-r7s72100.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/sh-pfc/pfc-r7s72100.c b/drivers/pinctrl/sh-pfc/pfc-r7s72100.c index 00f67e8..a662876 100644 --- a/drivers/pinctrl/sh-pfc/pfc-r7s72100.c +++ b/drivers/pinctrl/sh-pfc/pfc-r7s72100.c @@ -68,11 +68,11 @@ enum { #define _P_GPIO(bank, _pin, _name, sfx) _GP_GPIO(16, bank, _pin, _name, sfx) #define _P_DATA(bank, pin, name, sfx) \ - PINMUX_DATA(name##_DATA, name##_PMC_0, name##_PIPC_0, \ + PINMUX_DATA(name##_DATA, name##_PMC_0, \ name##_PIBC_1, name##_PBDC_1) #define _P_FN(n, fn, pfcae, pfce, pfc) \ - PINMUX_DATA(n##_MARK_FN##fn, n##_PMC_1, n##_PIPC_1, \ + PINMUX_DATA(n##_MARK_FN##fn, n##_PMC_1, \ n##_PFCAE_##pfcae, n##_PFCE_##pfce, n##_PFC_##pfc) #define _P_MARK_FN1(bank, pin, name, sfx) _P_FN(name, 1, 0, 0, 0)