From patchwork Sun Jul 12 22:02:02 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 6773341 Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 1D47EC05AC for ; Sun, 12 Jul 2015 22:02:51 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4516920619 for ; Sun, 12 Jul 2015 22:02:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6ECFF204FC for ; Sun, 12 Jul 2015 22:02:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752066AbbGLWCK (ORCPT ); Sun, 12 Jul 2015 18:02:10 -0400 Received: from mail-ie0-f170.google.com ([209.85.223.170]:34245 "EHLO mail-ie0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752060AbbGLWCG (ORCPT ); Sun, 12 Jul 2015 18:02:06 -0400 Received: by iebmu5 with SMTP id mu5so223557303ieb.1 for ; Sun, 12 Jul 2015 15:02:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=subject:to:from:cc:date:message-id:in-reply-to:references :user-agent:mime-version:content-type:content-transfer-encoding; bh=HUOzm81gXDUFMUCVjOKlh//uL1flnRxJxETARgOFxb0=; b=iQS6rQ90G5X7KEj2pvi1IiHXhLGdaAkJ+iOd29EirJ+64WQWxidiH+dSZpq67m53xz HadszXnFysIn+y6bxcc2pYMTzppEpSmT52yi2ie7xJrYP3BDEikw5UAKUxkCjqDscDLV KAXI5AweacDfsGEAIQRxB2+xj1RDbAUiP5VPRwFwEh+r71EBTzHH/2Yp6wMhWUQ21k0M EWU124+KC566v1lOJeaHGxtocXuo72/4AQ11aaL4UlfpatZBc9M1KM8FJu4+IXECRUFf 3PdlvcViGR6toZXB0SJJpFXtn4tKWmr3adAVgpZMIPwcIbwXoTLCs+1s2cN0369KpdiS mPkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:from:cc:date:message-id:in-reply-to :references:user-agent:mime-version:content-type :content-transfer-encoding; bh=HUOzm81gXDUFMUCVjOKlh//uL1flnRxJxETARgOFxb0=; b=cg/xwq1qRdGIT2bvawB1rwNMaC54AREhZzVwJ56Zlm9nudVcFhehRNqeTz6LZALM+X /iGJw0b+uc83Ps2YmnYJGLNrP8zrDjOmtiB64Y0QHBsVsRRHmb0L03cKD/iLSXTkgw8N i4TEHy/8zI1C9HJ7lVzUpHvO37oMHOY0bRFt66Tqb/myqJ4mFso4Gf7JMtyYAInaazMq WbMml8jj/6oGh1L18QgEJmq+2yjWsxCUwsBy2VhP/CsNpdpOuUm1BxJHT/m+Quh7k3Z3 97wUkAxaf5LCneodtkq1TmOHEKHft0vs1Z+Ry8niPdewMhtZ8gbl4GVP0WMmYc3Kpi/S 8NuQ== X-Gm-Message-State: ALoCoQmXbs1ncRC/iovHRBI9RIC2s0v9zQQCbgNyyNKJyJ+2Klr1b+1G2rETAuiSL8RUrNydLvmA X-Received: by 10.107.166.136 with SMTP id p130mr17625202ioe.163.1436738526001; Sun, 12 Jul 2015 15:02:06 -0700 (PDT) Received: from localhost ([69.71.1.1]) by smtp.gmail.com with ESMTPSA id b140sm11286613ioe.9.2015.07.12.15.02.04 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 12 Jul 2015 15:02:04 -0700 (PDT) Subject: [PATCH 2/3] x86, irq: Clarify "No irq handler" message To: Thomas Gleixner From: Bjorn Helgaas Cc: linux-arch@vger.kernel.org, linux-mips@linux-mips.org, linux-am33-list@redhat.com, linux-ia64@vger.kernel.org, linux-c6x-dev@linux-c6x.org, linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, adi-buildroot-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-alpha@vger.kernel.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org Date: Sun, 12 Jul 2015 17:02:02 -0500 Message-ID: <20150712220202.7166.22099.stgit@bhelgaas-glaptop2.roam.corp.google.com> In-Reply-To: <20150712215559.7166.33068.stgit@bhelgaas-glaptop2.roam.corp.google.com> References: <20150712215559.7166.33068.stgit@bhelgaas-glaptop2.roam.corp.google.com> User-Agent: StGit/0.16 MIME-Version: 1.0 Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, SUSPICIOUS_RECIPS, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Previously we printed, e.g., do_IRQ: 0.242 No irq handler for vector (irq -1) There's no clue about what "0.242" means, and the IRQ number, which is the important generic information used by drivers and /proc/interrupts, is almost an afterthought. Change the format to this: No handler for IRQ -1 (CPU 0 vector 0xf2) Signed-off-by: Bjorn Helgaas --- arch/x86/kernel/irq.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c index 2949c6e..3c6b069 100644 --- a/arch/x86/kernel/irq.c +++ b/arch/x86/kernel/irq.c @@ -224,9 +224,8 @@ __visible unsigned int __irq_entry do_IRQ(struct pt_regs *regs) ack_APIC_irq(); if (irq != IRQ_RETRIGGERED) { - pr_emerg_ratelimited("%s: %d.%d No irq handler for vector (irq %d)\n", - __func__, smp_processor_id(), - vector, irq); + pr_emerg_ratelimited("No handler for IRQ %d (CPU %d vector %#x)\n", + irq, smp_processor_id(), vector); } else { __this_cpu_write(vector_irq[vector], IRQ_UNDEFINED); }