From patchwork Fri Aug 28 21:43:50 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 7093831 Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id AD3DDBEEC1 for ; Fri, 28 Aug 2015 21:44:19 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C5916208DD for ; Fri, 28 Aug 2015 21:44:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E41F720880 for ; Fri, 28 Aug 2015 21:44:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753017AbbH1Vn5 (ORCPT ); Fri, 28 Aug 2015 17:43:57 -0400 Received: from mail-ob0-f173.google.com ([209.85.214.173]:34316 "EHLO mail-ob0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752998AbbH1Vnz (ORCPT ); Fri, 28 Aug 2015 17:43:55 -0400 Received: by obbfr1 with SMTP id fr1so55560287obb.1 for ; Fri, 28 Aug 2015 14:43:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=cWN63xmZvWpUNKtHx95QRCUgbIc3HIUmRxC37qq62qI=; b=OfSRWvh9ZRLixbvKEcjTelzxWhAFnU5QrojHGbF7SGLD+84+N1u+77wgfhOSCkKa38 FVX5K6fndDdgKVWWBy8sIMSMzcxoECP6CpBo9zleVhhH4anACH7ayHdyaBGrfp7o+P79 qpGGYNcMYYL1NTG4PUrsoNsgiSS8bW0ftZWo1SmjwZsT2AAWnehXJ+Jogx8BZALrAwKI O2v6ImnujaU8PRabdKGF2K7j7D+BOj2fFNcKs5Cp8sxc245ohz/6iJ7e0kIXHFYCSegl qpl7JT/HaWpkB3h7HJDlqhoZKbauzD8QQ77gy2+igIPjoEK8pe9BpqWgeHvt89lf+ohD 92KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=cWN63xmZvWpUNKtHx95QRCUgbIc3HIUmRxC37qq62qI=; b=eeVSalIB/MfGLprF6FwzvtBeXk/1mTo3XFwokE0NdBvWW+HQcKo8AbzgLwieccvOOh 9Rei9rlUu72udpvp3CD4eXbJg/RP4KoLyQHwu+gjBrV8aiy9XBYckqtNtrwgtrAkfiv7 Fv9E75+VPwRy8RpqA3LxL9PDANBwz8VIjofAFiraGNaXK9s8hI5FefJG33zx0jZ/Yrei rfMmdqVwNhLnC5B3hgEx/NVNoeOXmArBkOU7zitfYUvHXvkIV5b0+iTE6kTspdLoUmNC UCh2BZ5Vo/5e1lAadGCmMfPX2C5nSi/W1PIJRWwmOVDmMJG6DGvO61X6cmHONn6bBH6n da/A== X-Gm-Message-State: ALoCoQkzgYPTvvHD4ChZ9FHxC8eNDEpeMePd+mV77xPAumGsv/qkN7ZrFMXraVY6EJ8ofpugPd0T X-Received: by 10.182.118.226 with SMTP id kp2mr7557882obb.9.1440798234726; Fri, 28 Aug 2015 14:43:54 -0700 (PDT) Received: from google.com ([69.71.1.1]) by smtp.gmail.com with ESMTPSA id i7sm4400960obe.8.2015.08.28.14.43.52 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 28 Aug 2015 14:43:53 -0700 (PDT) Date: Fri, 28 Aug 2015 16:43:50 -0500 From: Bjorn Helgaas To: Geert Uytterhoeven Cc: Simon Horman , Phil Edworthy , Valentine Barshak , linux-pci@vger.kernel.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI: PCI_RCAR_GEN2 and PCI_RCAR_GEN2_PCIE should depend on ARM Message-ID: <20150828214350.GC27890@google.com> References: <1439296994-28480-1-git-send-email-geert+renesas@glider.be> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1439296994-28480-1-git-send-email-geert+renesas@glider.be> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, Aug 11, 2015 at 02:43:14PM +0200, Geert Uytterhoeven wrote: > On arm64/shmobile: > > drivers/pci/host/pci-rcar-gen2.c: In function 'rcar_pci_cfg_base': drivers/pci/host/pci-rcar-gen2.c:112:34: error: dereferencing pointer to incomplete type > struct rcar_pci_priv *priv = sys->private_data; > ^ > > and > > drivers/pci/host/pcie-rcar.c:138:52: warning: 'struct pci_sys_data' declared inside parameter list > static inline struct rcar_pcie *sys_to_pcie(struct pci_sys_data *sys) > ^ > > pci_sys_data exists on ARM only, hence these drivers should depend on > ARM unconditionally. > > Signed-off-by: Geert Uytterhoeven Thanks, I applied this to pci-4.4/host-rcar, which I will rebase after v4.3 is released. commit ae93c3763a294543fd790107e223023ae75cd93a Author: Geert Uytterhoeven Date: Tue Aug 11 14:43:14 2015 +0200 PCI: rcar: Build only on ARM The pci-rcar-gen2.c and pcie-rcar.c drivers use struct pci_sys_data, which only exists on ARM. Building them on other arches, e.g., arm64/shmobile, causes errors like this: drivers/pci/host/pci-rcar-gen2.c: In function 'rcar_pci_cfg_base': drivers/pci/host/pci-rcar-gen2.c:112:34: error: dereferencing pointer to incomplete type struct rcar_pci_priv *priv = sys->private_data; ^ Make these drivers depend on ARM unconditionally. [bhelgaas: changelog] Signed-off-by: Geert Uytterhoeven Signed-off-by: Bjorn Helgaas --- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig index c132bdd..3745c63 100644 --- a/drivers/pci/host/Kconfig +++ b/drivers/pci/host/Kconfig @@ -39,7 +39,8 @@ config PCI_TEGRA config PCI_RCAR_GEN2 bool "Renesas R-Car Gen2 Internal PCI controller" - depends on ARCH_SHMOBILE || (ARM && COMPILE_TEST) + depends on ARM + depends on ARCH_SHMOBILE || COMPILE_TEST help Say Y here if you want internal PCI support on R-Car Gen2 SoC. There are 3 internal PCI controllers available with a single @@ -47,7 +48,8 @@ config PCI_RCAR_GEN2 config PCI_RCAR_GEN2_PCIE bool "Renesas R-Car PCIe controller" - depends on ARCH_SHMOBILE || (ARM && COMPILE_TEST) + depends on ARM + depends on ARCH_SHMOBILE || COMPILE_TEST help Say Y here if you want PCIe controller support on R-Car Gen2 SoCs.