From patchwork Fri Jun 30 00:54:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Packham X-Patchwork-Id: 9818237 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 198D9603F3 for ; Fri, 30 Jun 2017 00:55:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 077E62851A for ; Fri, 30 Jun 2017 00:55:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F01FE2851F; Fri, 30 Jun 2017 00:55:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 959EF2851E for ; Fri, 30 Jun 2017 00:55:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751790AbdF3AzH (ORCPT ); Thu, 29 Jun 2017 20:55:07 -0400 Received: from gate2.alliedtelesis.co.nz ([202.36.163.20]:46170 "EHLO gate2.alliedtelesis.co.nz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751807AbdF3AyW (ORCPT ); Thu, 29 Jun 2017 20:54:22 -0400 Received: from mmarshal3.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id 1ACC18448A; Fri, 30 Jun 2017 12:54:18 +1200 (NZST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz; s=mail; t=1498784058; bh=03Fi2NSJfMJRZhy5YAk5cmk7kBqeS/B5Jt6rOwkaBxM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=oQ8SiwDoDL5xlxw/6ceDe1JWHu4Qzi4rvVhKUlrMvdM+gpRdeJpfbuTVaDweK8cSE NAsTSHvOfGIroO1ARPSjkxRNnrSOcWV8K8qNmUZbxc1mI1uhU9McqJvrLzMvR8e+mu zTN29FyhZQK71/TyWeO/nF1YIb74gnswhD1+nS3w= Received: from smtp (Not Verified[10.32.16.33]) by mmarshal3.atlnz.lc with Trustwave SEG (v7, 5, 7, 9061) id ; Fri, 30 Jun 2017 12:54:17 +1200 Received: from chrisp-dl.atlnz.lc (chrisp-dl.ws.atlnz.lc [10.33.22.30]) by smtp (Postfix) with ESMTP id C4CDE13F0F5; Fri, 30 Jun 2017 12:54:21 +1200 (NZST) Received: by chrisp-dl.atlnz.lc (Postfix, from userid 1030) id CDC761E1D80; Fri, 30 Jun 2017 12:54:16 +1200 (NZST) From: Chris Packham To: wsa@the-dreams.de, andy.shevchenko@gmail.com, linux-i2c@vger.kernel.org Cc: ysato@users.sourceforge.jp, linux-sh@vger.kernel.org, Chris Packham , linux-kernel@vger.kernel.org Subject: [PATCH 5/6] i2c: pca-platform: use device_property_read_u32 Date: Fri, 30 Jun 2017 12:54:07 +1200 Message-Id: <20170630005408.23968-6-chris.packham@alliedtelesis.co.nz> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20170630005408.23968-1-chris.packham@alliedtelesis.co.nz> References: <20170630005408.23968-1-chris.packham@alliedtelesis.co.nz> Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Use device_property_read_u32 instead of of_property_read_u32_index to lookup the "clock-frequency" property. Signed-off-by: Chris Packham --- drivers/i2c/busses/i2c-pca-platform.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/busses/i2c-pca-platform.c b/drivers/i2c/busses/i2c-pca-platform.c index 1e3c247de8f8..80420f753a87 100644 --- a/drivers/i2c/busses/i2c-pca-platform.c +++ b/drivers/i2c/busses/i2c-pca-platform.c @@ -176,13 +176,12 @@ static int i2c_pca_pf_probe(struct platform_device *pdev) if (platform_data) { i2c->adap.timeout = platform_data->timeout; i2c->algo_data.i2c_clock = platform_data->i2c_clock_speed; - } else if (np) { - i2c->adap.timeout = HZ; - of_property_read_u32_index(np, "clock-frequency", 0, - &i2c->algo_data.i2c_clock); } else { i2c->adap.timeout = HZ; - i2c->algo_data.i2c_clock = 59000; + ret = device_property_read_u32(&pdev->dev, "clock-frequency", + &i2c->algo_data.i2c_clock); + if (ret) + i2c->algo_data.i2c_clock = 59000; } i2c->gpio = devm_gpiod_get_optional(&pdev->dev, "reset-gpios", GPIOD_OUT_LOW);