From patchwork Mon Mar 26 21:25:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Petazzoni X-Patchwork-Id: 10308761 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E252660212 for ; Mon, 26 Mar 2018 21:25:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DA46E2890C for ; Mon, 26 Mar 2018 21:25:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CEB9A2982E; Mon, 26 Mar 2018 21:25:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 75D902982E for ; Mon, 26 Mar 2018 21:25:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752221AbeCZVZ5 (ORCPT ); Mon, 26 Mar 2018 17:25:57 -0400 Received: from mail.bootlin.com ([62.4.15.54]:56080 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752273AbeCZVZ4 (ORCPT ); Mon, 26 Mar 2018 17:25:56 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id E8815208A6; Mon, 26 Mar 2018 23:25:53 +0200 (CEST) Received: from localhost (LFbn-TOU-1-408-85.w86-206.abo.wanadoo.fr [86.206.234.85]) by mail.bootlin.com (Postfix) with ESMTPSA id 5FCC4208A7; Mon, 26 Mar 2018 23:25:33 +0200 (CEST) From: Thomas Petazzoni To: Yoshinori Sato , Rich Felker , linux-sh@vger.kernel.org Cc: Thomas Petazzoni Subject: [PATCH 5/5] arch/sh: pcie-sh7786: do not disable MAC data scrambling Date: Mon, 26 Mar 2018 23:25:27 +0200 Message-Id: <20180326212527.12565-6-thomas.petazzoni@bootlin.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180326212527.12565-1-thomas.petazzoni@bootlin.com> References: <20180326212527.12565-1-thomas.petazzoni@bootlin.com> Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The code enables MAC data scrambling, and then later disables it. Disabling MAC data is mostly a debugging feature, data scrambling should normally be enabled. Signed-off-by: Thomas Petazzoni --- arch/sh/drivers/pci/pcie-sh7786.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/arch/sh/drivers/pci/pcie-sh7786.c b/arch/sh/drivers/pci/pcie-sh7786.c index 88841ceb2f06..ca72e838ce62 100644 --- a/arch/sh/drivers/pci/pcie-sh7786.c +++ b/arch/sh/drivers/pci/pcie-sh7786.c @@ -427,11 +427,6 @@ static int __init pcie_init(struct sh7786_pcie_port *port) data |= PCIEDLINTENR_DLL_ACT_ENABLE; pci_write_reg(chan, data, SH4A_PCIEDLINTENR); - /* Disable MAC data scrambling. */ - data = pci_read_reg(chan, SH4A_PCIEMACCTLR); - data |= PCIEMACCTLR_SCR_DIS | (0xff << 16); - pci_write_reg(chan, data, SH4A_PCIEMACCTLR); - /* * This will timeout if we don't have a link, but we permit the * port to register anyways in order to support hotplug on future