From patchwork Thu Jun 28 09:16:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michal Suchanek X-Patchwork-Id: 10494825 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0EBD2601BE for ; Thu, 28 Jun 2018 19:06:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 116A82A13D for ; Thu, 28 Jun 2018 19:06:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0411D2A1F2; Thu, 28 Jun 2018 19:06:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=2.0 tests=BAYES_00, DATE_IN_PAST_06_12, FROM_EXCESS_BASE64, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8EA6F2A13D for ; Thu, 28 Jun 2018 19:06:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752633AbeF1TGX convert rfc822-to-8bit (ORCPT ); Thu, 28 Jun 2018 15:06:23 -0400 Received: from mx2.suse.de ([195.135.220.15]:39506 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1030575AbeF1TDo (ORCPT ); Thu, 28 Jun 2018 15:03:44 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 3187BAD4A; Thu, 28 Jun 2018 19:03:39 +0000 (UTC) Date: Thu, 28 Jun 2018 11:16:23 +0200 From: Michal =?UTF-8?B?U3VjaMOhbmVr?= To: Masahiro Yamada Cc: Linux Kernel Mailing List , Takashi Iwai , Andreas Schwab , Michal Kubecek , Michal Marek , Jonathan Corbet , Yoshinori Sato , Rich Felker , "David S. Miller" , Jeff Dike , Richard Weinberger , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , X86 ML , Kees Cook , Philippe Ombredanne , Greg Kroah-Hartman , Ulf Magnusson , Jeff Mahoney , "Peter Zijlstra," , Mathieu Desnoyers , Frederic Weisbecker , Randy Dunlap , Dominik Brodowski , Nicholas Piggin , Linux Kbuild mailing list , "open list:DOCUMENTATION" , Linux-sh list , sparclinux , linux-um@lists.infradead.org Subject: Re: due to kconfig changes kernel config file is no longer sufficient for configuring the kernel Message-ID: <20180628111623.3807fe9b@naga.suse.cz> In-Reply-To: References: <20180627143705.5a1fed1c@kitsune.suse.cz> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, 27 Jun 2018 23:07:21 +0900 Masahiro Yamada wrote: > Hi. > > > 2018-06-27 21:37 GMT+09:00 Michal Suchánek : > > Hello, > > > > in the x86 Kconfig we have this: > > > > # Select 32 or 64 bit > > config 64BIT > > bool "64-bit kernel" if "$(ARCH)" = "x86" > > default "$(ARCH)" != "i386" > > ---help--- > > Say yes to build a 64-bit kernel - formerly known as > > x86_64 Say no to build a 32-bit kernel - formerly known as i386 > > > > Since commit 104daea149c4 ("kconfig: reference environment variables > > directly and remove 'option env='") the value of ARCH is not saved > > in the kernel config. > > I think this commit is unrelated. It was just a syntax change. This does not look like syntax only change to me: > > not visible. > > This is correct. > > It was discussed a few weeks ago. > > https://lkml.org/lkml/2018/6/5/847 > > > > There is a number of ways to hack this particular case to work. > > > > However, there is a more general problem with this. Some config > > options may depend on the environment, may not be saved, and the > > environment is not saved either. > > Which environment variables in particular are in your mind? Any that is used in Kconfig. > > As for ARCH, you need to pass the same ARCH as you used for building > the kernel. (For native building, you do not have to pass ARCH > explicitly, though.) Except if you do pass it to make config you may need to pass it to to make later as well. > > As for CC, HOSTCC, etc. > yes, these are new 'unsaved' environments. > > CONFIG options now depend on the compiler. > This is the concept suggested by Linus Torvalds. > > > > So in the end all the infrastructure with symlinks > > from module directory pointing to the kernel source and object > > directory is useless. To interpret the config stored there you need > > the environment and that is not saved anywhere. So if you try to > > build out-of-tree module it might end up reconfiguring your kernel > > and producing useless modules. > > No. out-of-tree module building never ever re-configures the kernel. It does implicitly because the config values depend on environment that is not saved and the values themselves are not saved either. If that happens to expose a new variable it is even explicitly reconfigured. > > out-of-tree modules are built with exactly the same configuration > as used for the kernel. It is not true. And that is the problem. You need the config file and dump of the environment passed to the make command at configuration time to get the exact same configuration. The environment is not saved anywhere, though. Thanks Michal --- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/init/Kconfig b/init/Kconfig index 15aae32e0719..1217fc62ca61 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -1,20 +1,12 @@ -config ARCH - string - option env="ARCH" - -config KERNELVERSION - string - option env="KERNELVERSION" - > > Unless I am missing something, > we have never saved ARCH in the .config in the past. There was a config symbol defined for it before the commit removed it. > > > > Since commit f467c5640c29 ("kconfig: only write '# > > CONFIG_FOO is not set' for visible symbols") the value of 64BIT is > > not saved if the ARCH is set i386 or x86_64 because the symbol is