From patchwork Fri Jan 4 03:18:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 10748011 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 148026C5 for ; Fri, 4 Jan 2019 03:19:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EC11F20408 for ; Fri, 4 Jan 2019 03:19:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DC62A2522B; Fri, 4 Jan 2019 03:19:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3CE2020408 for ; Fri, 4 Jan 2019 03:19:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726073AbfADDTA (ORCPT ); Thu, 3 Jan 2019 22:19:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:36608 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726020AbfADDTA (ORCPT ); Thu, 3 Jan 2019 22:19:00 -0500 Received: from vmware.local.home (cpe-66-24-56-78.stny.res.rr.com [66.24.56.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 445062087F; Fri, 4 Jan 2019 03:18:59 +0000 (UTC) Date: Thu, 3 Jan 2019 22:18:57 -0500 From: Steven Rostedt To: Linus Torvalds Cc: LKML , linux-sh@vger.kernel.org, Yoshinori Sato , Rich Felker , kbuild test robot Subject: [GIT PULL][PATCH] sh: ftrace: Fix missing parenthesis in WARN_ON() Message-ID: <20190103221857.3458296b@vmware.local.home> X-Mailer: Claws Mail 3.15.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Linus, It appears that the zero-day bot did find a bug in my sh build. And that I didn't have the bad code in my config file when I cross compiled it, although there are a few other errors in sh that makes it not build for me, I missed that I added one more. I replaced WARN_ON(current->curr_ret_stack) with WARN_ON(ftrace_graph_get_ret_stack(current, 1) where it should be: WARN_ON(ftrace_graph_get_ret_stack(current, 1)) Please pull the latest trace-v4.21-1 tree, which can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git trace-v4.21-1 Tag SHA1: 0695bd08e48f3e80e08afb6ea256639a4e81624c Head SHA1: dc56367cb5dbf9d593e4b12373489df9a7edb72c Steven Rostedt (VMware) (1): sh: ftrace: Fix missing parenthesis in WARN_ON() ---- arch/sh/kernel/dwarf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --------------------------- commit dc56367cb5dbf9d593e4b12373489df9a7edb72c Author: Steven Rostedt (VMware) Date: Thu Jan 3 22:02:39 2019 -0500 sh: ftrace: Fix missing parenthesis in WARN_ON() Adding a function inside a WARN_ON() didn't close the WARN_ON parathesis. Link: http://lkml.kernel.org/r/201901020958.28Mzbs0O%fengguang.wu@intel.com Cc: linux-sh@vger.kernel.org Cc: Yoshinori Sato Cc: Rich Felker Reported-by: kbuild test robot Fixes: cec8d0e7f06e ("sh: ftrace: Use ftrace_graph_get_ret_stack() instead of curr_ret_stack") Signed-off-by: Steven Rostedt (VMware) diff --git a/arch/sh/kernel/dwarf.c b/arch/sh/kernel/dwarf.c index df0fd6efe758..00622598a245 100644 --- a/arch/sh/kernel/dwarf.c +++ b/arch/sh/kernel/dwarf.c @@ -619,7 +619,7 @@ struct dwarf_frame *dwarf_unwind_stack(unsigned long pc, * than one patched return address on our stack, * complain loudly. */ - WARN_ON(ftrace_graph_get_ret_stack(current, 1); + WARN_ON(ftrace_graph_get_ret_stack(current, 1)); } #endif