| Message ID | 20200118081356.22167-1-krzk@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] sh: sh4a: Bring back tmu3_device early device | expand |
On Sat, Jan 18, 2020 at 9:14 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > Commit 1399c195ef50 ("sh: Switch to new style TMU device") converted > tmu3_device platform device to new style of platform data but removed it > from sh7786_early_devices array effectively removing last three timers > and causing a warning: > > arch/sh/kernel/cpu/sh4a/setup-sh7786.c:243:31: > warning: ‘tmu3_device’ defined but not used [-Wunused-variable] > > Fixes: 1399c195ef50 ("sh: Switch to new style TMU device") > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/arch/sh/kernel/cpu/sh4a/setup-sh7786.c b/arch/sh/kernel/cpu/sh4a/setup-sh7786.c index 4b0db8259e3d..74620f30b19b 100644 --- a/arch/sh/kernel/cpu/sh4a/setup-sh7786.c +++ b/arch/sh/kernel/cpu/sh4a/setup-sh7786.c @@ -391,6 +391,7 @@ static struct platform_device *sh7786_early_devices[] __initdata = { &tmu0_device, &tmu1_device, &tmu2_device, + &tmu3_device, }; static struct platform_device *sh7786_devices[] __initdata = {
Commit 1399c195ef50 ("sh: Switch to new style TMU device") converted tmu3_device platform device to new style of platform data but removed it from sh7786_early_devices array effectively removing last three timers and causing a warning: arch/sh/kernel/cpu/sh4a/setup-sh7786.c:243:31: warning: ‘tmu3_device’ defined but not used [-Wunused-variable] Fixes: 1399c195ef50 ("sh: Switch to new style TMU device") Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- Changes since v1: 1. Add tmu3_device to early device list, as suggested by Geert. 2. Add Fixes tag. --- arch/sh/kernel/cpu/sh4a/setup-sh7786.c | 1 + 1 file changed, 1 insertion(+)