diff mbox series

[1/3] x86/mm: Drop unused MAX_PHYSADDR_BITS

Message ID 20200723231544.17274-2-nivedita@alum.mit.edu
State New
Headers show
Series Drop unused MAX_PHYSADDR_BITS | expand

Commit Message

Arvind Sankar July 23, 2020, 11:15 p.m. UTC
The macro is not used anywhere, and has an incorrect value (going by the
comment) on x86_64 since commit
  c898faf91b3e ("x86: 46 bit physical address support on 64 bits")

To avoid confusion, just remove the definition.

Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu>
---
 arch/x86/include/asm/sparsemem.h | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Comments

David Hildenbrand July 24, 2020, 8:22 a.m. UTC | #1
On 24.07.20 01:15, Arvind Sankar wrote:
> The macro is not used anywhere, and has an incorrect value (going by the
> comment) on x86_64 since commit
>   c898faf91b3e ("x86: 46 bit physical address support on 64 bits")
> 
> To avoid confusion, just remove the definition.
> 
> Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu>
> ---
>  arch/x86/include/asm/sparsemem.h | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/arch/x86/include/asm/sparsemem.h b/arch/x86/include/asm/sparsemem.h
> index 199218719a86..6bfc878f6771 100644
> --- a/arch/x86/include/asm/sparsemem.h
> +++ b/arch/x86/include/asm/sparsemem.h
> @@ -10,24 +10,20 @@
>   *    field of the struct page
>   *
>   * SECTION_SIZE_BITS		2^n: size of each section
> - * MAX_PHYSADDR_BITS		2^n: max size of physical address space
> - * MAX_PHYSMEM_BITS		2^n: how much memory we can have in that space
> + * MAX_PHYSMEM_BITS		2^n: max size of physical address space
>   *
>   */
>  
>  #ifdef CONFIG_X86_32
>  # ifdef CONFIG_X86_PAE
>  #  define SECTION_SIZE_BITS	29
> -#  define MAX_PHYSADDR_BITS	36
>  #  define MAX_PHYSMEM_BITS	36
>  # else
>  #  define SECTION_SIZE_BITS	26
> -#  define MAX_PHYSADDR_BITS	32
>  #  define MAX_PHYSMEM_BITS	32
>  # endif
>  #else /* CONFIG_X86_32 */
>  # define SECTION_SIZE_BITS	27 /* matt - 128 is convenient right now */
> -# define MAX_PHYSADDR_BITS	(pgtable_l5_enabled() ? 52 : 44)
>  # define MAX_PHYSMEM_BITS	(pgtable_l5_enabled() ? 52 : 46)
>  #endif
>  
> 

Reviewed-by: David Hildenbrand <david@redhat.com>
diff mbox series

Patch

diff --git a/arch/x86/include/asm/sparsemem.h b/arch/x86/include/asm/sparsemem.h
index 199218719a86..6bfc878f6771 100644
--- a/arch/x86/include/asm/sparsemem.h
+++ b/arch/x86/include/asm/sparsemem.h
@@ -10,24 +10,20 @@ 
  *    field of the struct page
  *
  * SECTION_SIZE_BITS		2^n: size of each section
- * MAX_PHYSADDR_BITS		2^n: max size of physical address space
- * MAX_PHYSMEM_BITS		2^n: how much memory we can have in that space
+ * MAX_PHYSMEM_BITS		2^n: max size of physical address space
  *
  */
 
 #ifdef CONFIG_X86_32
 # ifdef CONFIG_X86_PAE
 #  define SECTION_SIZE_BITS	29
-#  define MAX_PHYSADDR_BITS	36
 #  define MAX_PHYSMEM_BITS	36
 # else
 #  define SECTION_SIZE_BITS	26
-#  define MAX_PHYSADDR_BITS	32
 #  define MAX_PHYSMEM_BITS	32
 # endif
 #else /* CONFIG_X86_32 */
 # define SECTION_SIZE_BITS	27 /* matt - 128 is convenient right now */
-# define MAX_PHYSADDR_BITS	(pgtable_l5_enabled() ? 52 : 44)
 # define MAX_PHYSMEM_BITS	(pgtable_l5_enabled() ? 52 : 46)
 #endif