diff mbox series

[13/13] MAINTAINERS: Add entry for the bitmap API

Message ID 20210316015424.1999082-14-yury.norov@gmail.com (mailing list archive)
State New
Headers show
Series lib/find_bit: fast path for small bitmaps | expand

Commit Message

Yury Norov March 16, 2021, 1:54 a.m. UTC
Add myself as maintainer for bitmap API and Andy and Rasmus as reviewers.

I'm an author of current implementation of lib/find_bit and an active
contributor to lib/bitmap. It was spotted that there's no maintainer for
bitmap API. I'm willing to maintain it.

Signed-off-by: Yury Norov <yury.norov@gmail.com>
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
 MAINTAINERS | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

Comments

Andy Shevchenko March 16, 2021, 11:45 a.m. UTC | #1
On Mon, Mar 15, 2021 at 06:54:24PM -0700, Yury Norov wrote:
> Add myself as maintainer for bitmap API and Andy and Rasmus as reviewers.
> 
> I'm an author of current implementation of lib/find_bit and an active
> contributor to lib/bitmap. It was spotted that there's no maintainer for
> bitmap API. I'm willing to maintain it.
> 
> Signed-off-by: Yury Norov <yury.norov@gmail.com>
> Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Acked-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
>  MAINTAINERS | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3dd20015696e..44f94cdd5a20 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3151,6 +3151,22 @@ F:	Documentation/filesystems/bfs.rst
>  F:	fs/bfs/
>  F:	include/uapi/linux/bfs_fs.h
>  
> +BITMAP API
> +M:	Yury Norov <yury.norov@gmail.com>
> +R:	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> +R:	Rasmus Villemoes <linux@rasmusvillemoes.dk>
> +S:	Maintained
> +F:	include/asm-generic/bitops/find.h
> +F:	include/linux/bitmap.h
> +F:	lib/bitmap.c
> +F:	lib/find_bit.c

> +F:	lib/find_find_bit_benchmark.c

Does this file exist?
I guess checkpatch.pl nowadays has a MAINTAINER data base validation.

> +F:	lib/test_bitmap.c
> +F:	tools/include/asm-generic/bitops/find.h
> +F:	tools/include/linux/bitmap.h
> +F:	tools/lib/bitmap.c
> +F:	tools/lib/find_bit.c
> +
>  BLINKM RGB LED DRIVER
>  M:	Jan-Simon Moeller <jansimon.moeller@gmx.de>
>  S:	Maintained
> -- 
> 2.25.1
>
Yury Norov March 17, 2021, 4:47 a.m. UTC | #2
[CC Andy Whitcroft, Joe Perches, Dwaipayan Ray, Lukas Bulwahn]

On Tue, Mar 16, 2021 at 01:45:51PM +0200, Andy Shevchenko wrote:
> On Mon, Mar 15, 2021 at 06:54:24PM -0700, Yury Norov wrote:
> > Add myself as maintainer for bitmap API and Andy and Rasmus as reviewers.
> > 
> > I'm an author of current implementation of lib/find_bit and an active
> > contributor to lib/bitmap. It was spotted that there's no maintainer for
> > bitmap API. I'm willing to maintain it.
> > 
> > Signed-off-by: Yury Norov <yury.norov@gmail.com>
> > Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Acked-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> > ---
> >  MAINTAINERS | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 3dd20015696e..44f94cdd5a20 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -3151,6 +3151,22 @@ F:	Documentation/filesystems/bfs.rst
> >  F:	fs/bfs/
> >  F:	include/uapi/linux/bfs_fs.h
> >  
> > +BITMAP API
> > +M:	Yury Norov <yury.norov@gmail.com>
> > +R:	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > +R:	Rasmus Villemoes <linux@rasmusvillemoes.dk>
> > +S:	Maintained
> > +F:	include/asm-generic/bitops/find.h
> > +F:	include/linux/bitmap.h
> > +F:	lib/bitmap.c
> > +F:	lib/find_bit.c
> 
> > +F:	lib/find_find_bit_benchmark.c
> 
> Does this file exist?
> I guess checkpatch.pl nowadays has a MAINTAINER data base validation.

No lib/find_find_bit_benchmark.c doesn't exist. It's a typo, it should
be lib/find_bit_benchmark.c. Checkpatch doesn't warn:

yury:linux$ scripts/checkpatch.pl 0013-MAINTAINERS-Add-entry-for-the-bitmap-API.patch
total: 0 errors, 0 warnings, 22 lines checked

> > +F:	lib/test_bitmap.c
> > +F:	tools/include/asm-generic/bitops/find.h
> > +F:	tools/include/linux/bitmap.h
> > +F:	tools/lib/bitmap.c
> > +F:	tools/lib/find_bit.c
> > +
> >  BLINKM RGB LED DRIVER
> >  M:	Jan-Simon Moeller <jansimon.moeller@gmx.de>
> >  S:	Maintained
> > -- 
> > 2.25.1
> > 
> 
> -- 
> With Best Regards,
> Andy Shevchenko
>
Joe Perches March 17, 2021, 4:57 a.m. UTC | #3
On Tue, 2021-03-16 at 21:47 -0700, Yury Norov wrote:
> [CC Andy Whitcroft, Joe Perches, Dwaipayan Ray, Lukas Bulwahn]
> 
> On Tue, Mar 16, 2021 at 01:45:51PM +0200, Andy Shevchenko wrote:
> > On Mon, Mar 15, 2021 at 06:54:24PM -0700, Yury Norov wrote:
> > > Add myself as maintainer for bitmap API and Andy and Rasmus as reviewers.
> > > 
> > > I'm an author of current implementation of lib/find_bit and an active
> > > contributor to lib/bitmap. It was spotted that there's no maintainer for
> > > bitmap API. I'm willing to maintain it.
> > > 
> > > Signed-off-by: Yury Norov <yury.norov@gmail.com>
> > > Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > Acked-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> > > ---
> > >  MAINTAINERS | 16 ++++++++++++++++
> > >  1 file changed, 16 insertions(+)
> > > 
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 3dd20015696e..44f94cdd5a20 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -3151,6 +3151,22 @@ F:	Documentation/filesystems/bfs.rst
> > >  F:	fs/bfs/
> > >  F:	include/uapi/linux/bfs_fs.h
> > >  
> > > 
> > > +BITMAP API
> > > +M:	Yury Norov <yury.norov@gmail.com>
> > > +R:	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > +R:	Rasmus Villemoes <linux@rasmusvillemoes.dk>
> > > +S:	Maintained
> > > +F:	include/asm-generic/bitops/find.h
> > > +F:	include/linux/bitmap.h
> > > +F:	lib/bitmap.c
> > > +F:	lib/find_bit.c
> > 
> > > +F:	lib/find_find_bit_benchmark.c
> > 
> > Does this file exist?
> > I guess checkpatch.pl nowadays has a MAINTAINER data base validation.
> 
> No lib/find_find_bit_benchmark.c doesn't exist. It's a typo, it should
> be lib/find_bit_benchmark.c. Checkpatch doesn't warn:
> 
> yury:linux$ scripts/checkpatch.pl 0013-MAINTAINERS-Add-entry-for-the-bitmap-API.patch
> total: 0 errors, 0 warnings, 22 lines checked

checkpatch does not validate filenames for each patch.

checkpatch does have a --self-test=patterns capability that does
validate file accessibility.
Lukas Bulwahn March 17, 2021, 6:40 a.m. UTC | #4
On Wed, Mar 17, 2021 at 5:57 AM Joe Perches <joe@perches.com> wrote:
>
> On Tue, 2021-03-16 at 21:47 -0700, Yury Norov wrote:
> > [CC Andy Whitcroft, Joe Perches, Dwaipayan Ray, Lukas Bulwahn]
> >
> > On Tue, Mar 16, 2021 at 01:45:51PM +0200, Andy Shevchenko wrote:
> > > On Mon, Mar 15, 2021 at 06:54:24PM -0700, Yury Norov wrote:
> > > > Add myself as maintainer for bitmap API and Andy and Rasmus as reviewers.
> > > >
> > > > I'm an author of current implementation of lib/find_bit and an active
> > > > contributor to lib/bitmap. It was spotted that there's no maintainer for
> > > > bitmap API. I'm willing to maintain it.
> > > >
> > > > Signed-off-by: Yury Norov <yury.norov@gmail.com>
> > > > Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > > Acked-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> > > > ---
> > > >  MAINTAINERS | 16 ++++++++++++++++
> > > >  1 file changed, 16 insertions(+)
> > > >
> > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > index 3dd20015696e..44f94cdd5a20 100644
> > > > --- a/MAINTAINERS
> > > > +++ b/MAINTAINERS
> > > > @@ -3151,6 +3151,22 @@ F: Documentation/filesystems/bfs.rst
> > > >  F:       fs/bfs/
> > > >  F:       include/uapi/linux/bfs_fs.h
> > > >
> > > >
> > > > +BITMAP API
> > > > +M:       Yury Norov <yury.norov@gmail.com>
> > > > +R:       Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > > +R:       Rasmus Villemoes <linux@rasmusvillemoes.dk>
> > > > +S:       Maintained
> > > > +F:       include/asm-generic/bitops/find.h
> > > > +F:       include/linux/bitmap.h
> > > > +F:       lib/bitmap.c
> > > > +F:       lib/find_bit.c
> > >
> > > > +F:       lib/find_find_bit_benchmark.c
> > >
> > > Does this file exist?
> > > I guess checkpatch.pl nowadays has a MAINTAINER data base validation.
> >
> > No lib/find_find_bit_benchmark.c doesn't exist. It's a typo, it should
> > be lib/find_bit_benchmark.c. Checkpatch doesn't warn:
> >
> > yury:linux$ scripts/checkpatch.pl 0013-MAINTAINERS-Add-entry-for-the-bitmap-API.patch
> > total: 0 errors, 0 warnings, 22 lines checked
>
> checkpatch does not validate filenames for each patch.
>
> checkpatch does have a --self-test=patterns capability that does
> validate file accessibility.

Joe meant: get_maintainers does have a --self-test=patterns capability
that does validate file accessibility.

You can run that before patch submission; otherwise, I run that script
on linux-next once a week and send out correction patches as far as my
"spare" time allows to do so.

Lukas
Yury Norov March 17, 2021, 7:29 p.m. UTC | #5
On Wed, Mar 17, 2021 at 07:40:04AM +0100, Lukas Bulwahn wrote:
> On Wed, Mar 17, 2021 at 5:57 AM Joe Perches <joe@perches.com> wrote:
> >
> > On Tue, 2021-03-16 at 21:47 -0700, Yury Norov wrote:
> > > [CC Andy Whitcroft, Joe Perches, Dwaipayan Ray, Lukas Bulwahn]
> > >
> > > On Tue, Mar 16, 2021 at 01:45:51PM +0200, Andy Shevchenko wrote:
> > > > On Mon, Mar 15, 2021 at 06:54:24PM -0700, Yury Norov wrote:
> > > > > Add myself as maintainer for bitmap API and Andy and Rasmus as reviewers.
> > > > >
> > > > > I'm an author of current implementation of lib/find_bit and an active
> > > > > contributor to lib/bitmap. It was spotted that there's no maintainer for
> > > > > bitmap API. I'm willing to maintain it.
> > > > >
> > > > > Signed-off-by: Yury Norov <yury.norov@gmail.com>
> > > > > Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > > > Acked-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> > > > > ---
> > > > >  MAINTAINERS | 16 ++++++++++++++++
> > > > >  1 file changed, 16 insertions(+)
> > > > >
> > > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > > index 3dd20015696e..44f94cdd5a20 100644
> > > > > --- a/MAINTAINERS
> > > > > +++ b/MAINTAINERS
> > > > > @@ -3151,6 +3151,22 @@ F: Documentation/filesystems/bfs.rst
> > > > >  F:       fs/bfs/
> > > > >  F:       include/uapi/linux/bfs_fs.h
> > > > >
> > > > >
> > > > > +BITMAP API
> > > > > +M:       Yury Norov <yury.norov@gmail.com>
> > > > > +R:       Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > > > +R:       Rasmus Villemoes <linux@rasmusvillemoes.dk>
> > > > > +S:       Maintained
> > > > > +F:       include/asm-generic/bitops/find.h
> > > > > +F:       include/linux/bitmap.h
> > > > > +F:       lib/bitmap.c
> > > > > +F:       lib/find_bit.c
> > > >
> > > > > +F:       lib/find_find_bit_benchmark.c
> > > >
> > > > Does this file exist?
> > > > I guess checkpatch.pl nowadays has a MAINTAINER data base validation.
> > >
> > > No lib/find_find_bit_benchmark.c doesn't exist. It's a typo, it should
> > > be lib/find_bit_benchmark.c. Checkpatch doesn't warn:
> > >
> > > yury:linux$ scripts/checkpatch.pl 0013-MAINTAINERS-Add-entry-for-the-bitmap-API.patch
> > > total: 0 errors, 0 warnings, 22 lines checked
> >
> > checkpatch does not validate filenames for each patch.
> >
> > checkpatch does have a --self-test=patterns capability that does
> > validate file accessibility.
> 
> Joe meant: get_maintainers does have a --self-test=patterns capability
> that does validate file accessibility.
> 
> You can run that before patch submission; otherwise, I run that script
> on linux-next once a week and send out correction patches as far as my
> "spare" time allows to do so.

Thanks for the hint. I see it's able to detect the issue.
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 3dd20015696e..44f94cdd5a20 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3151,6 +3151,22 @@  F:	Documentation/filesystems/bfs.rst
 F:	fs/bfs/
 F:	include/uapi/linux/bfs_fs.h
 
+BITMAP API
+M:	Yury Norov <yury.norov@gmail.com>
+R:	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
+R:	Rasmus Villemoes <linux@rasmusvillemoes.dk>
+S:	Maintained
+F:	include/asm-generic/bitops/find.h
+F:	include/linux/bitmap.h
+F:	lib/bitmap.c
+F:	lib/find_bit.c
+F:	lib/find_find_bit_benchmark.c
+F:	lib/test_bitmap.c
+F:	tools/include/asm-generic/bitops/find.h
+F:	tools/include/linux/bitmap.h
+F:	tools/lib/bitmap.c
+F:	tools/lib/find_bit.c
+
 BLINKM RGB LED DRIVER
 M:	Jan-Simon Moeller <jansimon.moeller@gmx.de>
 S:	Maintained