diff mbox series

sh: pci: Remove unused variable in SH-7786 PCI Express code

Message ID 20230418155153.222214-1-glaubitz@physik.fu-berlin.de (mailing list archive)
State New, archived
Headers show
Series sh: pci: Remove unused variable in SH-7786 PCI Express code | expand

Commit Message

John Paul Adrian Glaubitz April 18, 2023, 3:51 p.m. UTC 
Addresses the following warning when building sdk7786_defconfig:

arch/sh/drivers/pci/pcie-sh7786.c:34:22: warning: 'dma_pfn_offset' defined but not used [-Wunused-variable]
   34 | static unsigned long dma_pfn_offset;
      |                      ^~~~~~~~~~~~~~

Fixes: e0d072782c73 ("dma-mapping: introduce DMA range map, supplanting dma_pfn_offset")

Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
---
 arch/sh/drivers/pci/pcie-sh7786.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Geert Uytterhoeven April 18, 2023, 4:14 p.m. UTC | #1 
Hi Adrian,

Thanks for your patch!

On Tue, Apr 18, 2023 at 5:59 PM John Paul Adrian Glaubitz
<glaubitz@physik.fu-berlin.de> wrote:
> Addresses the following warning when building sdk7786_defconfig:
>
> arch/sh/drivers/pci/pcie-sh7786.c:34:22: warning: 'dma_pfn_offset' defined but not used [-Wunused-variable]
>    34 | static unsigned long dma_pfn_offset;
>       |                      ^~~~~~~~~~~~~~
>
> Fixes: e0d072782c73 ("dma-mapping: introduce DMA range map, supplanting dma_pfn_offset")
>

Please no blank line between tags and SoB.

> Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>

For the actual patch contents:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert
diff mbox series

Patch

diff --git a/arch/sh/drivers/pci/pcie-sh7786.c b/arch/sh/drivers/pci/pcie-sh7786.c
index b0c2a5238d04..39bb5038e1c6 100644
--- a/arch/sh/drivers/pci/pcie-sh7786.c
+++ b/arch/sh/drivers/pci/pcie-sh7786.c
@@ -31,7 +31,6 @@  struct sh7786_pcie_port {
 
 static struct sh7786_pcie_port *sh7786_pcie_ports;
 static unsigned int nr_ports;
-static unsigned long dma_pfn_offset;
 size_t memsize;
 u64 memstart;