Rcar-du Initialization errors on Koelsch

Commit Message

Laurent Pinchart Feb. 23, 2015, 11:47 p.m. UTC

Hi Hiep-san,

On Monday 23 February 2015 14:08:16 Cao Minh Hiep wrote:
> Hi Laurent-san
> I am Hiep from Jinzai Solution.
> 
> We have tested the linux ver 3.19 on Koelsch, we found some error
> messages from Rcar-Du as show below:
> The error messages:
> "[drm] Initialized drm 1.1.0 20060810
>   rcar-du feb00000.display: Failed to initialize drm fb helper.
>   rcar-du feb00000.display: failed to initialize DRM/KMS
>   rcar-du: probe of feb00000.display failed with error -22"
> 
> Then, we find out these patches as below are causing of this bug:
> 0ee56d4 ARM: shmobile: koelsch: Enable DU device in DT
> 910343e ARM: shmobile: koelsch-reference: Remove DU platform device

This is due to the fact that no connector has been instantiated. The error 
message is pretty confusing, I'll submit a patch to make it clearer, but it 
won't fix the issue.

With the platform data based DU instantiation the Lager and Koelsch board file 
contained LVDS panel information, and the DU driver instantiated one LVDS 
connector. I wanted to replicate that when moving to DT, but the approach has 
been rejected during review due to the fact that the panel isn't part of the 
Lager and Koelsch boards, and thus shouldn't be described in r8a7790-lager.dts 
or r8a7791-koelsch.dts.

I've thus created a separate DT file (r8a77xx-aa104xd12-panel.dtsi) to 
describe the panel, which can be included directly in r8a7790-lager.dts or 
r8a7791-koelsch.dts as in the following patch.

Please note that the patch won't be upstreamed due to the reason explained 
above.

commit eca4ad5b98775c9a8cf5ee03598c3e5421f65030
Author: Laurent Pinchart <[e-mail]>
Date:   Fri Oct 24 14:53:13 2014 +0300

    ARM: shmobile: koelsch: Add panel to DT
    
    Signed-off-by: Laurent Pinchart 
<[e-mail]>

Comments

Cao Minh Hiep Feb. 24, 2015, 12:43 a.m. UTC | #1

Hi Laurent-san

Thanks for your replying.

On 2015?02?24? 08:47, Laurent Pinchart wrote:
> Hi Hiep-san,
>
> On Monday 23 February 2015 14:08:16 Cao Minh Hiep wrote:
>> Hi Laurent-san
>> I am Hiep from Jinzai Solution.
>>
>> We have tested the linux ver 3.19 on Koelsch, we found some error
>> messages from Rcar-Du as show below:
>> The error messages:
>> "[drm] Initialized drm 1.1.0 20060810
>>    rcar-du feb00000.display: Failed to initialize drm fb helper.
>>    rcar-du feb00000.display: failed to initialize DRM/KMS
>>    rcar-du: probe of feb00000.display failed with error -22"
>>
>> Then, we find out these patches as below are causing of this bug:
>> 0ee56d4 ARM: shmobile: koelsch: Enable DU device in DT
>> 910343e ARM: shmobile: koelsch-reference: Remove DU platform device
> This is due to the fact that no connector has been instantiated. The error
> message is pretty confusing, I'll submit a patch to make it clearer, but it
> won't fix the issue.
>
> With the platform data based DU instantiation the Lager and Koelsch board file
> contained LVDS panel information, and the DU driver instantiated one LVDS
> connector. I wanted to replicate that when moving to DT, but the approach has
> been rejected during review due to the fact that the panel isn't part of the
> Lager and Koelsch boards, and thus shouldn't be described in r8a7790-lager.dts
> or r8a7791-koelsch.dts.
Thanks. I understood.
> I've thus created a separate DT file (r8a77xx-aa104xd12-panel.dtsi) to
> describe the panel, which can be included directly in r8a7790-lager.dts or
> r8a7791-koelsch.dts as in the following patch.
>
> Please note that the patch won't be upstreamed due to the reason explained
> above.
Ok, I see.

Best Regards,
Jinso/Hiep
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts 
b/arch/arm/boot/dts/r8a7791-koelsch.dts
index 624bb2c30513..5119ed12fe63 100644
--- a/arch/arm/boot/dts/r8a7791-koelsch.dts
+++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
@@ -648,3 +648,5 @@ 
 &ssi1 {
 	shared-pin;
 };
+
+#include "r8a77xx-aa104xd12-panel.dtsi"