From patchwork Mon Feb 23 23:47:56 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 5868501 X-Patchwork-Delegate: horms@verge.net.au Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 38FBFBF440 for ; Mon, 23 Feb 2015 23:46:58 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5C2892063B for ; Mon, 23 Feb 2015 23:46:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7102A20635 for ; Mon, 23 Feb 2015 23:46:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751861AbbBWXq4 (ORCPT ); Mon, 23 Feb 2015 18:46:56 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:49713 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751832AbbBWXqz (ORCPT ); Mon, 23 Feb 2015 18:46:55 -0500 Received: from avalon.localnet (dsl-hkibrasgw3-50ddcc-40.dhcp.inet.fi [80.221.204.40]) by galahad.ideasonboard.com (Postfix) with ESMTPSA id DB47720115; Tue, 24 Feb 2015 00:46:12 +0100 (CET) From: Laurent Pinchart To: Cao Minh Hiep Cc: laurent.pinchart+renesas@ideasonboard.com, Linux-SH , Kuninori Morimoto , Magnus Damm , Simon Horman , Sakato Ryusuke , yoshihiro.shimoda.uh@renesas.com Subject: Re: Rcar-du Initialization errors on Koelsch Date: Tue, 24 Feb 2015 01:47:56 +0200 Message-ID: <2501755.ZY2tNT0lYX@avalon> User-Agent: KMail/4.14.3 (Linux/3.18.7-gentoo; KDE/4.14.3; x86_64; ; ) In-Reply-To: <54EAB5C0.5030304@jinso.co.jp> References: <54EAB5C0.5030304@jinso.co.jp> MIME-Version: 1.0 Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Hiep-san, On Monday 23 February 2015 14:08:16 Cao Minh Hiep wrote: > Hi Laurent-san > I am Hiep from Jinzai Solution. > > We have tested the linux ver 3.19 on Koelsch, we found some error > messages from Rcar-Du as show below: > The error messages: > "[drm] Initialized drm 1.1.0 20060810 > rcar-du feb00000.display: Failed to initialize drm fb helper. > rcar-du feb00000.display: failed to initialize DRM/KMS > rcar-du: probe of feb00000.display failed with error -22" > > Then, we find out these patches as below are causing of this bug: > 0ee56d4 ARM: shmobile: koelsch: Enable DU device in DT > 910343e ARM: shmobile: koelsch-reference: Remove DU platform device This is due to the fact that no connector has been instantiated. The error message is pretty confusing, I'll submit a patch to make it clearer, but it won't fix the issue. With the platform data based DU instantiation the Lager and Koelsch board file contained LVDS panel information, and the DU driver instantiated one LVDS connector. I wanted to replicate that when moving to DT, but the approach has been rejected during review due to the fact that the panel isn't part of the Lager and Koelsch boards, and thus shouldn't be described in r8a7790-lager.dts or r8a7791-koelsch.dts. I've thus created a separate DT file (r8a77xx-aa104xd12-panel.dtsi) to describe the panel, which can be included directly in r8a7790-lager.dts or r8a7791-koelsch.dts as in the following patch. Please note that the patch won't be upstreamed due to the reason explained above. commit eca4ad5b98775c9a8cf5ee03598c3e5421f65030 Author: Laurent Pinchart Date: Fri Oct 24 14:53:13 2014 +0300 ARM: shmobile: koelsch: Add panel to DT Signed-off-by: Laurent Pinchart diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts index 624bb2c30513..5119ed12fe63 100644 --- a/arch/arm/boot/dts/r8a7791-koelsch.dts +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts @@ -648,3 +648,5 @@ &ssi1 { shared-pin; }; + +#include "r8a77xx-aa104xd12-panel.dtsi"