| Message ID | 3167220d1e262ff22078993a5beec55e82dfd951.1365079581.git.viresh.kumar@linaro.org (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Paul Mundt |
| Headers | show |
On Thu, Apr 04, 2013 at 06:24:22PM +0530, Viresh Kumar wrote: > This patch moves cpufreq driver of SUPERH architecture to drivers/cpufreq. Why? I am missing the cover email where I assume the explanation lies. > > Cc: Paul Mundt <lethal@linux-sh.org> > Cc: linux-sh@vger.kernel.org > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > Acked-by: Paul Mundt <lethal@linux-sh.org> > --- > arch/sh/Kconfig | 18 ------------------ > arch/sh/kernel/Makefile | 1 - > drivers/cpufreq/Kconfig | 18 ++++++++++++++++++ > drivers/cpufreq/Makefile | 1 + > .../kernel/cpufreq.c => drivers/cpufreq/sh-cpufreq.c | 2 -- > 5 files changed, 19 insertions(+), 21 deletions(-) > rename arch/sh/kernel/cpufreq.c => drivers/cpufreq/sh-cpufreq.c (99%) > > diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig > index 5e85963..06e3163 100644 > --- a/arch/sh/Kconfig > +++ b/arch/sh/Kconfig > @@ -624,25 +624,7 @@ config SH_CLK_CPG_LEGACY > endmenu > > menu "CPU Frequency scaling" > - > source "drivers/cpufreq/Kconfig" > - > -config SH_CPU_FREQ > - tristate "SuperH CPU Frequency driver" > - depends on CPU_FREQ > - select CPU_FREQ_TABLE > - help > - This adds the cpufreq driver for SuperH. Any CPU that supports > - clock rate rounding through the clock framework can use this > - driver. While it will make the kernel slightly larger, this is > - harmless for CPUs that don't support rate rounding. The driver > - will also generate a notice in the boot log before disabling > - itself if the CPU in question is not capable of rate rounding. > - > - For details, take a look at <file:Documentation/cpu-freq>. > - > - If unsure, say N. > - > endmenu > > source "arch/sh/drivers/Kconfig" > diff --git a/arch/sh/kernel/Makefile b/arch/sh/kernel/Makefile > index f259b37..261c8bf 100644 > --- a/arch/sh/kernel/Makefile > +++ b/arch/sh/kernel/Makefile > @@ -31,7 +31,6 @@ obj-$(CONFIG_VSYSCALL) += vsyscall/ > obj-$(CONFIG_SMP) += smp.o > obj-$(CONFIG_SH_STANDARD_BIOS) += sh_bios.o > obj-$(CONFIG_KGDB) += kgdb.o > -obj-$(CONFIG_SH_CPU_FREQ) += cpufreq.o > obj-$(CONFIG_MODULES) += sh_ksyms_$(BITS).o module.o > obj-$(CONFIG_KEXEC) += machine_kexec.o relocate_kernel.o > obj-$(CONFIG_CRASH_DUMP) += crash_dump.o > diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig > index 5030df5..602d5db 100644 > --- a/drivers/cpufreq/Kconfig > +++ b/drivers/cpufreq/Kconfig > @@ -258,5 +258,23 @@ depends on PPC32 || PPC64 > source "drivers/cpufreq/Kconfig.powerpc" > endmenu > > +menu "SH CPU Frequency scaling" > +depends on SUPERH > +config SH_CPU_FREQ > + tristate "SuperH CPU Frequency driver" > + select CPU_FREQ_TABLE > + help > + This adds the cpufreq driver for SuperH. Any CPU that supports > + clock rate rounding through the clock framework can use this > + driver. While it will make the kernel slightly larger, this is > + harmless for CPUs that don't support rate rounding. The driver > + will also generate a notice in the boot log before disabling > + itself if the CPU in question is not capable of rate rounding. > + > + For details, take a look at <file:Documentation/cpu-freq>. > + > + If unsure, say N. > +endmenu > + > endif > endmenu > diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile > index f6226d1..12607d9 100644 > --- a/drivers/cpufreq/Makefile > +++ b/drivers/cpufreq/Makefile > @@ -88,3 +88,4 @@ obj-$(CONFIG_CRIS_MACH_ARTPEC3) += cris-artpec3-cpufreq.o > obj-$(CONFIG_ETRAXFS) += cris-etraxfs-cpufreq.o > obj-$(CONFIG_IA64_ACPI_CPUFREQ) += ia64-acpi-cpufreq.o > obj-$(CONFIG_LOONGSON2_CPUFREQ) += loongson2_cpufreq.o > +obj-$(CONFIG_SH_CPU_FREQ) += sh-cpufreq.o > diff --git a/arch/sh/kernel/cpufreq.c b/drivers/cpufreq/sh-cpufreq.c > similarity index 99% > rename from arch/sh/kernel/cpufreq.c > rename to drivers/cpufreq/sh-cpufreq.c > index 88c8fee..73adb64 100644 > --- a/arch/sh/kernel/cpufreq.c > +++ b/drivers/cpufreq/sh-cpufreq.c > @@ -1,6 +1,4 @@ > /* > - * arch/sh/kernel/cpufreq.c > - * > * cpufreq driver for the SuperH processors. > * > * Copyright (C) 2002 - 2012 Paul Mundt > -- > 1.7.12.rc2.18.g61b472e > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 9 April 2013 18:25, Simon Horman <horms@verge.net.au> wrote: > On Thu, Apr 04, 2013 at 06:24:22PM +0530, Viresh Kumar wrote: >> This patch moves cpufreq driver of SUPERH architecture to drivers/cpufreq. > > Why? > > I am missing the cover email where I assume the explanation lies. Hi Simon, The idea was to keep all cpufreq drivers at a common and most suitable place, so that future consolidation work can be done easily and efficiently. So, functionally this patch shouldn't change anything. -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Apr 09, 2013 at 07:42:51PM +0530, Viresh Kumar wrote: > On 9 April 2013 18:25, Simon Horman <horms@verge.net.au> wrote: > > On Thu, Apr 04, 2013 at 06:24:22PM +0530, Viresh Kumar wrote: > >> This patch moves cpufreq driver of SUPERH architecture to drivers/cpufreq. > > > > Why? > > > > I am missing the cover email where I assume the explanation lies. > > Hi Simon, > > The idea was to keep all cpufreq drivers at a common and most suitable > place, so that future consolidation work can be done easily and efficiently. > > So, functionally this patch shouldn't change anything. Thanks, I understand. I have no objections to this, but Paul should probably review it. -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10 April 2013 07:42, Simon Horman <horms@verge.net.au> wrote: > Thanks, I understand. > > I have no objections to this, but Paul should probably review it. It is already Acked by him and applied by Rafael. -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Apr 10, 2013 at 08:21:51AM +0530, Viresh Kumar wrote: > On 10 April 2013 07:42, Simon Horman <horms@verge.net.au> wrote: > > Thanks, I understand. > > > > I have no objections to this, but Paul should probably review it. > > It is already Acked by him and applied by Rafael. :) -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig index 5e85963..06e3163 100644 --- a/arch/sh/Kconfig +++ b/arch/sh/Kconfig @@ -624,25 +624,7 @@ config SH_CLK_CPG_LEGACY endmenu menu "CPU Frequency scaling" - source "drivers/cpufreq/Kconfig" - -config SH_CPU_FREQ - tristate "SuperH CPU Frequency driver" - depends on CPU_FREQ - select CPU_FREQ_TABLE - help - This adds the cpufreq driver for SuperH. Any CPU that supports - clock rate rounding through the clock framework can use this - driver. While it will make the kernel slightly larger, this is - harmless for CPUs that don't support rate rounding. The driver - will also generate a notice in the boot log before disabling - itself if the CPU in question is not capable of rate rounding. - - For details, take a look at <file:Documentation/cpu-freq>. - - If unsure, say N. - endmenu source "arch/sh/drivers/Kconfig" diff --git a/arch/sh/kernel/Makefile b/arch/sh/kernel/Makefile index f259b37..261c8bf 100644 --- a/arch/sh/kernel/Makefile +++ b/arch/sh/kernel/Makefile @@ -31,7 +31,6 @@ obj-$(CONFIG_VSYSCALL) += vsyscall/ obj-$(CONFIG_SMP) += smp.o obj-$(CONFIG_SH_STANDARD_BIOS) += sh_bios.o obj-$(CONFIG_KGDB) += kgdb.o -obj-$(CONFIG_SH_CPU_FREQ) += cpufreq.o obj-$(CONFIG_MODULES) += sh_ksyms_$(BITS).o module.o obj-$(CONFIG_KEXEC) += machine_kexec.o relocate_kernel.o obj-$(CONFIG_CRASH_DUMP) += crash_dump.o diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig index 5030df5..602d5db 100644 --- a/drivers/cpufreq/Kconfig +++ b/drivers/cpufreq/Kconfig @@ -258,5 +258,23 @@ depends on PPC32 || PPC64 source "drivers/cpufreq/Kconfig.powerpc" endmenu +menu "SH CPU Frequency scaling" +depends on SUPERH +config SH_CPU_FREQ + tristate "SuperH CPU Frequency driver" + select CPU_FREQ_TABLE + help + This adds the cpufreq driver for SuperH. Any CPU that supports + clock rate rounding through the clock framework can use this + driver. While it will make the kernel slightly larger, this is + harmless for CPUs that don't support rate rounding. The driver + will also generate a notice in the boot log before disabling + itself if the CPU in question is not capable of rate rounding. + + For details, take a look at <file:Documentation/cpu-freq>. + + If unsure, say N. +endmenu + endif endmenu diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile index f6226d1..12607d9 100644 --- a/drivers/cpufreq/Makefile +++ b/drivers/cpufreq/Makefile @@ -88,3 +88,4 @@ obj-$(CONFIG_CRIS_MACH_ARTPEC3) += cris-artpec3-cpufreq.o obj-$(CONFIG_ETRAXFS) += cris-etraxfs-cpufreq.o obj-$(CONFIG_IA64_ACPI_CPUFREQ) += ia64-acpi-cpufreq.o obj-$(CONFIG_LOONGSON2_CPUFREQ) += loongson2_cpufreq.o +obj-$(CONFIG_SH_CPU_FREQ) += sh-cpufreq.o diff --git a/arch/sh/kernel/cpufreq.c b/drivers/cpufreq/sh-cpufreq.c similarity index 99% rename from arch/sh/kernel/cpufreq.c rename to drivers/cpufreq/sh-cpufreq.c index 88c8fee..73adb64 100644 --- a/arch/sh/kernel/cpufreq.c +++ b/drivers/cpufreq/sh-cpufreq.c @@ -1,6 +1,4 @@ /* - * arch/sh/kernel/cpufreq.c - * * cpufreq driver for the SuperH processors. * * Copyright (C) 2002 - 2012 Paul Mundt