[RFC,v3,29/35] Documentation/devicetree/bindings/soc/renesas/sh.yaml: Add SH7751 based target.

Commit Message

Yoshinori Sato Oct. 14, 2023, 2:54 p.m. UTC

Renesas SuperH based target definition.

Signed-off-by: Yoshinori Sato <[e-mail]>
---
 .../devicetree/bindings/soc/renesas/sh.yaml   | 32 +++++++++++++++++++
 1 file changed, 32 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/soc/renesas/sh.yaml

Comments

Geert Uytterhoeven Oct. 18, 2023, 6:48 p.m. UTC | #1

Hi Sato-san,

On Sat, Oct 14, 2023 at 4:54 PM Yoshinori Sato
<[e-mail]> wrote:
> Renesas SuperH based target definition.
>
> Signed-off-by: Yoshinori Sato <[e-mail]>

Thanks for your patch!

Please use a one-line prefix that matches the history of the other
files next to it:

    dt-bindings: soc: renesas: Document SH7751 based targets

> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/renesas/sh.yaml
> @@ -0,0 +1,32 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/renesas/sh.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas SuperH Platform
> +
> +maintainers:
> +  - Yoshinori Sato <[e-mail]>
> +
> +properties:
> +  $nodename:
> +    const: '/'
> +  compatible:
> +    oneOf:
> +      - description: RTS7751R2D Plus
> +        items:
> +          - enum:
> +              - renesas,rts7751r2d # Renesas SH4 2D graphics board
> +          - const: renesas,sh7751r
> +
> +      - description: Julian board
> +        items:
> +          - enum:
> +              - iodata,landisk  # LANDISK HDL-U
> +              - iodata,usl-5p   # USL-5P

These depend on "[RFC PATCH v3 27/35] Documentation/devicetree/bindings:
vendor-prefix add IO DATA DEVICE Inc.", so that patch should be moved
forward in the series.

> +          - const: renesas,sh7751r

Please merge both sections, as they use the same number of compatible
values and the same fallback.

> +
> +additionalProperties: true
> +
> +...
> --
> 2.39.2
>


--
Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [e-mail]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Geert Uytterhoeven Oct. 18, 2023, 6:49 p.m. UTC | #2

Hi Sato-san,

On Wed, Oct 18, 2023 at 8:48 PM Geert Uytterhoeven <[e-mail]> wrote:
> On Sat, Oct 14, 2023 at 4:54 PM Yoshinori Sato
> <[e-mail]> wrote:
> > +              - iodata,landisk  # LANDISK HDL-U
> > +              - iodata,usl-5p   # USL-5P
>
> These depend on "[RFC PATCH v3 27/35] Documentation/devicetree/bindings:
> vendor-prefix add IO DATA DEVICE Inc.", so that patch should be moved

My apologies. Somehow the patches didn't end up in the right order
in my mailbox, so please ignore this comment.

Gr{oetje,eeting}s,

                        Geert

Geert Uytterhoeven Oct. 18, 2023, 7:44 p.m. UTC | #3

Hi Sato-san,

On Wed, Oct 18, 2023 at 8:48 PM Geert Uytterhoeven <[e-mail]> wrote:
> On Sat, Oct 14, 2023 at 4:54 PM Yoshinori Sato
> <[e-mail]> wrote:
> > Renesas SuperH based target definition.
> >
> > Signed-off-by: Yoshinori Sato <[e-mail]>

> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/soc/renesas/sh.yaml
> > @@ -0,0 +1,32 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/soc/renesas/sh.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Renesas SuperH Platform
> > +
> > +maintainers:
> > +  - Yoshinori Sato <[e-mail]>
> > +
> > +properties:
> > +  $nodename:
> > +    const: '/'
> > +  compatible:
> > +    oneOf:
> > +      - description: RTS7751R2D Plus
> > +        items:
> > +          - enum:
> > +              - renesas,rts7751r2d # Renesas SH4 2D graphics board
> > +          - const: renesas,sh7751r
> > +
> > +      - description: Julian board
> > +        items:
> > +          - enum:
> > +              - iodata,landisk  # LANDISK HDL-U
> > +              - iodata,usl-5p   # USL-5P
> > +          - const: renesas,sh7751r
>
> Please merge both sections, as they use the same number of compatible
> values and the same fallback.

Unless we want to add an "renesas,sh7380" intermediate, as that is
the actual SoC in the landisk? I do not know what is the difference
between SH7380 and SH7751R.

Gr{oetje,eeting}s,

                        Geert

Yoshinori Sato Oct. 25, 2023, 11:58 a.m. UTC | #4

On Thu, 19 Oct 2023 04:44:12 +0900,
Geert Uytterhoeven wrote:
> 
> Hi Sato-san,
> 
> On Wed, Oct 18, 2023 at 8:48 PM Geert Uytterhoeven <[e-mail]> wrote:
> > On Sat, Oct 14, 2023 at 4:54 PM Yoshinori Sato
> > <[e-mail]> wrote:
> > > Renesas SuperH based target definition.
> > >
> > > Signed-off-by: Yoshinori Sato <[e-mail]>
> 
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/soc/renesas/sh.yaml
> > > @@ -0,0 +1,32 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/soc/renesas/sh.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Renesas SuperH Platform
> > > +
> > > +maintainers:
> > > +  - Yoshinori Sato <[e-mail]>
> > > +
> > > +properties:
> > > +  $nodename:
> > > +    const: '/'
> > > +  compatible:
> > > +    oneOf:
> > > +      - description: RTS7751R2D Plus
> > > +        items:
> > > +          - enum:
> > > +              - renesas,rts7751r2d # Renesas SH4 2D graphics board
> > > +          - const: renesas,sh7751r
> > > +
> > > +      - description: Julian board
> > > +        items:
> > > +          - enum:
> > > +              - iodata,landisk  # LANDISK HDL-U
> > > +              - iodata,usl-5p   # USL-5P
> > > +          - const: renesas,sh7751r
> >
> > Please merge both sections, as they use the same number of compatible
> > values and the same fallback.
> 
> Unless we want to add an "renesas,sh7380" intermediate, as that is
> the actual SoC in the landisk? I do not know what is the difference
> between SH7380 and SH7751R.

Everything here is SH7751R.
I didn't include J2, so I'll add it.
Other SoCs will be added after changing to DeviceTree.

> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> -- 
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [e-mail]
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

Yoshinori Sato Oct. 25, 2023, 12:05 p.m. UTC | #5

On Thu, 19 Oct 2023 04:44:12 +0900,
Geert Uytterhoeven wrote:
> 
> Hi Sato-san,
> 
> On Wed, Oct 18, 2023 at 8:48 PM Geert Uytterhoeven <[e-mail]> wrote:
> > On Sat, Oct 14, 2023 at 4:54 PM Yoshinori Sato
> > <[e-mail]> wrote:
> > > Renesas SuperH based target definition.
> > >
> > > Signed-off-by: Yoshinori Sato <[e-mail]>
> 
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/soc/renesas/sh.yaml
> > > @@ -0,0 +1,32 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/soc/renesas/sh.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Renesas SuperH Platform
> > > +
> > > +maintainers:
> > > +  - Yoshinori Sato <[e-mail]>
> > > +
> > > +properties:
> > > +  $nodename:
> > > +    const: '/'
> > > +  compatible:
> > > +    oneOf:
> > > +      - description: RTS7751R2D Plus
> > > +        items:
> > > +          - enum:
> > > +              - renesas,rts7751r2d # Renesas SH4 2D graphics board
> > > +          - const: renesas,sh7751r
> > > +
> > > +      - description: Julian board
> > > +        items:
> > > +          - enum:
> > > +              - iodata,landisk  # LANDISK HDL-U
> > > +              - iodata,usl-5p   # USL-5P
> > > +          - const: renesas,sh7751r
> >
> > Please merge both sections, as they use the same number of compatible
> > values and the same fallback.
> 
> Unless we want to add an "renesas,sh7380" intermediate, as that is
> the actual SoC in the landisk? I do not know what is the difference
> between SH7380 and SH7751R.

Details of the SH7380 have not been released,
but the hardware appears to be the same as the SH7751R.
I checked the original firmware source, and it was treated as the
same as the SH7751R.

> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> -- 
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [e-mail]
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

Patch

diff --git a/Documentation/devicetree/bindings/soc/renesas/sh.yaml b/Documentation/devicetree/bindings/soc/renesas/sh.yaml
new file mode 100644
index 000000000000..3fbff2532ad3
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/renesas/sh.yaml
@@ -0,0 +1,32 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/renesas/sh.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Renesas SuperH Platform
+
+maintainers:
+  - Yoshinori Sato <[e-mail]>
+
+properties:
+  $nodename:
+    const: '/'
+  compatible:
+    oneOf:
+      - description: RTS7751R2D Plus
+        items:
+          - enum:
+              - renesas,rts7751r2d # Renesas SH4 2D graphics board
+          - const: renesas,sh7751r
+
+      - description: Julian board
+        items:
+          - enum:
+              - iodata,landisk  # LANDISK HDL-U
+              - iodata,usl-5p   # USL-5P
+          - const: renesas,sh7751r
+
+additionalProperties: true
+
+...