From patchwork Sun Jan 18 20:29:24 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roel Kluin X-Patchwork-Id: 3057 X-Patchwork-Delegate: lethal@linux-sh.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n0IKP17T030772 for ; Sun, 18 Jan 2009 12:25:02 -0800 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754076AbZARU3Z (ORCPT ); Sun, 18 Jan 2009 15:29:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754640AbZARU3Z (ORCPT ); Sun, 18 Jan 2009 15:29:25 -0500 Received: from mail-ew0-f20.google.com ([209.85.219.20]:37412 "EHLO mail-ew0-f20.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754076AbZARU3Z (ORCPT ); Sun, 18 Jan 2009 15:29:25 -0500 X-Greylist: delayed 2546 seconds by postgrey-1.27 at vger.kernel.org; Sun, 18 Jan 2009 15:29:24 EST Received: by ewy13 with SMTP id 13so57664ewy.13 for ; Sun, 18 Jan 2009 12:29:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:content-type :content-transfer-encoding; bh=aDVyfpXmI2ScVKys5E4FsqI6yngu1CMb3XNPxvI3Zzk=; b=nTVnIn7W3kItrmjHSf8fFXymndojbPD2K62ALVksq6WDDPOB0dX6bbDuo42W5GQAQ7 7D0CONAwTgsZsJM/tVmeFu7bKjg/7phNUeiHFah7VkMMIPiH33bxof4qzeXjuSoLqz4b 1cWmhU4cYypYgUR7jtdT1w5Wg2yfsm+nuzdFE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :content-type:content-transfer-encoding; b=ufd4GVDgMsEDvzYLbFKRQWiA0ynK4O1anEL93r9rWe3KS1p5h+XB11nanCnAU3MGqf O9mGDasbL0+NT4px6cJJJ+h1AWSHaQ11Kuirkl12wWGpRLRq+dCXZwjqCueqVSiiNd74 BG1qPCQ5Qw0ugk9PsiTswOFQ6Te3vNHkx8XBE= Received: by 10.210.66.13 with SMTP id o13mr1826237eba.124.1232310563283; Sun, 18 Jan 2009 12:29:23 -0800 (PST) Received: from ?192.168.1.115? (d133062.upc-d.chello.nl [213.46.133.62]) by mx.google.com with ESMTPS id d23sm11904324nfh.68.2009.01.18.12.29.22 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 18 Jan 2009 12:29:22 -0800 (PST) Message-ID: <49739124.8050105@gmail.com> Date: Sun, 18 Jan 2009 21:29:24 +0100 From: Roel Kluin User-Agent: Thunderbird 2.0.0.18 (X11/20081105) MIME-Version: 1.0 To: Paul Mundt CC: linux-sh@vger.kernel.org Subject: [PATCH] make boguscnt signed and less bogus. Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org below in this function is: if (--boguscnt < 0) { printk(KERN_WARNING "%s: Too much work at interrupt, status=0x%4.4x.\n", ndev->name, intr_status); } I am not sure it's sane like this, but at least it appears less insane. Signed-off-by: Roel Kluin --- -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/sh_eth.c b/drivers/net/sh_eth.c index 7f8e514..3b9c20a 100644 --- a/drivers/net/sh_eth.c +++ b/drivers/net/sh_eth.c @@ -687,7 +687,8 @@ static irqreturn_t sh_eth_interrupt(int irq, void *netdev) { struct net_device *ndev = netdev; struct sh_eth_private *mdp = netdev_priv(ndev); - u32 ioaddr, boguscnt = RX_RING_SIZE; + u32 ioaddr; + int boguscnt = RX_RING_SIZE; u32 intr_status = 0; ioaddr = ndev->base_addr;